Commit Graph

18517 Commits (ad37b98cdab681a846085edab58e72af699c8349)

Author SHA1 Message Date
cai.zhang 966487962a
enhance: [Pick] Set default index name as field name (#29219)
master pr: #29218

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-15 12:02:37 +08:00
wei liu e8a480c28d
enhance: Enable balance channel in querycoord (#28469) (#29209)
issue: #23726
pr: #28469

1. enable auto balance channel between nodes in querycoord
2. make `genSegmentPlan` reuse the `AssignSegment` logic
3. make `genChannelPlan` reuse the `AssignChannel` logic

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-15 11:52:38 +08:00
congqixia d8d699401b
enhance: [cherry-pick] Add http method to control datacoord garbage collection (#29212)
Cherry-pick from master
pr: #29052
See also #29051

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi.Xia <congqi.xia@zilliz.com>
2023-12-15 02:16:38 +08:00
zhuwenxing 368a0cd55d
test: add more request type checker for test (#29211)
add more request type checker for test
pr: https://github.com/milvus-io/milvus/pull/29210

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-14 19:38:45 +08:00
zhuwenxing 6bf32d2f2b
test:add array data type and parquet file type for bulk insert case (#28990)
pr: https://github.com/milvus-io/milvus/pull/29030

add array data type and parquet file type for bulk insert test case

---------

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-14 19:36:39 +08:00
congqixia 7d2fa93ee8
enhance: [cherry-pick] remove reset seed for every shuffle (#29196)
Cherry-pick from master
pr: #29195
See also #29113
rand.Seed is deprecated and cost noticable CPU time during heavy payload

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 17:38:37 +08:00
yah01 5a8ddde92a
fix: load gets stuck probably (#29191) (#29192)
we found the load got stuck probably, and reviewed the logs.

the target observer seems not working, the reason is the taskDispatcher
removes the task in a goroutine, and modifies the task status after
committing the task into the goroutine pool, but this may happen after
the task removed, which leads to the task will never be removed

related #29086
pr: #29191

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-14 16:56:38 +08:00
wei liu 7ef49adbd2
enhance: Use mockery to replace manual mock code (#29074) (#29182)
issue: #29043
pr: #29074
This PR remove mannul mock code for proxy and data coord

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-14 16:44:43 +08:00
SimFG 32eb6380a5
fix: [2.3] missing the grant info when using the SelectGrant api with the default db (#29174)
issue: https://github.com/milvus-io/milvus/issues/29172
pr: #29173

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-14 16:20:43 +08:00
wei liu 9092b1ae8a
feat: enable balance based on growing segment row count (#28623) (#29184)
issue: #28622 
pr: #28623
query node with delegator will has more rows than other query node due
to delgator loads all growing rows.
This PR enable the balance segment which based on the num of growing
rows in leader view.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-14 15:26:37 +08:00
congqixia efef573c67
enhance: [cherry-pick] Add a config item for partition name as regexp feature (#29154) (#29183)
Cherry pick from master
pr: #29154 
See also #29177
Add a config item for partition name as regexp feature and disable it by
default

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 14:46:37 +08:00
wayblink 7946c2a8dc
fix: [cherry-pick] bulkinsert binlog didn't consider ts order when processing delta data (#29176)
issue: #29162
pr: #29163

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-14 14:38:38 +08:00
congqixia a108bf7bc1
enhance: improve datanode channel checkpoint source log (#29180)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-14 14:34:38 +08:00
XuanYang-cn d3cb489154
enhance: Change channel to Interface (#27839) (#29161)
This PR changes `*channel` into RWChannel interface

See also: #25309
pr: #27839

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-14 11:50:36 +08:00
SimFG c2ce7bce1a
fix: [2.3] the unstable unit test TestReplicateManager (#29147)
/kind improvement
pr: #28718

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-13 10:46:44 +08:00
congqixia 78865c02e1
enhance: [cherry-pick] Use zap.Stringer for large log field (#29143) (#29153)
Cherry pick from master
pr: #29143
See also #29113
Using zap.Stringer log field will evaluate log field value only when log
level meets the configuration, which could save some CPU time in search
route

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-13 09:48:38 +08:00
yah01 76757e53c4
enhance: Add more logs for target updating (#29090) (#29141)
This pull request enhances the logging functionality in the code related
to target updating. It adds more logs about the condition satisfying
when updating the target. The logs provide additional information about
the collection ID, replica number, channel readiness, segment readiness,
and leader view readiness. These logs will help in troubleshooting and
monitoring the target updating process.

pr: #29090

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-12 22:28:38 +08:00
Jiquan Long 00e6160848
fix: autoindex panic with flat index type (#29071) (#29072)
issue: https://github.com/milvus-io/milvus/issues/29048
pr: https://github.com/milvus-io/milvus/pull/29071

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-12 22:08:45 +08:00
wei liu 286dce0d3a
enhance: Add config for auto upgrade segment index (#29112) (#29133)
pr: #29112
This PR add config for auto upgrade segment index to index engine's
version.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-12 17:26:38 +08:00
Enwei Jiao 1e2a0dd127
enhance: Support otlp with insecure (#29131)
pr: https://github.com/milvus-io/milvus/pull/29115

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-12-12 16:44:37 +08:00
Jiquan Long c77fe38c39
fix: txn control not applied to snapshot.Remove (#29124) (#29137)
issue: #29123
pr: #29124 

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-12 16:37:44 +08:00
PowderLi 04d351e4bb
fix: wait server to listen the http port (#29076)
issue: #29068
master pr: #29075

wait server to listen the http port
then check whether various urls can be accessed normally

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-12 16:24:37 +08:00
yah01 4334e4e7ad
enhance: remove merger for load segments (#29062) (#29064)
remove merger as now QueryNode could load segments concurrently
fix https://github.com/milvus-io/milvus/issues/29063
pr: #29062

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-12 16:22:50 +08:00
cai.zhang bd46dc2d1b
enhance: [Pick]Support implicit type conversion for parquet (#29119)
issue: https://github.com/milvus-io/milvus/issues/29019
master pr: #29046

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-12 16:14:43 +08:00
wayblink af6714ef59
fix: [cherry-pick] fix rootcoord_collection_num metric is twice the real value (#29105)
pr: #28666

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-12 14:06:43 +08:00
wayblink e49860cb80
feat: Introduce channelCheckpointUpdater to reduce goroutine in ttNode (#29107)
pr: #28570

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-12-12 13:48:42 +08:00
PowderLi 92db41518d
enhance: upgrade proto to use partition related privileges (#29100)
issue: [milvus-proto
#212](https://github.com/milvus-io/milvus-proto/issues/212)
master pr: #28961

milvus can't use partition related privileges until upgrade
milvus-proto, even if them were added to milvus-proto

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-12 13:22:38 +08:00
nico 30ec598a08
test: modify cases for the update of IVF_FLAT (#29069)
pr: #27179

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-12-12 11:48:36 +08:00
congqixia d36bf21f28
enhance: [cherry-pick] Avoid initializing casbin enforcer for each request (#29118)
Cherry-pick from master
pr: #29117 
See also #29113

This patch:
- Replace plain Enforcer with `casbin.SyncedEnforcer`
- Add implementation of persist.Adapter with `MetaCacheCasbinAdapter`
- Invoke enforcer.LoadPolicy when policy updated

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-12 10:36:43 +08:00
congqixia 0b532b42ea
enhance: [cherry-pick] Add client connect wrapper to keep connection alive (#29061)
Cherry-pick from master
pr: #29058
See also #29057
Add wrapper to maintain client&connection
When reset operation is needed, close method shall wait until all
on-going request return

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-08 21:12:35 +08:00
edward.zeng 273be6c77a
fix: Fix etcd healthcheck command (#28357)
Fix etcd health check command.
/kind improvement
pr: #27980 
/cc @yanliang567

Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2023-12-08 17:57:23 +08:00
shaoyue ac0f000c29
enhance: Add proxy.ginLogSkipPaths (#29008)
pr: #28945

/cc @czs007

Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2023-12-08 17:55:30 +08:00
shaoyue ecbb6160aa
enhance: storeageType default value change to remote (#29009)
pr: #28792
/cc @czs007

Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2023-12-08 17:54:33 +08:00
zhenshan.cao bba0e159ba
feat: [pick] Add bypassing logic for ttMsg in flowgraph of DataNode(#28756) (#29036)
In order to minimize the CPU usage of the coroutine and avoid frequent
execution of time-consuming operations in the flowgraph when the message
stream consists solely of "ttMsg," it is recommended to implement a
mechanism for quickly bypassing the subsequent flowgraph node processing
logic.

If "ttMsg" is continuously received for a certain period of time
(coldTime), the flowgraph enters skipMode. Once in skipMode, every
skipNum "ttMsg" messages are merged into one for processing. If a
non-"ttMsg" message is received while in skipMode, the flowgraph exits
skipMode.

pr: #28756

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Co-authored-by: wayblink <anyang.wang@zilliz.com>
2023-12-08 12:10:39 +08:00
MrPresent-Han c21a1d59e4
fix: createCollection failed occasionally (#28592) (#28989)
related: #28592
pr:#https://github.com/milvus-io/milvus/pull/28712

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-08 11:34:39 +08:00
PowderLi 10d3224638
enhance: add 3 builtin roles #28961 (#29010)
issue: #28960
master pr: #28961

add new configuration: builtinRoles
user can define roles in config file: milvus.yaml

there is an example:

db_ro, only have read privileges, include load
db_rw, read and write privileges, include create/drop/rename collection
db_admin, not only read and write privileges, but also user
administration

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-08 10:52:36 +08:00
foxspy 82ac914bd4
enhance: [cherry-pick] support mmap for indexes loaded from disk file (#29002)
master pr: #28904 
issue: #28903

Signed-off-by: xianliang <xianliang.li@zilliz.com>
2023-12-08 10:32:34 +08:00
cai.zhang 7f59826089
enhance: [Pick]Make import-related error message clearer (#28979)
issue: #28976 
master pr: #28978

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-08 10:16:35 +08:00
MrPresent-Han cd34173e55
fix: fix precision for search reduce(#27325) (#29032)
related: #27325 
pr: https://github.com/milvus-io/milvus/pull/29031

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-08 10:10:35 +08:00
aoiasd b639fd66b4
fix: [Cherry-pick] accesslog can not print search expression (#28931)
relate: https://github.com/milvus-io/milvus/issues/28893
pr: https://github.com/milvus-io/milvus/pull/28899

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-08 02:00:36 +08:00
MrPresent-Han 5f4ac437b2
enhance: [Cherry-pick] Moving etcd client into session (#27069) (#28996)
relate: #26694
pr: https://github.com/milvus-io/milvus/pull/27069

Signed-off-by: Filip Haltmayer <filip.haltmayer@zilliz.com>
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
Co-authored-by: Filip Haltmayer <81822489+filip-halt@users.noreply.github.com>
2023-12-07 16:22:34 +08:00
aoiasd 8502037cff
fix: [Cherry-pick] sync action load segment with lack collection index info list (#28956)
relate: https://github.com/milvus-io/milvus/issues/28779
https://github.com/milvus-io/milvus/issues/28637
pr: https://github.com/milvus-io/milvus/pull/28788

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-07 14:14:42 +08:00
liliu-z f6700551be
enhance: Bump Knowhere's version to 2.2.3 (#29035)
Knowhere's new bug fix version:
https://github.com/zilliztech/knowhere/releases/tag/v2.2.3

related issues: #28821 #28810 #27552 #27516 #28603 #21483

Signed-off-by: Li Liu <li.liu@zilliz.com>
2023-12-07 14:08:33 +08:00
SimFG de28b73fe0
enhance: [2.3] Use a non-blocking method to trigger compaction when saveBinlogPath is executed (#28977)
/kind improvement
issue: #28924
pr: #28941

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-07 13:14:34 +08:00
aoiasd cb7b1d1d51
enhance: [Cherry-pick] pack proxy connection code and support accesslog print SDK_Version (#28844)
relate: https://github.com/milvus-io/milvus/issues/28086
pr: https://github.com/milvus-io/milvus/pull/28835

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-07 12:06:34 +08:00
cqy123456 8fd38c8eea
enhance:[cherry-pick] Use binlog index for better search performance (#29012)
this pr is cherry-pick from master:
pr: https://github.com/milvus-io/milvus/pull/28528
pr: https://github.com/milvus-io/milvus/pull/27673
related issue:
issue: https://github.com/milvus-io/milvus/issues/27678

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
2023-12-07 09:52:34 +08:00
PowderLi cdd1305f26
enhance: find collection schema from cache (#28916)
issue: #28781 #28329
master pr: #28782

1. There is no need to call `DescribeCollection`, if the collection's
schema is found in the globalMetaCache
2. did `GetProperties` to check the access to Azure Blob Service

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-06 22:44:33 +08:00
congqixia 2e82d65124
fix: [cherry-pick] Align minio object storage ut to new minio server behavior (#29015)
cherry-pick from master
pr: #29014
See also #29013

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-06 15:42:43 +08:00
yihao.dai 51614073ec
enhance: Update pymilvus (#28922) (#28991)
issue: https://github.com/milvus-io/milvus/issues/17614

pr: https://github.com/milvus-io/milvus/pull/28922

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-06 11:56:34 +08:00
zhenshan.cao cb19e590fb
fix: clean snapshots meta (#28502) (#28999)
issue: https://github.com/milvus-io/milvus/issues/28496 /kind bug
pr: #28502 
The input parameters collection.partitions and collection.Field are both
nil, so these two metas have not been cleared.

Signed-off-by: xige-16 <xi.ge@zilliz.com>
Co-authored-by: xige-16 <xi.ge@zilliz.com>
2023-12-06 09:51:01 +08:00