Commit Graph

18718 Commits (7014d352b3c7121f104dd2281d474d900beb5585)

Author SHA1 Message Date
yah01 e422a62a80
enhance: improve the handling for segcore error (#29471) (#29521)
- fix lost exception details in segcore
- improve the logs of handling errors from segcore

pr: #29471

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-27 19:06:46 +08:00
wei liu ad37b98cda
enhance: Rewrite gen stopping segment plan based on assign segment (29473) (#29480)
pr: #29473

`AssignSegment` method defines how to assign segment to nodes, but
score_based_balance implement another assign logic in
`genStoppingSegmentPlan`
This PR rewrite gen stopping segment plan based on assign segment.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 15:50:47 +08:00
wei liu d0bcbf3953
fix: Upgrade from 2.2 should update CollectionLoadInfo (#29443) (#29479)
pr: #29443
milvus branch 2.3 add `loadType` in CollectionLoadInfo, so for
collection meta upgrade from 2.2, we should add `loadType` to
CollectionLoadInfo. This PR update CollectionLoadInfo with `loadType`
when meet a old version CollectionLoadInfo

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 15:48:58 +08:00
Jiquan Long 82fb37e332
fix: panic in concurrent insert/query scenario (#29408) (#29488)
issue: https://github.com/milvus-io/milvus/issues/29405
pr: #29408 

---------

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-27 15:08:45 +08:00
congqixia 5ba0f476d5
fix: [2.3]parse logID from logPath if copyDeltalog find logID not provided (#29276)
Cherry-pick from master
pr: #29273
See also: #29272

This PR add `getDeltaLogID` to safely return logID when Binlog struct
has zero value logID. It parses logID from logPath if the format is
valid. Otherwise, this function shall return error.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-27 14:42:46 +08:00
wei liu 26b1853c54
fix: Auto balance param can't be updated by dynamic(#29501) (#29502)
pr: #29501
This PR fixed that auto balance param can't be updated by dynamic

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-27 14:30:53 +08:00
aoiasd 1311911a26
enhance: [Cherry-Pick] make sure stream closed (#29457)
relate: https://github.com/milvus-io/milvus/issues/28367
pr: https://github.com/milvus-io/milvus/pull/29456

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-27 10:02:46 +08:00
yah01 51cab791cf
fix: missing to support compact for Array type (#29505) (#29504)
the array type can't be compacted, the system could continue with the
inserted segments, but these segments can be never compacted

fix #29503
pr: #29505

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-27 08:15:51 +08:00
aoiasd f5bba79963
enhance: [Cherry-Pick] add default local path for access log (#29461)
relate: https://github.com/milvus-io/milvus/issues/29459
pr: https://github.com/milvus-io/milvus/pull/29460

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 17:52:47 +08:00
aoiasd 6eeb4b7f9a
enhance: [Cherry-Pick] Refine delete by expression for forbid proxy dml task scheduler hang (#29359)
relate: https://github.com/milvus-io/milvus/issues/29146
pr: https://github.com/milvus-io/milvus/pull/29340

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 17:50:48 +08:00
congqixia 14d8b1fe85
fix: [Cherry-pick] Add scope limit for querynode DeleteRequest (#29476)
Cherry-pick from master
pr: #29474 
See also #27515

When Delegator processes delete data, it forwards delete data with only
segment id specified. When two segments has same segment id but one is
growing and the other is sealed, the delete will be applied to both
segments which causes delete data out of order when concurrent load
segment occurs.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-26 16:40:50 +08:00
MrPresent-Han 95d1056e32
refine the range of chunk size config value(#29388) (#29472)
related: #https://github.com/milvus-io/milvus/issues/29388
pr: https://github.com/milvus-io/milvus/pull/29389

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-12-26 14:34:46 +08:00
wei liu 514da535e5
enhance: add metrics for stopping querynode balance progress (#29201) (#29390)
pr: #29201
This PR add three metrics to track the stopping balance progress.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-26 10:02:46 +08:00
aoiasd 477def9368
fix: [Cherry-Pick]Use uber atomic instead sync/atomic which only supported after go v1.20 (#29379)
relate: https://github.com/milvus-io/milvus/issues/29376
pr: https://github.com/milvus-io/milvus/pull/29377

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-26 10:00:47 +08:00
congqixia f25d1f9b2c
enhance: [cherry-pick] change protection to RLock for loadStreamDelete (#29452)
Cherry-pick from master
pr: #29450 
See also #29332

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-25 23:27:01 +08:00
aoiasd 908e075fdb
enhance: [Cherry-pick] pack datacoord Cluster and SessionManager with interface and mock them (#29171)
relate: https://github.com/milvus-io/milvus/issues/28861
https://github.com/milvus-io/milvus/issues/28854
pr: https://github.com/milvus-io/milvus/pull/28869

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-25 14:42:44 +08:00
PowderLi 0c3de8d886
fix: Partition related privileges should belong to Collection (#29429)
issue: #29427
master pr: #29428

it will try to find privilege_name from the object_type, while grant a
privilege to a role

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-25 14:18:43 +08:00
aoiasd 2256b53e03
fix: [Cherry-pick]Remove SetFinalizer which cause proxy msgstream memory leak (#29404)
relate: https://github.com/milvus-io/milvus/issues/28367
pr: https://github.com/milvus-io/milvus/pull/29403

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-25 10:16:53 +08:00
nico 60a90463d0
test: update test cases (#29416)
issue: #27518 #29274
pr: #29383

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-12-23 15:46:42 +08:00
yah01 0ec8c6c748
enhance: reduce the memory usage of variable length data (#29387) (#29402)
add all loading data into a buffer and then copy them into the a
fit-in-size memory
pr: https://github.com/milvus-io/milvus/pull/29387

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-22 16:56:42 +08:00
SimFG b69543c7dc
fix: [2.3] Clean the compaction plan info to avoid the object leak (#29368)
issue: https://github.com/milvus-io/milvus/issues/29296
pr: #29365

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-22 12:02:44 +08:00
wei liu 5fa63da4e3
fix: Rename invalid parameterutil package path (#29334) (#29391)
pr: #29334
This PR renames the invalid parameterutil package path

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-22 10:06:41 +08:00
SimFG 74e72ce27e
enhance: [2.3] Support to get the param value in the runtime (#29298)
pr: #29297
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-21 20:36:43 +08:00
yihao.dai d8800f5ca5
fix: Return time tick delay error and refine quota error messages (#29289) (#29363)
This pr:
Handles the time tick delay error when converting old error codes to
milvus errors.
Enhances quota error messages by eliminating "force deny" and
substituting it with "quota exceeded."

pr: https://github.com/milvus-io/milvus/pull/29289
issue: https://github.com/milvus-io/milvus/issues/29288

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2023-12-21 14:58:49 +08:00
chyezh ace81b8306
fix: fixup data race at generate binlog index (#29371)
issue: #29339
pr: #29370

Signed-off-by: chyezh <ye.zhen@zilliz.com>
2023-12-21 14:56:40 +08:00
congqixia 15bad6485f
enhance: [cherry-pick] refine proxy meta cache partition logic (#29315) (#29378)
Cherry-pick from master
pr: #29315
See also #29113

- Unify partition info refresh logic
- Prevent parse partition names for each partition key search request

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-21 14:16:42 +08:00
yah01 babfb7d671
enhance: remove all unnecessary string formatting (#29323) (#29361)
done by two regex expressions:

- `PanicInfo\((.+),[. \n]+fmt::format\(([.\s\S]+?)\)\)`
- `AssertInfo\((.+),[. \n]+fmt::format\(([.\s\S]+?)\)\)`

related: #28811
pr: #29323

Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-12-21 10:14:52 +08:00
congqixia 85f17ada74
fix: [cherry-pick] grpc client check session skipped due to role not match (#29358)
Cherry pick from master
pr: #29356
Related to #28815

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-21 10:12:51 +08:00
congqixia 9050b236e4
fix: [cherry-pick] delegator may mark segment offline by mistake (#29344)
cherry-pick from master
pr: #29343
See also #29332

The segment may be released before or during the request when delegator
tries to forward delete request to yet. Currently, these two situation
returns different error code.

In this particular case, ErrSegmentNotLoaded and ErrSegmentNotFound
shall both be ignored preventing return search service unavailable by
mistake.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-20 21:16:41 +08:00
sre-ci-robot 2227cad047
[automated] Update Pytest image changes (#29333)
Update Pytest image changes
See changes:
f1ed04bee7
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2023-12-20 19:52:42 +08:00
zhuwenxing 40ad5d714a
test: [skip e2e] [cherry-pick]fix getting hotfix image tag (#29350)
By adding conjunctions, you can obtain more accurate results.

pr: https://github.com/milvus-io/milvus/pull/29347

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-20 17:12:41 +08:00
congqixia 9acf32a0b7
enhance: [cherry-pick] change cp metric to absolute unix ts (#29328) (#29337)
Cherry pick from master
pr: #29328 

See also #29327

Change channel checkpoint metrics to unix seconds instead of checkpoint
timestamp lag value

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-20 15:04:42 +08:00
Xiaofan 8e13199da2
fix: frequent flush cause minio rate limit (#28625)
related to #28549
pr: #28626

1. avoid duplicated sync segments under syncing states
2. add jitter to avoid sync segments at the same time

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
2023-12-20 15:02:55 +08:00
zhuwenxing d9a9eefa49
test: add bulk insert benchmark for different file size (#29329)
add bulk insert benchmark for different file size

pr: https://github.com/milvus-io/milvus/pull/29320

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-20 14:38:40 +08:00
Jiquan Long 8ef0c571b3
enhance: make consistency level used in delete configurable (#29280) (#29284)
pr: #29280 
issue: #29279

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
2023-12-20 14:14:34 +08:00
cai.zhang 3182b9df5b
fix: [Pick]Set the default index name to the name of the existing index (#29281)
issue: #29269 
master pr: #29275

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
2023-12-20 14:10:40 +08:00
nico f1ed04bee7
enhance: update pymilvus version and test case (#29294)
pr: #29267

Signed-off-by: nico <cheng.yuan@zilliz.com>
2023-12-20 09:26:49 +08:00
yah01 cd9e3c4837
fix: creating growing segments may introduce many threads (#29314)
many growing segments may be created in a short time and there is no
restriction to the process, the CGO call will leave many threads

related: https://github.com/milvus-io/milvus/issues/29282
pr: #29306

Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-12-19 18:02:40 +08:00
aoiasd af54ce9e20
fix: [Cherry-pick] msgstream memory leak caused by config event don't deregister (#29268)
pr: https://github.com/milvus-io/milvus/pull/29266
relate: https://github.com/milvus-io/milvus/issues/28620

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-19 12:34:39 +08:00
wei liu 2d33c7fe41
enhance: Add config for querycoord auto balance channel (#29231) (#29262)
issue: #23726
pr: #29231
This PR add control config to querycoord's background auto balance
channel operation

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-18 14:32:41 +08:00
PowderLi 9af24da65a
fix: rootCoord decide the builtin role cannot be deleted (#29248)
issue: #29243

only rootCoord read the configuration item `builtinRoles`, so proxy
never know whether the role to be deleted is builtin.

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-18 14:22:42 +08:00
zhuwenxing 08877e56f7
test: fix gen array field (#29247)
fix gen array field

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2023-12-18 11:30:46 +08:00
PowderLi 4ab02da3ac
enhance: RESTFUL search api support range search (#29097)
issue: #29004
master pr: #29055

add a new parameter: `params`, which is a map[string]float64;
but now only 2 valid item: radius + range_filter;

Signed-off-by: PowderLi <min.li@zilliz.com>
2023-12-17 23:14:45 +08:00
congqixia 9a80dc666b
fix: flushTs is never reset in channelMeta (#29244)
See also #29156
FlushTs need to to be reset to MaxUint64 after channel checkpoint is
after this timestamp. Otherwise, the segment will be shattered and flush
queue will be filled with tasks

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-16 14:00:38 +08:00
congqixia 49c9dc4923
fix: [cherry-pick] balance_unstable_view unit test (#29127) (#29249)
Cherry-pick from master
pr: #29127
fix: #29126
Allow unstable output channel balance plan

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-12-16 00:16:39 +08:00
congqixia 4e8409e7dc
enhance: [cherry-pick] ignore proto generated files (#29250)
Cherry-pick from master
pr: #28537
ignore proto generated files
issue: #28566

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: sunby <sunbingyi1992@gmail.com>
2023-12-15 22:46:39 +08:00
XuanYang-cn 7facaa0c40
fix: [Cherry-pick] fix unstable ConsistencyHashPolicy ut (#28375) (#29235)
Fixes: #28372, #29234
pr: #28375

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-15 18:34:38 +08:00
Cai Yudong 0a2c38d942
enhance: Remove omp from segcore (#29236)
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
2023-12-15 16:12:38 +08:00
XuanYang-cn 7b0599765f
fix: [cherry-pick]Skip updating checkpoint after dropcollection (#29221)
pr: #29220

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-15 16:04:45 +08:00
wei liu 97d71c2580
enhance: Skip balance segment when channel need be balanced (#29116) (#29232)
issue: #28622
pr: #29216
After we support balance segment with growing segment count #28623, if
we balance segment and channel at same time, some segments need to be
rebalanced after balance channel finish.

This PR skip balance segment when channel need be balanced.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2023-12-15 15:58:37 +08:00