Commit Graph

54 Commits (4082315bd0df07bbe21e93f248934eb93b0247b3)

Author SHA1 Message Date
wayblink b74264881c
enhance: Refine compaction interfaces to support major compaction ()
Refine compaction interfaces in datacoord, support compaction result
with more than one segment. Prepare for major compaction.

related: 

Signed-off-by: wayblink <anyang.wang@zilliz.com>
2024-02-19 20:52:50 +08:00
chyezh f2985d8454
fix: compact operation on datacoord meta should preform as a transcation ()
issue: 

Signed-off-by: chyezh <chyezh@outlook.com>
2024-01-26 16:59:00 +08:00
smellthemoon e52ce370b6
enhance:don't store logPath in meta to reduce memory ()
don't store logPath in meta to reduce memory, when service get
segmentinfo, generate logpath from logid.


Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2024-01-18 22:06:31 +08:00
aoiasd cb18f18c1d
fix: compacted segment status was flushing instead flushed and L0 segment trigger gc slowly ()
relate: https://github.com/milvus-io/milvus/issues/29492

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2024-01-09 10:52:49 +08:00
XuanYang-cn 75e6b65c60
enhance: Use ChannelManger interface in Server ()
See also: 

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-01-08 17:46:47 +08:00
XuanYang-cn f1b6ccf305
enhance: compaction use ChannelManager interface ()
Rewrite compaction_test.go

See also: 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2024-01-02 18:08:49 +08:00
XuanYang-cn ae180d1628
enhance: Change ChannelManager to interface ()
Rewrite cluster test
issue: 

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-25 19:24:46 +08:00
SimFG 67ab0e424b
fix: Clean the compaction plan info to avoid the object leak ()
issue: 

Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-12-22 12:00:43 +08:00
aoiasd 3c32ba2407
enhance: pack datacoord Cluster and SessionManager with interface and mock them ()
relate: https://github.com/milvus-io/milvus/issues/28861
https://github.com/milvus-io/milvus/issues/28854

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-12-11 17:52:37 +08:00
XuanYang-cn 5bac7f7897
fix: Fix L0 compaction in datacoord ()
See also: 

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-12-05 18:44:37 +08:00
XuanYang-cn 9b371067d2
feat: Add Compaction views and triggers ()
- Add Compaction l0 views
- Add Compaction scheduler
- Add Compaction triggerv2
- Add Compaction view manager

See also: 

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-23 17:30:25 +08:00
XuanYang-cn 40d5c902b6
Enable getting multiple segments in plan result ()
Compaction plan result contained one segment for one plan. For l0
compaction would write to multiple segments, this PR expand the segments
number in plan results and refactor some names for readibility.

- Name refactory: - CompactionStateResult -> CompactionPlanResult -
CompactionResult -> CompactionSegment

See also: 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-14 15:56:19 +08:00
XuanYang-cn a153950b10
Change channel to Interface ()
This PR changes `*channel` into RWChannel interface

See also: 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-13 11:16:18 +08:00
XuanYang-cn 22c089894e
Add scheduler ()
See also: 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-11-07 03:18:18 +08:00
jaime 7f7c71ea7d
Decoupling client and server API in types interface ()
Co-authored-by:: aoiasd <zhicheng.yue@zilliz.com>

Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-09-26 09:57:25 +08:00
SimFG 26f06dd732
Format the code ()
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-09-21 09:45:27 +08:00
congqixia cc9974979f
Add staticcheck linter and fix existing problems ()
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-19 10:05:22 +08:00
MrPresent-Han 4f6122dd4a
enable ctx traceId for assignsegment on dc() ()
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
2023-09-18 09:53:22 +08:00
XuanYang-cn 9598a8b236
Fix timeout task never release queue ()
See also: , 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2023-08-30 11:12:27 +08:00
Jiquan Long 95f91e6e35
Fix segments meta not consistent between catalog and in-memory ()
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Co-authored-by: czs007 <zhenshan.cao@zilliz.com>
2023-07-21 14:21:05 +08:00
yiwangdr b9189b9f41
Organize mocks from types.go ()
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-07-14 10:12:31 +08:00
Bingyi Sun 70c4ddc6c5
Replace LoadWithPrefix with HasPrefix ()
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
2023-07-11 19:38:28 +08:00
Bingyi Sun 268368031c
Remove redundant kv mocks ()
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
2023-07-07 19:38:26 +08:00
congqixia 41af0a98fa
Use go-api/v2 for milvus-proto ()
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-06-09 01:28:37 +08:00
jaime c9d0c157ec
Move some modules from internal to public package ()
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-04-06 19:14:32 +08:00
SimFG 4a90490a67
Fix the `segment not found` error ()
Signed-off-by: SimFG <bang.fu@zilliz.com>
2023-03-17 17:27:56 +08:00
yah01 319f1773af
Fix segment not found if forward delete to empty segment ()
Signed-off-by: yah01 <yang.cen@zilliz.com>
2023-03-03 14:13:49 +08:00
Xiaofan 3d6bded115
Fix Row Number Mismatch ()
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2023-02-27 10:41:46 +08:00
Enwei Jiao 697dedac7e
Use cockroachdb/errors to replace other error pkg ()
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2023-02-26 11:31:49 +08:00
aoiasd 1894766235
Update datacoord compaction plan after datanode update plan to ensure consistency ()
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2023-02-15 16:00:33 +08:00
congqixia 7adabe09f1
Fix Alloc timstamp failure blocks compaction queue forever ()
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-02-07 19:02:31 +08:00
jaime 73d8509600
Improve ListSegments performance for datacoord catalog ()
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-01-06 14:33:36 +08:00
cai.zhang e5f408dceb
Merge IndexCoord and DataCoord ()
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2023-01-04 19:37:36 +08:00
Enwei Jiao 89b810a4db
Refactor all params into ParamItem ()
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-12-07 18:01:19 +08:00
congqixia 5e49b095f5
Fix compaction handler may double release and block forever ()
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-12-06 20:09:18 +08:00
SimFG dffcd974ff
Make sure that the segment path matches the segment id ()
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-11-18 15:35:09 +08:00
Xiaofan 11efa0bb5f
Fix compacted segment not dropped ()
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-10-27 17:15:32 +08:00
jaime d8ca56e084
Fix empty segment handoff fails ()
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-10-26 16:49:31 +08:00
SimFG a55f739608
Separate public proto files ()
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-10-16 20:49:27 +08:00
XuanYang-cn a0ce533727
Add a SyncSegments to sync meta between DN and DC ()
See also: 

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2022-09-27 16:02:53 +08:00
SimFG d7f38a803d
Separate some proto files ()
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-09-16 16:56:49 +08:00
jaime 362c663b22
Remove deprecated inner compaction type ()
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-09-07 19:16:34 +08:00
congqixia 43c14055f6
Fix test compact logic and data race ()
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-08-31 12:10:57 +08:00
Enwei Jiao 096149e33f
fix GetCompactionState hang ()
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-08-26 14:22:55 +08:00
cai.zhang c924f73105
Refactor for IndexCoord to support cloud ()
Co-authored-by: Zach41 <zongmei.zhang@zilliz.com>
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
Co-authored-by: Zach41 <zongmei.zhang@zilliz.com>
2022-08-25 15:48:54 +08:00
Enwei Jiao d9c7519107
refactor compaction concurency logic ()
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
2022-08-23 15:50:52 +08:00
codeman 70254c3ec5
Unified catalog interface for segment () ()
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Signed-off-by: kejiang <ke.jiang@zilliz.com>
Co-authored-by: kejiang <ke.jiang@zilliz.com>
2022-08-20 10:24:51 +08:00
cai.zhang ed94ecf847
Segments can't be compacted when they have reference lock ()
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2022-06-20 21:56:12 +08:00
Xiaofan 54aeb077e9
Refine compaction selection poliy ()
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-06-15 23:14:10 +08:00
Xiangyu Wang dba6a3f4b0
[skip e2e]Fix license missing issue in datacoord ()
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-12-28 15:43:51 +08:00