Commit Graph

181 Commits (312aa23c77fa7179898ed2f274c59c0f29fa1dc5)

Author SHA1 Message Date
zhenshan.cao 0699176d24
[skip ci]Fix golint error in rootcoord (#11352)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-11-05 23:06:58 +08:00
Cai Yudong a2ad88237d
Add deltaChannels in rootcoord core (#11097)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-03 21:04:14 +08:00
Cai Yudong 628a3274bf
Use lazy mode to set dml msgstream as producer (#10993)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-03 20:18:48 +08:00
Xiangyu Wang 54be3c15bf
Improve error message in rootcoord (#11071)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-02 16:18:36 +08:00
Xiangyu Wang 260c0597cb
Improve error message in rootcoord (#11070)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-02 16:16:43 +08:00
Xiangyu Wang 394e8ad634
Improve error message in rootcoord (#11072)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-02 16:14:36 +08:00
Cai Yudong 66b9684fe5
Update ListCollectionPhysicalChannels and ListCollectionVirtualChannels (#11007)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-11-02 15:50:30 +08:00
Xiangyu Wang 53b6b8d0fb
Improve error message in rootcoord (#10876)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-01 16:40:10 +08:00
Xiangyu Wang 07818ec26a
Improve error message in rootcoord (#10875)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-01 16:38:06 +08:00
Xiangyu Wang 1835a7cb0c
Improve error message in rootcoord (#10877)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-11-01 16:35:57 +08:00
Xiaofan 2df2d488e1
Fix Unit test fatal fail (#10933)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-30 10:24:38 +08:00
Xiaofan 93f205b49e
Rename param names (#10853)
* Rename param names

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>

* Rename configs

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-28 23:16:40 +08:00
Xiangyu Wang a7d55229f0
Improve error message in rootcoord (#10836)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-10-28 20:03:29 +08:00
Xiangyu Wang 77b94b3bcf
Improve log message in rootcoord (#10838)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-10-28 19:59:27 +08:00
Xiaofan 76ef1c9657
Fix Root Start hang (#10765)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-27 22:00:27 +08:00
Xiaofan 6fddcb3925
Fix Session checker for proxy (#10737)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-27 21:58:33 +08:00
XuanYang-cn bb7e3d3e70
Fix ParseHybridTs return type to int64 (#10583)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-27 16:30:28 +08:00
congqixia 555912f40e
Fix create meta table fails for compatibility issue (#10703)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-26 23:00:27 +08:00
groot 6db06ecf81
[skip ci] Fix typo (#10411)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-10-22 14:10:06 +08:00
congqixia ed2b8d67c0
Reduce info saved in SnapshotMeta (#10288)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-21 14:04:36 +08:00
Cai Yudong 8c67627150
[skip ci] Update comments (#10283)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-20 16:48:35 +08:00
Cai Yudong 0941c297e7
[skip ci] Fix typo (#10282)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-20 16:46:42 +08:00
Cai Yudong 0cd562d58b
[skip ci] Fix typo (#10281)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-20 16:44:49 +08:00
dragondriver 0e58b3f70a
[skip ci] Fix golint warning of meta_table (#9993)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-15 20:42:45 +08:00
congqixia ec6e8e4127
Hide liveChn into sessionutil and fix liveness init order (#9860)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-14 16:40:35 +08:00
dragondriver 72d3d470ba
Use the server id as identifier in system topology graph (#9825)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-10-14 11:12:38 +08:00
Cai Yudong c7566345eb
Simplify meta_snapshot interface (#9778)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-13 15:54:33 +08:00
NotRyan 5d26d88f10
Change English verbage in rood-coord log messages (#9762)
Signed-off-by: NotRyan <ryan.chan@zilliz.com>

Co-authored-by: NotRyan <ryan.chan@zilliz.com>
2021-10-13 10:50:41 +08:00
Cai Yudong 45340835a7
Fix CreateAlias/DropAlias/AlterAlias impl (#9701)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-12 17:40:34 +08:00
Yusup 49198dbce1
Disable dropping collection via alias (#8850)
Signed-off-by: Yusup <yusup@lsgrep.com>
2021-10-08 17:37:53 +08:00
Cai Yudong ed6101198b
[skip ci] Update order of header files (#8964)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-10-01 11:08:24 +08:00
Xiaofan 2c2b800ff4
Change Log Name with NodeId (#8721)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-10-01 08:52:50 +08:00
zhenshan.cao d1d5f9e409
Replace proto.MarshalTextString with proto.Marshal (#8542)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-29 20:26:00 +08:00
Yusup 4b53a7fc05
Fix GetIndexByName (#8780)
Signed-off-by: Yusup <yusup@lsgrep.com>
2021-09-28 21:52:20 +08:00
Xiaofan 1edc00cd82
Add a log ETCD path (#8739)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-28 13:54:03 +08:00
congqixia 88e319acda
Save start position in collection meta (#8682)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-27 18:10:00 +08:00
Xiaofan d38adda8c2
Rename log file based on node id (#8517)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-26 21:18:11 +08:00
groot a20a9c71e2
Reduce go unittest time cost (#8556)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-26 12:56:07 +08:00
Cai Yudong 177a465913
Clean golint warnings for rootcoord (#8383)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-23 15:10:00 +08:00
Xiaofan f5173b595f
Add a channel prefix for all channels (#8166)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-23 10:53:53 +08:00
Cai Yudong a62bce360b
Replace MarshalTextString with Marshal in rootcoord (#8341)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-23 10:37:54 +08:00
congqixia 9ebfd43195
Add comment for proxyManager (#8266)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-22 23:55:53 +08:00
congqixia c676979217
Add error detail when ddl fail (#8304)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-22 19:50:15 +08:00
Yusup bdfb78e936
Add aliases to DescribeCollection (#8268)
Signed-off-by: Yusup <yusup@lsgrep.com>
2021-09-22 16:20:48 +08:00
Xiangyu Wang c314b2b4a8
Remove unused label rules (#7929)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-18 18:19:51 +08:00
Yusup ccb57ba4b2
add collection alias (#7255)
Signed-off-by: Yusup <yusup@lsgrep.com>
2021-09-18 11:13:51 +08:00
godchen b3f965c7d4
Add unrecoverable error for retry. (#7828)
Signed-off-by: godchen <qingxiang.chen@zilliz.com>
2021-09-18 10:49:51 +08:00
Cai Yudong d10c6abc9e
Apply for msgstream from pool when creating collection (#7738)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-18 09:13:50 +08:00
dragondriver c3eb6f9761
Expose created time and updated time to rootcoord metrics (#8174)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-17 21:52:00 +08:00
Xiangyu Wang 1ee17464e8
Fix possible datarace in rootcoord (#8120)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-17 12:37:50 +08:00
congqixia 675b71cc30
Replace metaSnapshot with suffixSnapshot (#7975)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-15 22:05:49 +08:00
congqixia 55c47ab508
Add suffixSnapshot implementing SnapshotKV (#7948)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-15 15:23:49 +08:00
Cai Yudong ab84f95e66
[skip ci] Update debug log (#7956)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-15 14:39:48 +08:00
congqixia 7d53e44f3b
Depress gosec false positive (#7899)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-09-14 18:37:48 +08:00
zhenshan.cao e5e4b24954
Fix bug: describe collection return wrong shard number (#7841)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-14 11:59:47 +08:00
cai.zhang 8a458b7a38
Add log for building index about num rows (#7811)
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
2021-09-14 10:27:06 +08:00
dragondriver 8d239b6473
Add test cases for search task (#7796)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-13 17:12:19 +08:00
groot a953c912b2
Add unittest for timeticksync (#7793)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-13 16:32:44 +08:00
sunby 4c18910acd
Improve log print in rootcoord (#7354)
issue: #7306
Signed-off-by: sunby <bingyi.sun@zilliz.com>
2021-09-13 11:56:42 +08:00
groot c8f860dcfb
Add unittest for proxy_client_manager (#7729)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-10 18:10:00 +08:00
groot 020f109dd8
Add unittest for rootcoord util (#7688)
Signed-off-by: yhmo <yihua.mo@zilliz.com>
2021-09-10 16:41:48 +08:00
Cai Yudong 4e23ed9a18
Revert apply physical channels from pool (d5f7e358 and 3b960969) (#7687)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-10 13:00:00 +08:00
Cai Yudong d5f7e358aa
Let dml tolerant physical channels generated by old version (#7644)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-09 18:08:02 +08:00
zhenshan.cao 29e5138274
Fix unittest: timeout caused by excessive use of resources (#7653)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-09 17:39:30 +08:00
zhenshan.cao b0524adbd8
Support specified shard number when create collection (#7482)
Add shards_num to CollectionInfo

Modify dmlChannelNum config

Compatible with old meta

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-08 15:00:00 +08:00
Cai Yudong d15d3fa0ac
Improve rootcoord codecov (#7518)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-09-07 11:16:37 +08:00
zhenshan.cao 86afde4598
Fix unittest for rootcoord, should filter out timetick msg first (#7490)
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
2021-09-06 11:52:41 +08:00
dragondriver 960741ee16
Support more detailed metrics information (#7472)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 19:35:47 +08:00
dragondriver 1db573731b
Cache the system information metrics (#7436)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-03 17:15:26 +08:00
Xiangyu Wang acf4354b83
Add logs in rootcoord (#7457)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-09-03 14:10:10 +08:00
dragondriver 3721cbfea1
Proxy metrics integrates with other coordinators (#7400)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-09-01 17:35:00 +08:00
Cai Yudong 3b9609692b
Apply for msgstream from pool when creating collection (#7377)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-31 18:35:58 +08:00
dragondriver f0dbdd7f13
Expose metrics of root coordinator (#7228)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-08-31 11:45:59 +08:00
Cai Yudong f4b53df727
Revert "Apply for msgstream from pool when creating collection (#7323)" (#7376)
This reverts commit e6de86a433.
2021-08-31 11:07:58 +08:00
Cai Yudong e6de86a433
Apply for msgstream from pool when creating collection (#7323)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-31 09:47:58 +08:00
Xiangyu Wang c62f23e201
[skip ci]Remove neza2017 from reviewers (#7324)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-08-27 00:27:36 +08:00
congqixia 4d9f89df09
Add unit test for 7150 fix (#7276)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-25 14:41:52 +08:00
congqixia d83bc7fb54
Fix 0 ts when build index (#7272)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-24 21:15:52 +08:00
Xiaofan 58b2089692
Import Embedded Etcd Kv Part 1(#7112) (#7174)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-08-24 09:45:51 +08:00
Cai Yudong 8405d90f5e
proxy add illegal check for search result (#7227)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-23 17:03:51 +08:00
congqixia ec9ccd8bd1
Fix DropCollection not processed by datanode (#7151)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-08-19 15:06:12 +08:00
Cai Yudong 305fa9c17e
Fix timestamp go back issue for timeticksync (#7123)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-18 14:36:10 +08:00
Cai Yudong 21117241ec
Let system panic if kv operation fail (#7143)
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-08-17 23:06:10 +08:00
yukun 847586eb95
Add rocksmq retention (#6617)
Signed-off-by: fishpenguin <kun.yu@zilliz.com>
2021-08-16 18:46:10 +08:00
XuanYang-cn 6c5be83ea1
Refactor NewEtcdKV API (#7075)
This PR mainly did the following 3 things:

- Refactor NewEtcdKV API
- Add unittests for `kv/etcd/`, raise the coverage
up to 94%
- Correct some APIs from version to revision

The old NewEtcdKV() API took `clientv3.Client` as
one of the input, making everyone who using this API
had to create a new `clientv3.Client`. So there're a lot
of repeated codes everywhere.

Meanwhile, someplace didn't even check whether the
`clientv3.New()` returned error or not, and the old API
also didn't check whether the clientv3.Client was Nil.
This caused issue#6955.

Ectd's version and revision have nothing alike, they
represent different concepts, but our APIs kind of
mixed them all up. So I correct those APIs' names.

Resolves: #6955

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 11:04:09 +08:00
Xiangyu Wang 5e78fd6a97
[skip ci]Update approvers (#7063)
Signed-off-by: Xiangyu Wang <xiangyu.wang@zilliz.com>
2021-08-12 19:36:09 +08:00
xige-16 09199170a4
sync call querycoord releaseXXXX (#6978)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2021-08-03 21:47:24 +08:00
XuanYang-cn 47df4a2e57
Fix DataNode BackGroudGC problem (#6551)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-03 09:59:24 +08:00
neza2017 5adb69161f
Set CollectionInfo.CreateTime to the timestamp when save the metadata into etcd, (#6763)
not the timestamp when RootCoord receive the CreateCollection Request

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-23 14:36:12 +08:00
dragondriver 67c1fdd2c0
Show/Describe collections/partitions with created timestamp (#6700)
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
2021-07-21 18:00:14 +08:00
Cai Yudong cbb4052fdb
Support search and query output fields using wildcard (#6671)
* update wildcard polocy for search and query

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* mark xfail cases

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* mark xfail cases

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* optimize debug log

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix static-check

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-21 14:52:12 +08:00
neza2017 fac350cc58
fix tso (#6500)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-14 17:11:54 +08:00
neza2017 b66157358c
add more log for create collection (#6478)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-13 22:19:55 +08:00
neza2017 d4239f0cd8
masterservice -> rootcoord (#6447)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-13 09:37:40 +08:00
neza2017 8b89744c6b
search with exp (#6409)
* process float vector and binary vector field
on the search result

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* add more debug info on etcd

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>

* add debug info when grpc failed

Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-10 10:21:52 +08:00
Cai Yudong 21a9bcd844
Create default partition when receive CreateCollectionMsg (#6305)
* create default partition when create collection

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* fix unittest

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* adjust sleep time for unittest

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-06 09:16:03 +08:00
neza2017 ca4a562a72
simplify AddIndex, remove collID,PartID from parameters (#6291)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-05 10:08:02 +08:00
Cai Yudong bc8392eb1e
Add collectionID and partitionID into SegmentIndexInfo (#6289)
* add collectionID and partitionID into SegmentIndexInfo

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* add partID2SegID into meta table

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>

* update DropIndex

Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
2021-07-03 20:00:40 +08:00
neza2017 f8fa025dcc
start background go routine to check if all the segments have indexed (#6290)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-03 17:54:25 +08:00
neza2017 111a24a49f
remove msgstream of segment info (#6280)
Signed-off-by: yefu.chen <yefu.chen@zilliz.com>
2021-07-03 14:36:18 +08:00