milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
17,248 Commits
139 Branches
115 Tags
576 MiB
Commit Graph

269 Commits (2086b4f75d5326a8dc7e5e7a29e7baebfe8fa4f6)

Author SHA1 Message Date
Enwei Jiao c05b9ad539
Add event dispatcher for config (#20393) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2022-11-17 18:59:09 +08:00
smellthemoon a7ba416b5a
Remove invalid timestamp (#20557) 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
 2022-11-14 16:21:07 +08:00
smellthemoon 7325b3e1c3
Substitute traceid for msgid in rpc (#20450) 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
 2022-11-14 15:29:06 +08:00
Jiquan Long 6886cc3fd8
Fix rpc log of Proxy (#20409) 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
 2022-11-08 21:59:02 +08:00
congqixia 14c1182418
Add healthy check for InvalidateCollectionMetaCache (#20368) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-11-07 16:55:01 +08:00
Enwei Jiao 956c5e1b9d
Make Params singleton (#20088) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2022-11-04 14:25:38 +08:00
groot bee66631e3
Refine bulkload (#19671) 
Signed-off-by: yhmo <yihua.mo@zilliz.com>

Signed-off-by: yhmo <yihua.mo@zilliz.com>
 2022-10-27 16:21:34 +08:00
bigsheeper b074f530e6
Forbid createIndex if collection loaded before (#20100) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-10-27 13:05:31 +08:00
bigsheeper f0c616050a
Reduce and improve quota center log (#20058) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-10-25 19:39:30 +08:00
smellthemoon 581e1d8c35
Fill MsgBase ALL (#19912) 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
 2022-10-21 15:57:28 +08:00
cai.zhang 94c15a49e9
Can't drop loaded partition (#19938) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-10-21 14:41:28 +08:00
Xiaofan 3d3289ce3e
Fix collection metrics leakage (#19944) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-10-21 10:13:28 +08:00
xige-16 36accde034
Fix wrong msg when load failed (#19884) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>

Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-10-20 19:55:27 +08:00
jaime cf1491e41a
Add status for GetVersionResponse and CheckHealthResponse (#19895) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-10-20 19:47:33 +08:00
congqixia e8cf049392
Fix proxy trace operation name (#19932) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-10-20 18:35:28 +08:00
wayblink dbd60757c9
Support pass start_ts and end_ts through Import API (#19810) 
Signed-off-by: wayblink <anyang.wang@zilliz.com>

Signed-off-by: wayblink <anyang.wang@zilliz.com>
 2022-10-20 12:15:27 +08:00
cai.zhang 836081c8c7
Dropping index must happen without collection being loaded (#19886) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-10-19 23:17:44 +08:00
smellthemoon 108e51b2f0
[test]Create index before load and fix error message (#19874) (#19857) 
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Co-authored-by: zhuwenxing <wenxing.zhu@zilliz.com>
 2022-10-19 10:01:26 +08:00
Xiaofan 5b9988b627
Support collection level monitoring metrics (#19686) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-10-18 19:17:27 +08:00
jaime 59bcbf0cf6
Support check health for the service level (#19779) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-10-18 13:39:26 +08:00
cai.zhang 9d43947f1c
Must create index before load (#19516) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-10-17 18:01:25 +08:00
SimFG a55f739608
Separate public proto files (#19782) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-10-16 20:49:27 +08:00
bigsheeper f1e330a997
Add read result rate protection (#19728) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-10-13 14:57:24 +08:00
jaime 31db01b6ae
Support TTL for collection level (#19383) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-10-10 20:31:22 +08:00
wayblink 85e04d845c
Move GetComponentStates to milvus.proto, make it an external interface (#19594) 
Signed-off-by: wayblink <anyang.wang@zilliz.com>

Signed-off-by: wayblink <anyang.wang@zilliz.com>
 2022-10-10 15:55:22 +08:00
Xiaofan 6826964e60
Rename some interface and files in id allocator (#19605) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-10-09 10:06:58 +08:00
zhenshan.cao 0ac4bc32a5
Add logic of autoindex (#19570) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-10-08 15:38:58 +08:00
wayblink e7c2500c71
Implement GetPersistentSegmentInfo through datacoord (#19205) 
Signed-off-by: wayblink <anyang.wang@zilliz.com>

Signed-off-by: wayblink <anyang.wang@zilliz.com>
 2022-10-08 11:51:02 +08:00
SimFG 7d54e35fa5
Add the `GetLoadingProgress` RPC (#19491) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-10-01 09:02:55 +08:00
Jiquan Long 73463d030d
Fix dml stream leakage in Proxy (#19450) 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
 2022-09-27 19:18:54 +08:00
SimFG 13ca8936d1
Deprecate `GetIndexState` and `GetIndexBuildProgress` (#19451) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-09-27 19:12:54 +08:00
Ten Thousand Leaves b30c9d4f60
Support Bulk Load in Milvus 2.2 (#18982) 
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-09-26 18:06:54 +08:00
SimFG d7f38a803d
Separate some proto files (#19218) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-09-16 16:56:49 +08:00
bigsheeper 5cdd6ca251
Add quotaCenter, rateLimiter and rateCollector (#18636) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-09-16 09:56:47 +08:00
Jiquan Long a5e2d6b6fb
Refactor RootCoord (#18930) 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Co-authored-by: xaxys <tpnnghd@163.com>

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
Co-authored-by: xaxys <tpnnghd@163.com>
 2022-09-05 13:29:11 +08:00
SimFG 9cd19f5396
Return nil error when handling grpc request (#18955) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-09-02 21:12:59 +08:00
cai.zhang c924f73105
Refactor for IndexCoord to support cloud (#18643) 
Co-authored-by: Zach41 <zongmei.zhang@zilliz.com>
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
Co-authored-by: Zach41 <zongmei.zhang@zilliz.com>
 2022-08-25 15:48:54 +08:00
Zach 0c9a10e8f8
1. refine logging interfaces (#18692) 
2. adjust logs for query/search requests

Signed-off-by: Zach41 <zongmei.zhang@zilliz.com>

Signed-off-by: Zach41 <zongmei.zhang@zilliz.com>
 2022-08-23 10:44:52 +08:00
jaime 516fd928f9
Fix password verification miss cache (#18730) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-08-19 19:42:50 +08:00
SimFG 447ce8ee48
Handle some apis about the default role (#18647) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-08-15 16:40:48 +08:00
SimFG c267ad612d
Support Role-Based Access Control II (#18528) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-08-05 16:28:35 +08:00
SimFG ff0200210a
Support Role-Based Access Control (#18425) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-08-04 11:04:34 +08:00
Jeng.Gwan 638f6c36e9
Support to get real row count of segment (#18115) 
Signed-off-by: xaxys <zheng.guan@zilliz.com>
 2022-07-18 09:58:28 +08:00
congqixia a9aff3a678
Allocate ID for each insertMsg (#18217) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-07-11 14:38:24 +08:00
codeman 5fda8261d0
Fix: Unable to list newly created credential users (#18117) (#18153) 
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
 2022-07-07 21:16:22 +08:00
Zach 1c9647ff31
Merging multiple shard query/search requests into one rpc request if QueryNode is the leader of multiple shards of Collection (#17588) 
Signed-off-by: Zach41 <zongmei.zhang@zilliz.com>
 2022-07-06 15:06:21 +08:00
codeman 95a3830dc6
fix password comparison too slow (#17874) (#17897) 
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
 2022-06-29 20:02:18 +08:00
xige-16 8ff1a2c4c2
Print expr when proxy receive qyery req (#17662) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-06-23 13:42:13 +08:00
zhenshan.cao 5f44e45480
Add metrics on QueryNode and Proxy (#17328) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-06-02 16:06:03 +08:00
Jiquan Long adf3b14027
Refine channels management in Proxy. (#17334) 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
 2022-06-02 15:34:04 +08:00
zhenshan.cao 2763efc9b0
Add cache of grpc client of ShardLeader in proxy (#17301) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-06-02 12:16:03 +08:00
congqixia c88514bc49
Remove not used QueryChannel in Proxy and Query Cluster (#16856) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-05-30 19:50:04 +08:00
SimFG 731870211a
Support role-based access control (only pb) (#16987) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-05-28 00:04:01 +08:00
groot 3928da6493
Refine calc distance function (#17161) 
Signed-off-by: groot <yihua.mo@zilliz.com>
 2022-05-26 14:34:01 +08:00
yah01 de0ba6d495
Fix GetQuerySegmentInfo() returns incorrect result after LoadBalance (#17190) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-25 15:17:59 +08:00
zhenshan.cao 08a4dff41d
Add logic for search merging and a simple task scheduler for read tasks (#17022) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

Co-authored-by: cai.zhang <cai.zhang@zilliz.com>
Co-authored-by: bigsheeper <yihao.dai@zilliz.com>

Co-authored-by: cai.zhang <cai.zhang@zilliz.com>
Co-authored-by: bigsheeper <yihao.dai@zilliz.com>
 2022-05-23 16:41:58 +08:00
yah01 7746a5b742
Add NodeIds field for QuerySegmentInfo (#17121) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-05-20 18:03:58 +08:00
bigsheeper 9eeec4a2d5
Add collection load cache and InvalidateCollMetaCache by collID (#16882) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2022-05-19 10:13:56 +08:00
zhenshan.cao 97757405de
Fix bug: wrong metrics name and forget to register metrics (#16714) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-04-29 15:35:47 +08:00
zhenshan.cao 0a953948af
Simplify monitoring metrics (#16687) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-04-27 23:03:47 +08:00
groot bc5e9ec929
Add list import tasks api (#16605) 
Signed-off-by: groot <yihua.mo@zilliz.com>
 2022-04-25 17:37:46 +08:00
Xiaofan 89b4a34892
Fix Data race in NodeID (#16603) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-04-24 22:03:44 +08:00
yah01 804fbb6e27
Fix panic: Set Base of GetReplicas request (#16578) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-04-22 14:47:42 +08:00
congqixia 69252f812d
Implement memory replica in Proxy, QueryNode and QueryCoord (#16470) 
Related to #16298 #16291 #16154
Co-authored-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: yangxuan <xuan.yang@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Letian Jiang <letian.jiang@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-04-20 16:15:41 +08:00
Ten Thousand Leaves 289e468a7a
Make bulk load fully work (#16512) 
issue: #15604

/kind enhancement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-04-20 14:03:40 +08:00
codeman 3a1b2cedd2
create default root user for authentication (#16545) (#16549) 
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
 2022-04-20 13:03:40 +08:00
codeman f5e1ded854
fix #16504 (#16523) 
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
 2022-04-19 16:35:39 +08:00
Ten Thousand Leaves 442c73a544
Support passing channel names to DataNode (#16424) 
/kind feature

issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2022-04-12 13:25:34 +08:00
codeman 4e12271d79
Support login with username and password (#15656) (#16341) 
Signed-off-by: kejiang <ke.jiang@zilliz.com>

Co-authored-by: kejiang <ke.jiang@zilliz.com>
 2022-04-11 19:49:34 +08:00
XuanYang-cn 78200009a3
Impl GetReplicas in Proxy (#16390) 
See also: #16298

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
 2022-04-06 14:57:31 +08:00
xige-16 99984b88e1
Support delete varChar value (#16229) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-04-02 17:43:29 +08:00
Jiquan Long 973ea406ca
Improve log of show collections (#16233) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2022-03-28 21:47:27 +08:00
xige-16 205c92e54b
Support insert string data (#15993) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-03-25 14:27:25 +08:00
groot 2078b24dca
Prepare for import (#16083) 
Signed-off-by: groot <yihua.mo@zilliz.com>
 2022-03-21 15:47:23 +08:00
zhenshan.cao f3eeecf146
Reduce the number of metrics (#16030) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2022-03-15 21:51:21 +08:00
groot 5fdef607d5
Add rpc interfaces for import (#15930) 
Signed-off-by: yhmo <yihua.mo@zilliz.com>
 2022-03-09 18:33:59 +08:00
cai.zhang 2512dff261
Fix misuse of timerecord (#15868) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-03-04 15:45:56 +08:00
jaime 7a3a721380
Reconstruct mqstream module (#15784) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-03-03 21:57:56 +08:00
cai.zhang d183748484
Add some prometheus metrics for proxy (#15582) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-03-02 16:23:55 +08:00
Xiaofan be42627ab2
Move Logutil to Util dir (#15447) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-02-09 18:55:46 +08:00
xige-16 408a6e9e58
Fix collectResultLoop hang after search timeout (#15250) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2022-01-17 18:11:36 +08:00
Cai Yudong 6323907566
Use CommonConfig in GlobalParams for all components (#15106) 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
 2022-01-10 19:03:35 +08:00
congqixia b4d995ceb3
[skip e2e] Add comment for proxy ManualCompaction (#14619) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2021-12-30 19:15:22 +08:00
zhenshan.cao 32a5126705
Add the limitation of the traceable interval to timeTravel (#14498) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2021-12-29 21:29:45 +08:00
Xiaofan 7a4de9897d
Fix Rocksmq ignored error (#14011) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2021-12-24 14:14:15 +08:00
cxytz01 b5fe5fc10b
[skip e2e] Grammar correction (#14129) 
Signed-off-by: cxytz01 <xueyou.chen@zilliz.com>
 2021-12-24 12:57:36 +08:00
Cai Yudong 891c202b73
Use GlobalParamTable for all components (#13885) 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
 2021-12-23 18:39:11 +08:00
Jiquan Long 8a63dba149
Add consistency level field in collection meta (#13766) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2021-12-21 19:49:02 +08:00
Bingyi Sun 37705dfbbb
Add module name to logger in proxy (#13580) 
Signed-off-by: sunby <bingyi.sun@zilliz.com>

Co-authored-by: sunby <bingyi.sun@zilliz.com>
 2021-12-17 19:07:39 +08:00
zhenshan.cao bfdf6eb402
[skip e2e]Fix datarace in proxy (#13607) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2021-12-17 16:32:52 +08:00
Jiquan Long c26341c0cd
Refine log of CreateCollection (#13449) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2021-12-15 22:43:10 +08:00
Jiquan Long 1a0449f4f9
Refine log of ReleaseCollection (#13450) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2021-12-15 22:13:10 +08:00
xige-16 97d5231a0a
Reorganize querycoord proto (#13181) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2021-12-15 16:53:12 +08:00
dragondriver 22d77b6d83
Refine log of DropAlias (#13297) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2021-12-15 10:31:52 +08:00
dragondriver f7ccdd2cab
Refine log of AlterAlias (#13353) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2021-12-15 10:25:33 +08:00
dragondriver ee7e400640
Refine log of Query (#13295) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2021-12-15 10:19:10 +08:00
dragondriver 276b9a6cf5
Refine log of CreateAlias (#13296) 
Signed-off-by: dragondriver <jiquan.long@zilliz.com>
 2021-12-15 07:03:10 +08:00
Cai Yudong b5d639a1ab
Use typeutil.ProxyRole instead of Params.RoleName in proxy (#13217) 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
 2021-12-13 10:01:18 +08:00
jingkl 052fb7afbe
[skip ci]Add comments to impl (#13206) 
Signed-off-by: jingkl <jingjing.jia@zilliz.com>
 2021-12-10 22:53:27 +08:00
jingkl 3f0970153c
[skip ci]Add notes to impl (#13205) 
Signed-off-by: jingkl <jingjing.jia@zilliz.com>
 2021-12-10 22:01:17 +08:00