milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
18,435 Commits
153 Branches
122 Tags
589 MiB
Commit Graph

273 Commits (13a5b9f64a4714746abe311bde4b3bb848413019)

Author SHA1 Message Date
SimFG 26f06dd732
Format the code (#27275) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2023-09-21 09:45:27 +08:00
yah01 0a750408d0
Skip delta logs have been applied (#26971) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-19 16:21:23 +08:00
MrPresent-Han 33e3e78937
add metrics for query reduce (#27201) 
/kind improvement
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-09-19 14:53:22 +08:00
congqixia cc9974979f
Add staticcheck linter and fix existing problems (#27174) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-19 10:05:22 +08:00
MrPresent-Han 7939f0e7d5
enable ctx traceId for assignsegment on dc(#26972) (#27108) (#27030) 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-09-18 11:39:20 +08:00
Xiaofan e51cb739eb
Remove some logs in querynode delegator (#27156) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2023-09-18 10:57:20 +08:00
xige-16 488b423e1b
Fix high cpu usage caused by proto.size (#27054) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2023-09-17 20:55:21 +08:00
yihao.dai bb6711f28c
Add ChunkCache: support get vector from storage (#26142) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2023-09-15 10:21:20 +08:00
yah01 168e82ee10
Fix panic while handling with the nil status (#27040) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-15 10:09:21 +08:00
congqixia 394c898b4c
Discard SyncDistribution set action from legacy querycoord (#27027) 
Since Milvus in lower version (< 2.3.0), there is no load info in set action
which may corrupt data integrity and cause panicking

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-13 09:35:18 +08:00
yah01 00c65fa0d7
Refine QueryNode errors (#27013) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-12 16:07:18 +08:00
aoiasd e107d0794c
support complex delete expression (#25752) 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-09-12 10:19:17 +08:00
congqixia ac45af585b
Make segment loaded successful put in manager even ctx done (#26992) 
Leave segment loaded in manager even wait other segment failed
See also #26908
Fix error case in distributed scenario

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-11 21:33:18 +08:00
congqixia 2a5d574a0d
Fix querynodev2 concurrent load logic (#26959) 
Fix logic error from #26926
function `waitSegmentLoadDone` shall return error when context is done

Make delegator control concurrency for each same segment
Related to #26908

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-10 07:41:18 +08:00
congqixia c6116d1819
Remove segment to LocalSegment type assertion (#26931) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-09 10:35:16 +08:00
congqixia c8f9f22c4a
Fix segment loader return false success (#26926) 
`waitSegmentLoadDone` did not check waitCh result is success or failure
after load return without error, delegator will assume all segments are loaded

This PR changes waitCh to loadResult with `sync.Cond` with `atomic.Int32` to represent status

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-08 16:41:16 +08:00
Xu Tong 9166011c4a
Add float16 vector (#25852) 
Signed-off-by: Writer-X <1256866856@qq.com>
 2023-09-08 10:03:16 +08:00
XuanYang-cn 7f1ae35e72
Add timeout in dispatcher, AsConsumer and Seek (#26686) 
See also: #25309

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
 2023-09-08 09:51:17 +08:00
congqixia af5c01082b
Refine delegator lifetime control (#26881) 
- Add SafeChan interface in lifetime package
- Embed SafeChan into  interface
- Replace private lifetime struct in delegator package with
- Refine delegator on-going task lifetime control and wait all accepted task done
- Fix potential goroutine leakage from  if delegator closed concurrently

/kind improvement

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-07 10:11:15 +08:00
SimFG 28681276e2
Improve the retry of the rpc client (#26795) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2023-09-06 17:43:14 +08:00
MrPresent-Han 528948559f
fix false load failure for long unserviable period(#26813) (#26818) 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-09-06 12:57:15 +08:00
Enwei Jiao fb0705df1b
Decouple basetable and componentparam (#26725) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-09-05 10:31:48 +08:00
congqixia 4b58c71908
Add ctx parameter for organizeTask and GetWorker method (#26835) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-05 10:05:48 +08:00
congqixia 1a8cf5c415
Organize all mockery generation commands in Makefile (#26826) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-04 21:19:48 +08:00
yah01 3349db4aa7
Refine errors to remove changes breaking design (#26521) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-04 09:57:09 +08:00
congqixia e8f1b1736e
Remove log.Error(err.error())-style log (#26783) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-09-01 13:09:01 +08:00
XuanYang-cn ef75784715
Fix LoadSegmentLatency metric p99 (#26761) 
See also: #26743

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
 2023-09-01 11:07:07 +08:00
MrPresent-Han 8330c18dc9
add log for loading segment(#26564) (#26640) 
/kind improvement

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-08-31 12:03:00 +08:00
Gao 7e36f819b4
Make autoindex config clean (#26732) 
Signed-off-by: chasingegg <chao.gao@zilliz.com>
 2023-08-31 10:25:01 +08:00
yah01 bfcc691129
Fix segment leaked if task canceled (#26685) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-30 14:17:03 +08:00
congqixia 95dcf7fa06
Fix memory leak when Put duplicated segments (#26693) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-30 11:37:00 +08:00
congqixia 89fc9aad82
Improve sync target version logic (#26630) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-29 23:12:27 +08:00
congqixia 1cf6e00fa6
Improve segment manager interface (#26637) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-29 15:46:27 +08:00
wei liu 7af0f7d90c
avoid concurrent sub/unsub on same channel (#26454) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-23 10:10:22 +08:00
Xiaofan 7b3a1dc93f
Fix load index panic (#26457) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2023-08-21 09:56:20 +08:00
wei liu 3b11ad2695
fix dead lock in concurrent search/release segment (#26435) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-18 15:28:18 +08:00
cqy123456 fd37860e57
init knowhere build/search thread pool; (#26449) 
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
 2023-08-18 14:00:19 +08:00
yihao.dai 63b86b32a6
Add server id validation interceptor (#26395) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2023-08-17 20:20:20 +08:00
congqixia 123ad921e0
Fix querynodev2 search/query segments return unexpected grpc err (#26341) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-17 18:24:18 +08:00
Xiaofan ba806429fa
Remove frequent log on search growing segment (#26315) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2023-08-17 15:44:53 +08:00
congqixia 855a04539a
Set delegator lastUpdateTs to startTs (#26416) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-17 12:24:18 +08:00
yah01 5dae6a654a
Protect segment from being released while query/search (#26322) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-16 18:38:17 +08:00
yah01 3d8871b30e
Fix data race while updating segment version (#26387) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-16 16:30:18 +08:00
MrPresent-Han d30a920226
add log trace for segcore(#26277) (#26339) 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-08-16 11:41:33 +08:00
wei liu 23baecd70f
set sealed segment to unreadable before sync target version (#26338) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-15 17:27:35 +08:00
congqixia ec65a4e048
Use float64 for resource estimation log (#26335) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-15 14:25:33 +08:00
Enwei Jiao 7d61355ab0
Refactor log for Query (#26310) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-08-14 18:57:32 +08:00
yah01 a173486d2e
Fix calculation of memory usage prediction for mmap mode (#26264) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-12 17:19:31 +08:00
Gao 9ca8f28005
Fix missing totalChannelNum bug (#26295) 
Signed-off-by: chasingegg <chao.gao@zilliz.com>
 2023-08-11 18:35:29 +08:00
yah01 48422dd4c5
Fix spawn too many threads (#26293) 
- Low the thread pool cap
- Limit CGO calls concurrency

Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-11 18:29:29 +08:00
Gao b6fcbb0998
Support ScaNN index (#26099) 
Signed-off-by: chasingegg <chao.gao@zilliz.com>
 2023-08-11 14:21:29 +08:00
wei liu b47a72bfcf
fix set dirty segment distribution to leader view (#26180) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-11 11:21:32 +08:00
xige-16 1971d98897
Add disk metric info (#25675) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2023-08-11 10:35:42 +08:00
Enwei Jiao ca1349708b
Remove time travel ralted testcase (#26119) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-08-10 18:53:17 +08:00
xige-16 1055c90456
Add default retrieve limit (#24782) 
Signed-off-by: xige-16 <xi.ge@zilliz.com>
 2023-08-10 14:11:15 +08:00
yah01 300fef446b
Enable mmap for vector index (#25877) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-10 13:59:15 +08:00
yah01 889424b3f9
Fix load index with empty file list (#26236) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-09 18:39:16 +08:00
congqixia eea9197306
Perform alter distribution under mutex protection (#26229) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-09 13:05:15 +08:00
wei liu f33a89387f
enable config shard level cost metrics whether contains worker's cost (#26132) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-09 11:37:15 +08:00
yah01 99c633954a
Downgrade the log level in search path (#26188) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-08 18:35:14 +08:00
Bingyi Sun 54c0e64059
Fix search on empty segments set bug (#26136) 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
 2023-08-08 11:17:08 +08:00
MrPresent-Han 68ecf49ed5
fix lost parameter for threadCoefficient(#25781) (#26109) 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-08-03 12:05:06 +08:00
yah01 d9074bcb06
Remove unused code (#26100) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-08-03 09:45:05 +08:00
MrPresent-Han 5634ba777d
add new threadpool with various priority to avoid deadlock(#25781) (#26028) 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-08-03 09:31:07 +08:00
smellthemoon 3fc18c53a3
Fix wrong log (#26022) 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
 2023-08-02 11:01:07 +08:00
yah01 9c55a7f422
Add worker num as one of load resource (#26045) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-08-01 21:47:06 +08:00
Jiquan Long 5c1f79dc54
Push down the limit operator to segcore (#25959) 
Signed-off-by: longjiquan <jiquan.long@zilliz.com>
 2023-08-01 20:29:05 +08:00
aoiasd 7fec0d61cc
Refine test chunkmanager of querynode v2 (#25888) 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-08-01 10:33:04 +08:00
congqixia 8b5e276361
Use different cgo pool for SQ and other operations (#26021) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-08-01 09:19:05 +08:00
yah01 39b00b97a6
Add more logs for committed resources (#26026) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-31 19:27:03 +08:00
yah01 8245e078c0
Add max segment size log (#26015) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-31 14:37:04 +08:00
zhagnlu 833674c1cb
add glog configurable function and redirect aws log to segcore log (#25664) 
Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
 2023-07-27 19:49:02 +08:00
congqixia 5fbe6e99fd
Remove debug log from segment loader (#25937) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-26 18:51:01 +08:00
wei liu 302897f866
refine look aside balance logic (#25837) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-25 18:51:01 +08:00
yah01 3735a097e6
Refine the memeory usage prediction (#25889) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-25 17:41:01 +08:00
congqixia 0bc03ede0d
Add eventlog pkg and support grpc streaming event observation (#25812) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-25 17:23:01 +08:00
wei liu a132122370
fix time unit in insert/delete cost metrics value (#25893) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-25 15:07:01 +08:00
aoiasd b533c68632
Forbid update checkpoint without msgID (#25694) 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-07-25 10:43:04 +08:00
wei liu 0e26486abc
fix segment num in log (#25876) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-25 09:13:00 +08:00
yah01 168f346620
Remove deprecated interface (#25864) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-07-24 17:47:00 +08:00
wei liu fc19b85a40
fix count(*）retrieve redundant growing segment (#25825) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-24 14:09:00 +08:00
wei liu 32827f538a
add metrics for delegator insert/delete cost (#25733) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-21 15:30:59 +08:00
yah01 361db51337
Create dir if mmap enabled for validating path (#25750) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-19 18:48:58 +08:00
Cai Yudong 9a4761dcc7
Remove binary metrics TANIMOTO/SUPERSTRUCTURE/SUBSTRUCTURE (#25708) 
Signed-off-by: Yudong Cai <yudong.cai@zilliz.com>
 2023-07-19 16:16:58 +08:00
yah01 079cd9dc70
Add caller skip to improve the log for segcore error (#25710) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-18 19:54:57 +08:00
congqixia cc71e065e3
Support load index after segment loaded (#25567) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-18 10:51:19 +08:00
congqixia c490b30db7
Fix segment loader skip wait if all segments are loading (#25643) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-17 19:51:18 +08:00
MrPresent-Han 49655d2f13
fix panic due to lack of indexInfo on querynode(#25362) (#25613) 
Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
 2023-07-17 19:23:19 +08:00
yah01 948d1f1f4a
Handle errors by merr for QueryCoord (#24926) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-17 14:59:34 +08:00
Zhihong Yu a7023ab3cc
Narrow the scope of deleteMut lock in loadStreamDelete (#25436) 
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
 2023-07-17 09:30:34 +08:00
wei liu b62c82af22
fix set target version in loading sealed segment (#25603) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-14 20:00:31 +08:00
congqixia f2b14b43de
Add log field for local worker call (#25594) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-14 17:34:31 +08:00
congqixia a7e6f08183
Fix DeleteCollection not protected (#25599) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-14 17:04:31 +08:00
Enwei Jiao 66fdc71479
Refactor logs in DataCoord & DataNode (#25574) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-07-14 15:56:31 +08:00
yah01 d216f9abda
Clear collection meta after all channels/segments released (#25486) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-14 10:28:30 +08:00
yiwangdr b9189b9f41
Organize mocks from types.go (#25466) 
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
 2023-07-14 10:12:31 +08:00
wei liu b72809db15
fix release sealed segment on unwatch channel (#25555) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-13 14:30:29 +08:00
yah01 205a7c430a
Fix QueryNode panic while inserting to released segment (#25495) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-07-12 19:48:29 +08:00
SimFG f9e2d00f91
Prevent `exclusive consumer` exception in pulsar (#25376) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2023-07-12 17:26:30 +08:00
yihao.dai 4c93495587
Add segment size metric in querynode (#25406) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2023-07-12 14:26:28 +08:00