Commit Graph

21733 Commits (05ac4041aa26f8b229343d962eb0639270519149)

Author SHA1 Message Date
yihao.dai 272d95ad79
enhance: Reduce mutex contention in datacoord meta (#38219)
1. Using secondary index to avoid retrieving all segments at
`GetSegmentsChanPart`.
2. Perform batch SetAllocations to reduce the number of times the meta
lock is acquired.

issue: https://github.com/milvus-io/milvus/issues/37630

---------

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-01-15 01:15:02 +08:00
Cai Yudong 5bf1b2b929
feat: Support Int8Vector in go (#38990)
Issue: #38666

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2025-01-14 20:43:06 +08:00
congqixia d89768f9e0
enhance: Unify LoadStateLock RLock & PinIf (#39206)
Related to #39205

This PR merge `RLock` & `PinIfNotReleased` into `PinIf` function
preventing segment being released before any Read operation finished.

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-14 18:38:59 +08:00
aoiasd da07993082
enhance: report auth log to hook when grpc authenticate failed (#38943)
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
2025-01-14 17:47:04 +08:00
junjiejiangjjj 097d167e96
doc: Update tools info (#39244)
Signed-off-by: junjie.jiang <junjie.jiang@zilliz.com>
2025-01-14 16:53:00 +08:00
Zhen Ye fd84ed817c
enhance: add broadcast operation for msgstream (#39040)
issue: #38399

- make broadcast service available for msgstream by reusing the
architecture streaming service

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-14 15:14:59 +08:00
congqixia da1b786ef8
enhance: Utilize "find0" in segment.find_first (#39229)
Related to #39003

Previous PR #39004 has to clone & flip bitset due to bitset does not
support find0 operator. #39176 added this feature so clone & flip could
be removed now.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-14 14:14:58 +08:00
Zhen Ye 3e788f0fbd
enhance: record memory size (uncompressed) item for index (#38770)
issue: #38715

- Current milvus use a serialized index size(compressed) for estimate
resource for loading.
- Add a new field `MemSize` (before compressing) for index to estimate
resource.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-14 10:33:06 +08:00
Buqian Zheng 5e38f01e5b
enhance: update knowhere version (#39212)
Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2025-01-14 10:21:05 +08:00
Alexander Guzhva 3447ff7310
enhance: [bitset] extend op_find() to be able to search both 0 and 1 (#39176)
issue: #39124 

`bitset::find_first()` and `bitset::find_next()` now accept one more
parameter, which allows to search for `0` bit instead of `1` bit

Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
2025-01-14 09:50:58 +08:00
yihao.dai 702347bbfd
fix: Fix incorrect memory estimation for small segments (#38813)
Skip estimation index memory logic for segments without index file.

issue: https://github.com/milvus-io/milvus/issues/37630

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
2025-01-13 21:49:12 +08:00
sre-ci-robot cc8e6ebd5e
[automated] Bump milvus version to v2.5.3 (#39215)
Bump milvus version to v2.5.3
Signed-off-by: sre-ci-robot sre-ci-robot@users.noreply.github.com

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2025-01-13 18:37:03 +08:00
congqixia b3daae8e40
fix: Make KeyLock obj pool size unlimited (#39182)
Related to #39181

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-13 18:04:58 +08:00
Bingyi Sun a00ba861a4
fix: Fix in filter search result is empty if pk type is varchar (#39106)
https://github.com/milvus-io/milvus/issues/39107

Signed-off-by: sunby <sunbingyi1992@gmail.com>
2025-01-13 16:14:58 +08:00
smellthemoon accc9e7fbf
fix: fail to get empty index num rows (#39155)
#39125

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2025-01-13 16:04:58 +08:00
sthuang 5c5948cb70
fix: rbac custom group privilege level check (#39164)
related: https://github.com/milvus-io/milvus/issues/39086

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-01-13 11:24:59 +08:00
Zhen Ye 5f94954bb4
fix: data race when accessing field_ when retrieving (#39151)
issue: #39148

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-13 11:23:04 +08:00
wei liu cc5d59392a
fix: channel unbalance during stopping balance progress (#38971)
issue: #38970
cause the stopping balance channel still use the row_count_based policy,
which may causes channel unbalance in multi-collection case.

This PR impl a score based stopping balance channel policy.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-13 11:21:06 +08:00
Buqian Zheng 640a49ffb6
fix: fix chunk cache madvise when sparse raw data is mmaped (#39145)
instead of marking as not supported,
`ChunkedSparseFloatColumn::DataByteSize` can simply use the impl of
super class.

issue: https://github.com/milvus-io/milvus/issues/39158

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
2025-01-13 10:34:57 +08:00
sthuang 3cd74037db
fix: restore rbac with empty meta panic (#39141)
related: https://github.com/milvus-io/milvus/issues/38985

Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
2025-01-13 10:02:57 +08:00
Cai Yudong 2a02bbe3ee
enhance: Use template to remove unittest duplication (#39144)
Issue: #38666

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2025-01-13 09:58:57 +08:00
Spade A 032292a432
feat: support phrase match query (#38869)
The relevant issue: https://github.com/milvus-io/milvus/issues/38930

---------

Signed-off-by: SpadeA-Tang <tangchenjie1210@gmail.com>
2025-01-12 20:24:58 +08:00
zhuwenxing a8a65641b5
test: update reatful api timeout (#39139)
/kind improvement

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
2025-01-11 14:21:03 +08:00
SimFG 86d665a50f
enhance: keylock object background recycling (#38805)
issue: #38587

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-10 18:20:59 +08:00
SimFG 357eaf0d71
fix: use the object heap to keep the min ddl ts order (#39118)
issue: #39002

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-10 18:16:58 +08:00
wei liu 826b726c86
fix: Prevent leader checker from generating excessive duplicate leader tasks (#39000)
issue: #39001
Background:
Segment Load Version: Each segment load request assigns a timestamp as
its version. When multiple copies of a segment are loaded on different
QueryNodes, the leader checker uses this version to identify the latest
copy and updates the routing table in the leader view to point to it.
Delegator Router Version: When a delegator builds a route to a QueryNode
that has loaded a segment, it also records the segment's version.

Router Table Update Logic: If the leader checker detects that the
version of a segment in the routing table does not match the version in
the worker, it updates the routing table to point to the QueryNode with
the latest version. Additionally, it updates the segment's load version
in the QueryNode during this process.

Issue:
When a channel is undergoing load balancing, the leader checker may sync
the routing table to a new delegator. This sync operation modifies the
segment's load version, which invalidates the routing in the old
delegator. Subsequently, the leader checker updates the routing table in
the old delegator, breaking the routing in the new delegator. This cycle
continues, causing repeated updates and inconsistencies.

Fix:
This PR introduces two changes to address the issue:
1. Use NodeID to verify whether the delegator's routing table needs an
update, avoiding unnecessary modifications.
2. Ensure compatibility by using the latest segment's load version as
the version recorded in the routing table.

These changes resolve the cyclic updates and prevent the leader checker
from generating excessive duplicate tasks, ensuring routing stability
across delegators during load balancing.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-10 14:12:57 +08:00
XuanYang-cn b8fca4f5c1
fix: Clustering compaction ignoring deltalogs (#39132)
See also: #39131

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2025-01-10 14:07:05 +08:00
Ted Xu 4355b485e5
enhance: remove compaction parallelism control (#39081)
See #39080

---------

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
2025-01-10 13:23:00 +08:00
Xianhui Lin e5eb1159e2
fix: Refine the err msg of alter index invalid (#39137)
fix: Refine the err msg of alter index invalid
issue: https://github.com/milvus-io/milvus/issues/38517

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
2025-01-10 12:08:57 +08:00
wt 7d32603d4d
test: add more varchar expressions for query (#39122)
Signed-off-by: wangting0128 <ting.wang@zilliz.com>
2025-01-10 10:54:57 +08:00
Zhen Ye bb8d1ab3bf
enhance: make new go package to manage proto (#39114)
issue: #39095

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-10 10:49:01 +08:00
ThreadDao 461c376b46
test: add test cases for template param (#38867)
issue: #33419
- add case for Get
- add case for TemplateParam

Signed-off-by: ThreadDao <yufen.zong@zilliz.com>
2025-01-10 09:38:58 +08:00
jaime 22b8f6a58e
enhance: excessive disk usage logs generated if the path does not exist (#38821)
issue: #38820

Signed-off-by: jaime <yun.zhang@zilliz.com>
2025-01-09 19:43:04 +08:00
jaime f03a85725a
enhance: add db name in replica (#38672)
issue: #36621

Signed-off-by: jaime <yun.zhang@zilliz.com>
2025-01-09 19:40:59 +08:00
smellthemoon 92a2d608ac
fix: Bulk insert failed when the nullable/default_value field is not exist (#39063)
#39036

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2025-01-09 19:27:03 +08:00
Zhen Ye 3bcdd92915
enhance: add broadcast for streaming service (#39020)
issue: #38399 

- Add new rpc for transfer broadcast to streaming coord
- Add broadcast service at streaming coord to make broadcast message
sent automicly

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-09 16:24:55 +08:00
Cai Yudong d6206ad2de
fix: Remove duplicated Macro definition (#39076)
Issue: #39102

Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
2025-01-09 15:26:56 +08:00
Spade A 8abf6c9149
fix: build text index when loading field data (#39070)
fix: https://github.com/milvus-io/milvus/issues/39053
may fix https://github.com/milvus-io/milvus/issues/38644 which could be
caused by https://github.com/milvus-io/milvus/issues/39053

---------

Signed-off-by: SpadeA-Tang <tangchenjie1210@gmail.com>
2025-01-09 15:24:56 +08:00
SimFG aceb972963
enhance: update the expr static web page (#39082)
issue: #39083
/kind improvement
Three new functions of the static web page:
1. The input box can be expanded and scrolled if it exceeds the maximum
size
2. Input history
3. It will simply check whether the quotation marks and brackets appear
in pairs

Signed-off-by: SimFG <bang.fu@zilliz.com>
2025-01-08 21:14:57 +08:00
wei liu 5a4bafccc6
enhance: Add resource group api on Restful (#38885)
issue: #38739
enable to manage resource group by Restful
- CreateResourceGroup
- DescribeResourceGroup
- UpdateResourceGroup
- ListResourceGroup
- DropResourceGroup
- TransferReplica

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-08 19:40:57 +08:00
congqixia a208170c1f
fix: Make runtime param accessor concurrent safe (#39050)
Related to #39049

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-08 17:08:57 +08:00
smellthemoon a89ac861da
fix: not add index name in alter index properties (#38979)
#38967

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
2025-01-08 15:02:55 +08:00
Gao f0dae81494
fix: set iterative filter hint to false when no expr specified (#39033)
issue: https://github.com/milvus-io/milvus/issues/39013

Signed-off-by: chasingegg <chao.gao@zilliz.com>
2025-01-08 12:56:56 +08:00
congqixia f076898761
fix: Return io error other than `NotExist` refreshing config (#38924)
Related to #38923

This PR:

- Check whether `os.Stat` config file error is io.ErrNotExist
- Panic when get config return error during Milvus initialization

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-08 12:00:56 +08:00
Zhen Ye 134952b6c5
enhance: refactor the streaming node log (#39052)
issue: #38399

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-08 11:30:56 +08:00
yanliang567 329795ba91
test: Add search with hints on different expressions (#39048)
issue: https://github.com/milvus-io/milvus/issues/38877

---------

Signed-off-by: yanliang567 <yanliang.qiao@zilliz.com>
2025-01-08 10:58:55 +08:00
wei liu 47e7ea241e
enhance: Add log for case which target not update as expected (#38944)
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
2025-01-07 17:45:03 +08:00
Zhen Ye c5a7000a92
enhance: move streaming coord from datacoord to rootcoord (#39007)
issue: #38399

We want to support broadcast operation for both streaming and msgstream.
But msgstream can be only sent message from rootcoord and proxy.
So this pr move the streamingcoord to rootcoord to make easier
implementation.

---------

Signed-off-by: chyezh <chyezh@outlook.com>
2025-01-07 17:42:57 +08:00
Ted Xu 3dc95153b7
fix: build break under debug mode (#38790)
See #38435

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
2025-01-07 17:36:56 +08:00
congqixia 182cac03e5
enhance: Use bitset or instead of bitwise set (#39037)
Related to #39003

Copying bitset value bit by bit is slow and CPU heavy, this PR utilizes
bitset operator "|=" to accelerate this procedure

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-01-07 15:02:56 +08:00