milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
21,655 Commits
171 Branches
157 Tags
614 MiB
Commit Graph

147 Commits (hotfix-2.5.4)

Author SHA1 Message Date
congqixia a3cb8e2625
fix: Add atomic method to get collection target (#29577) 
Related to #29575

Add `getCollectionTarget` method which is atomic when scope is
`CurrentTargetFirst` or `NextTargetFirst`
Also return error when executor finds no channel in target manager

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-12-29 09:04:46 +08:00
wei liu 514e279f3a
enhance: Remove useless log in collection observer (#29554) 
This PR removed the useless log in collection observer

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-12-28 17:16:47 +08:00
yah01 13beb5ccc0
fix: load gets stuck probably (#29191) 
we found the load got stuck probably, and reviewed the logs.

the target observer seems not working, the reason is the taskDispatcher
removes the task in a goroutine, and modifies the task status after
committing the task into the goroutine pool, but this may happen after
the task removed, which leads to the task will never be removed

related #29086

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-12-14 18:28:38 +08:00
yah01 9819090247
enhance: add more logs for target updating (#29090) 
- add more logs about the condition satisfying

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-12-12 14:06:43 +08:00
yah01 fab52d167b
fix: may miss stream delta while loading (#28871) 
we consume the delta data from the lastest channel checkpoint while
loading segment,

this works well without level 0 segments, but now it may lead to miss
some delta data,

so we have to consume from the current target's channel checkpoint

related: #27349

---------

Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-12-05 17:34:45 +08:00
aoiasd b4af6f8c40
fix: sync action load segment with lack collection index info list (#28788) 
relate: https://github.com/milvus-io/milvus/issues/28779
https://github.com/milvus-io/milvus/issues/28637

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-12-04 18:14:34 +08:00
wei liu d081fd5481
enhance: Change some frequency log to rated level (#28897) 
This pr change some frequency log's level to rated.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-12-04 10:38:35 +08:00
congqixia f9bb8e9648
enhance: Change const magic number in querycoord to param (#28819) 
See also #28817

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-11-30 09:06:28 +08:00
congqixia 81caf02554
fix: make qcv2 observer dispatcher execute exactly once (#28472) 
See also #28466

In `taskDispatcher.schedule`, same task may be resubmitted if the
previous round did not finish
In this case, TaskObserver.check may set current target by mistake,
which may cause the random search/query failure

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-11-16 10:24:19 +08:00
yah01 ecb3f585c3
Fix passing the wrong dropped list from current target (#28265) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-11-08 17:02:18 +08:00
yah01 1b90630633
Fix the target updated before version updated to cause data missing (#28250) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-11-08 11:36:22 +08:00
wei liu 7485eeb689
fix sync distribution with wrong version (#28130) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-11-03 19:02:18 +08:00
yah01 dc89730a50
Support collection-level mmap control (#26901) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-11-02 23:52:16 +08:00
wei liu e0222b2ce3
refine target manager code style (#27883) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-10-25 00:44:12 +08:00
congqixia 323fc107a7
Fix taskDispatcher add multiple tasks will ignore following ones (#27885) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-10-24 17:18:13 +08:00
congqixia 93a877f55e
Make qcv2 target&leader observer execute in parallel (#27844) 
- Add `taskDispatcher` to submit and run task async safely
- Change `LeaderObeserver` and `TargetObserver` schedule and manual check action to submitting task into dispatcher
- Fix logic problem in collection observer when manual check return false

See also #27494

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-10-24 10:14:11 +08:00
wei liu 55e5f80e24
update collection target after observer start (#27774) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-10-19 21:52:10 +08:00
yah01 be980fbc38
Refine state check (#27541) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-10-11 21:01:35 +08:00
wei liu 42c475a0e0
remove useless log in querycoord (#27362) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-10-11 10:13:34 +08:00
congqixia eca79d149c
Add ctx control for observer manual check methods (#27531) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-10-09 11:07:33 +08:00
yah01 a715165306
Set timeout for leader observer syncing (#27504) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-10-08 16:55:31 +08:00
yah01 a8ce1b6686
Refine QueryCoord stopping (#27371) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-27 16:27:27 +08:00
SimFG 26f06dd732
Format the code (#27275) 
Signed-off-by: SimFG <bang.fu@zilliz.com>
 2023-09-21 09:45:27 +08:00
yah01 b4f86ea55e
Construct all success status with merr (#27226) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-20 10:57:23 +08:00
Enwei Jiao fb0705df1b
Decouple basetable and componentparam (#26725) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-09-05 10:31:48 +08:00
yah01 941a383019
Fix failed to load collection with more than 128 partitions (#26763) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-09-02 00:09:01 +08:00
wei liu 949c320185
remove pull target from qc recover (#26775) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-09-01 11:17:01 +08:00
Enwei Jiao 7d61355ab0
Refactor log for Query (#26310) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-08-14 18:57:32 +08:00
wei liu b47a72bfcf
fix set dirty segment distribution to leader view (#26180) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-11 11:21:32 +08:00
Bingyi Sun 54c0e64059
Fix search on empty segments set bug (#26136) 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
 2023-08-08 11:17:08 +08:00
wei liu 6f89620a43
remove pull target rpc from lock (#26054) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-04 10:31:06 +08:00
wei liu 518b6310a2
refine retry times on replica (#26043) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-08-03 15:55:09 +08:00
Bingyi Sun a3e22786ed
Move meta store to kv catalog (#25915) 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
 2023-07-31 13:57:04 +08:00
congqixia 0bc03ede0d
Add eventlog pkg and support grpc streaming event observation (#25812) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-25 17:23:01 +08:00
wei liu fc19b85a40
fix count(*）retrieve redundant growing segment (#25825) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-24 14:09:00 +08:00
wei liu b62c82af22
fix set target version in loading sealed segment (#25603) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-14 20:00:31 +08:00
congqixia 2bed5bc461
Fix false load success for partition load timeout but collection remains (#25379) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-07-06 19:10:25 +08:00
wei liu 2ae6def394
fix sync target version with wrong segment list (#25337) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-07-06 10:30:26 +08:00
wei liu 68ae199a9f
load segment with target version, avoid read redundant segment (#24929) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-06-27 11:48:45 +08:00
yiwangdr 4387f36897
make etcdKV private (#24778) 
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
 2023-06-13 10:52:38 +08:00
congqixia 41af0a98fa
Use go-api/v2 for milvus-proto (#24770) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-06-09 01:28:37 +08:00
yah01 848ef7418b
Fix the refresh may be notified finished early (#24438) 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
 2023-05-26 18:43:26 +08:00
yihao.dai 7e0d1492c7
Load delete from channel checkpoint (#23961) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2023-05-09 19:10:41 +08:00
congqixia ed81eaa963
Make CollectionObserver trigger checker more frequently during load procedure (#23928) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-05-08 14:06:41 +08:00
wei liu cbfe7a45ef
fix pull target (#23491) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-04-18 18:30:32 +08:00
congqixia b5a73e6d1a
Add OWNERS files for querycoordv2 sub pkgs (#23489) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-04-18 15:52:30 +08:00
yah01 296380d6e6
Support async refresh (#23107) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-04-12 15:06:28 +08:00
MrPresent-Han ba02e70301
fix bug when syncing distribution without schema and remove unused logic(#23085) (#23216) 
Signed-off-by: MrPresent-Han <jamesharden11122@gmail.com>
 2023-04-07 19:32:29 +08:00
jaime c9d0c157ec
Move some modules from internal to public package (#22572) 
Signed-off-by: jaime <yun.zhang@zilliz.com>
 2023-04-06 19:14:32 +08:00
congqixia 127867b873
Add ratedgroup for some info/warning log (#23095) 
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
 2023-03-31 15:22:23 +08:00
wei liu 74da53c027
fix update load percentage (#23054) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-03-30 10:48:23 +08:00
wei liu e2096965c7
fix leader view (#23038) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-03-29 14:06:02 +08:00
yah01 081572d31c
Refactor QueryNode (#21625) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>
Co-authored-by: aoiasd <zhicheng.yue@zilliz.com>
 2023-03-27 00:42:00 +08:00
yah01 2b81933d13
Refine logs of DistHandler (#22879) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-03-21 18:11:57 +08:00
yihao.dai 1f718118e9
Dynamic load/release partitions (#22655) 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
 2023-03-20 14:55:57 +08:00
wei liu 11f1f4226a
support replica observer assign node (#22604) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-03-08 18:57:51 +08:00
Enwei Jiao 697dedac7e
Use cockroachdb/errors to replace other error pkg (#22390) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2023-02-26 11:31:49 +08:00
zhenshan.cao e768437681
Correct usage of Timer and Ticker (#22228) 
Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
 2023-02-23 18:59:45 +08:00
wei liu a9a263d5a8
fix assign node to replica in nodeUp (#22323) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-02-23 14:15:45 +08:00
Bingyi Sun 4005508880
Fix load collection blocks when memory is limited. (#21990) 
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
 2023-02-06 16:07:53 +08:00
wei liu 73c44d4b29
resource group impl (#21609) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2023-01-30 10:19:48 +08:00
Bingyi Sun b0b0929c6c
Change CreateAt to UpdatedAt when checking timeout (#21769) 
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
 2023-01-18 17:29:43 +08:00
Ten Thousand Leaves defb7660c8
Add refresh option for LoadCollection/LoadPartitions interfaces (#21776) 
/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
 2023-01-18 16:41:44 +08:00
Bingyi Sun b91bb5a729
Fix load timeout after next target updates (#21759) 
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
 2023-01-17 15:15:46 +08:00
yah01 c8f89907b6
Fix current target may be updated to an invalid target (#21742) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-01-17 11:41:51 +08:00
yah01 837e3162d7
Fix ready notifiers leak when collection released (#21712) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-01-14 21:55:41 +08:00
yah01 32fb409e57
Fix may update the current target to an unavailable target when node down (#21698) 
Signed-off-by: yah01 <yang.cen@zilliz.com>
 2023-01-13 17:11:41 +08:00
smellthemoon b04eb17088
Fix load timeout (#21156) 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
 2022-12-12 18:43:23 +08:00
yah01 5ba1a94858
Fix observers may update current target to a unfinished next target (#21107) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-12-12 15:15:22 +08:00
Bingyi Sun 27219ce9c0
Fix load progress bug (#21069) 
issue: #21023

Signed-off-by: sunby <bingyi.sun@zilliz.com>

Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
 2022-12-08 18:41:20 +08:00
Enwei Jiao 89b810a4db
Refactor all params into ParamItem (#20987) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2022-12-07 18:01:19 +08:00
yah01 0297ab1a46
Make progress if any channel/segment was loaded on node (#20775) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-12-06 18:29:19 +08:00
smellthemoon c49f20ea94
Load should base on the accurate loaded number (#20999) 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
 2022-12-06 17:13:18 +08:00
Enwei Jiao 2ecdb4ba4a
Etcd config source support TLS (#20874) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2022-11-30 18:23:15 +08:00
MrPresent-Han b021d7c59c
[skip e2e] add log for querynode load and remove segment(#20510) (#20810) 
issue: #20510

Signed-off-by: MrPresent-Han <jamesharden11122@gmail.com>

Signed-off-by: MrPresent-Han <jamesharden11122@gmail.com>
 2022-11-25 17:33:13 +08:00
Enwei Jiao c05b9ad539
Add event dispatcher for config (#20393) 
Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>

Signed-off-by: Enwei Jiao <enwei.jiao@zilliz.com>
 2022-11-17 18:59:09 +08:00
yah01 d37ebe538b
Record load latency for loaded collection (#20538) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-11-15 10:11:07 +08:00
wei liu eaa5cfdcb5
fix leader observer sync logic (#20478) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2022-11-11 11:43:06 +08:00
wei liu c5cd92d36e
update target (#19296) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2022-11-07 19:37:04 +08:00
wei liu d7ebb25701
skip handoff event on unloaded partition (#20306) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2022-11-07 17:05:06 +08:00
wei liu 9293524de4
remove outdated handoff event (#20181) 
Signed-off-by: wei.liu <wei.liu@zilliz.com>

Signed-off-by: wei.liu <wei.liu@zilliz.com>
 2022-10-31 19:11:40 +08:00
jaime 976e9940bf
Add some logs for handoff observer (#20097) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-10-26 19:37:31 +08:00
jaime d8ca56e084
Fix empty segment handoff fails (#20073) 
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
 2022-10-26 16:49:31 +08:00
Xiaofan 3d316fc052
Fix Query Log Level (#19995) 
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
 2022-10-25 19:29:36 +08:00
smellthemoon 581e1d8c35
Fill MsgBase ALL (#19912) 
Signed-off-by: lixinguo <xinguo.li@zilliz.com>

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
Co-authored-by: lixinguo <xinguo.li@zilliz.com>
 2022-10-21 15:57:28 +08:00
yah01 470e8ef419
Store index ID to filter out invalid handoff event (#19703) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-10-20 11:29:27 +08:00
wei liu 87248dc1a9
fix clean handoff event (#19903) 
Signed-off-by: Wei Liu <wei.liu@zilliz.com>

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
 2022-10-19 20:41:26 +08:00
yah01 c61a4d1243
Fix panic due to double stop (#19849) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-10-19 12:13:28 +08:00
SimFG a55f739608
Separate public proto files (#19782) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-10-16 20:49:27 +08:00
yah01 1c71844b8d
Add license header (#19678) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-10-11 11:39:22 +08:00
yah01 e6c7286bee
Remove task timeout (#19583) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-09-30 19:48:55 +08:00
yah01 377f856833
Fix balance may confuse leader observer (#19435) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-09-28 12:10:54 +08:00
yah01 6ba52366c5
Fix load segments can't be retried (#19414) 
Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-09-26 10:54:52 +08:00
yah01 2cfacbba8d
Fix leader observer confused with replicas (#19392) 
With 2 replicas, the same segment was loaded on 2 nodes in different
replicas, leader observer will sync the latest one (by version) to the
other one.

Signed-off-by: yah01 <yang.cen@zilliz.com>

Signed-off-by: yah01 <yang.cen@zilliz.com>
 2022-09-23 15:16:51 +08:00
cai.zhang fc3309b8b8
All indexes segments both write handoff (#19230) 
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
 2022-09-21 16:34:51 +08:00
SimFG d7f38a803d
Separate some proto files (#19218) 
Signed-off-by: SimFG <bang.fu@zilliz.com>

Signed-off-by: SimFG <bang.fu@zilliz.com>
 2022-09-16 16:56:49 +08:00
Bingyi Sun 626854cf0c
Refactor QueryCoord (#18836) 
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>
 2022-09-15 18:48:32 +08:00