Commit Graph

72 Commits (2.6)

Author SHA1 Message Date
congqixia 672a83f66b
enhance: Skip remove op if key in save set (#43425)
Related to #43407

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-07-18 17:37:39 +08:00
congqixia 8fc7069e1a
fix: Make MultiSaveAndRemove execute removal first (#43408)
Realted to #43407

When `MultiSaveAndRemove` like ops contains same key in saves and
removal keys it may cause data lost if the execution order is save first
than removal.

This PR make all the kv execute removal first then save the new values.
Even when same key appeared in both saves and removals, the new value
shall stay.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-07-18 15:41:40 +08:00
congqixia cb7f2fa6fd
enhance: Use v2 package name for pkg module (#39990)
Related to #39095

https://go.dev/doc/modules/version-numbers

Update pkg version according to golang dep version convention

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2025-02-22 23:15:58 +08:00
tinswzy 27229f7907
enhance: refine exists log print with ctx (#38080)
issue: #35917 
Refines exists log print with ctx

Signed-off-by: tinswzy <zhenyuan.wei@zilliz.com>
2024-12-14 22:36:44 +08:00
SimFG e4a9a473ee
enhance: keep the latest snapshot key if the origin key is existed (#38333)
/kind improvement

Signed-off-by: SimFG <bang.fu@zilliz.com>
2024-12-11 10:36:43 +08:00
tinswzy 7944538ade
enhance: Add ctx param to KV operation interfaces (#38154)
issue: #35917 
Refine KV operation interfaces by adding a ctx param

Signed-off-by: tinswzy <zhenyuan.wei@zilliz.com>
2024-12-05 15:16:41 +08:00
jaime 9630974fbb
enhance: move rocksmq from internal to pkg module (#33881)
issue: #33956

Signed-off-by: jaime <yun.zhang@zilliz.com>
2024-06-25 21:18:15 +08:00
gcmutator 6edd06083f
chore: remove repetitive words (#31153)
Signed-off-by: gcmutator <329964069@qq.com>
2024-03-20 10:17:07 +08:00
congqixia a2fe9dad49
enhance: Make etcd kv request timeout configurable (#28661)
See also #28660
This pr add request timeout config item for etcd kv request timeout
 Sync the default timeout value to same value for etcdKV & tikv config

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-11-23 19:34:23 +08:00
Xiaofan 38aa53f523
Fix datacoord start timeout (#28026)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2023-10-31 10:04:12 +08:00
yah01 15746b5b5f
Refine KV errors (#27588)
Signed-off-by: yah01 <yah2er0ne@outlook.com>
2023-10-13 17:15:34 +08:00
congqixia a3dd2756cf
Add predicates for TxnKV operations (#27365)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2023-09-27 10:21:26 +08:00
yiwangdr f85af0732c
remove MultiRemoveWithPrefix (#26924)
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-09-12 15:07:17 +08:00
Bingyi Sun 6539396bbe
Add HasPrefix in kv (#25462)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
2023-07-11 10:28:28 +08:00
Bingyi Sun f75201bbfd
Add Has interface in kv (#25439)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
2023-07-10 19:40:27 +08:00
xige-16 33c2012675
Add more metrics (#25081)
Signed-off-by: xige-16 <xi.ge@zilliz.com>
2023-06-26 17:52:44 +08:00
yiwangdr c7b851f870
add interface for non-watch metakv (#25092)
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-06-26 09:20:44 +08:00
yiwangdr 4387f36897
make etcdKV private (#24778)
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-06-13 10:52:38 +08:00
yiwangdr 37c02c9927
clean up meta interface (#24729)
Signed-off-by: yiwangdr <yiwangdr@gmail.com>
2023-06-08 14:18:35 +08:00
jaime c9d0c157ec
Move some modules from internal to public package (#22572)
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-04-06 19:14:32 +08:00
wayblink 88293b8b79
Add log to analysis when etcd txn operation failed (#21558)
Signed-off-by: wayblink <anyang.wang@zilliz.com>
2023-02-02 15:57:51 +08:00
jaime 58b79eb74c
Add based on timetravel GC for snapshot KV (#21417)
Signed-off-by: jaime <yun.zhang@zilliz.com>
2023-01-04 21:37:35 +08:00
Bingyi Sun 626854cf0c
Refactor QueryCoord (#18836)
Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: sunby <bingyi.sun@zilliz.com>
Co-authored-by: yah01 <yang.cen@zilliz.com>
Co-authored-by: Wei Liu <wei.liu@zilliz.com>
Co-authored-by: Congqi Xia <congqi.xia@zilliz.com>
2022-09-15 18:48:32 +08:00
jaime 816967c000
Add metrics for etcd (#18962)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-09-02 17:46:59 +08:00
jaime 237d912625
Add log for the large value during etcd saving (#18229)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Signed-off-by: yun.zhang <yun.zhang@zilliz.com>
2022-09-01 09:47:02 +08:00
SimFG 1366f130a2
Add a specific `KeyNotExistError` err for the metastore `load` interface (#18582)
Signed-off-by: SimFG <bang.fu@zilliz.com>
2022-08-10 17:20:41 +08:00
Ten Thousand Leaves 097f144db1
Improve slow Etcd logs by specifying keys (#18547)
/kind improvement

Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-08-09 21:14:37 +08:00
Xiaofan a9b1d71a8f
change the etcd compareAndSwap interface (#18068)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2022-07-06 13:54:21 +08:00
cai.zhang ef0fc37ad7
Fixed the bug that IndexCoord lost some meta information (#17818)
Signed-off-by: Cai.Zhang <cai.zhang@zilliz.com>
2022-06-27 21:52:17 +08:00
Ten Thousand Leaves a23ca745bb
Add Etcd support for Import Tasks. (#16164)
issue: #15604
Signed-off-by: Yuchen Gao <yuchen.gao@zilliz.com>
2022-03-25 11:03:25 +08:00
congqixia a5c3f4eef4
Add CompareFailErr for CAS operation error check (#15893)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2022-03-07 18:01:58 +08:00
Letian Jiang b56ec7ea97
Add ByteSlice Method for Etcd-kv (#15738)
Signed-off-by: Letian Jiang <letian.jiang@zilliz.com>
2022-02-25 11:25:53 +08:00
Xiaofan 69087ff8dd
Support embedded etcd (#14333)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-12-29 14:35:21 +08:00
cxytz01 e47a651be4
[skip e2e] Grammar correction (#14057)
Signed-off-by: cxytz01 <xueyou.chen@zilliz.com>
2021-12-23 14:41:52 +08:00
jaime 0a99e1aeba
[skip ci] Fix go format error (#13212)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Co-authored-by: yun.zhang <yun.zhang@zilliz.com>
2021-12-11 22:23:13 +08:00
jaime ea7d8be913
[skip ci] Refine error message (#11728)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Co-authored-by: yun.zhang <yun.zhang@zilliz.com>
2021-12-10 16:50:52 +08:00
jaime efaca29ee4
[skip ci] fix a grammar error of the comment in etcd_kv (#13019)
Signed-off-by: yun.zhang <yun.zhang@zilliz.com>

Co-authored-by: yun.zhang <yun.zhang@zilliz.com>
2021-12-09 09:23:08 +08:00
edward.zeng d3c23ca5e9
[skip ci] Refine etcd kv comment (#12872)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-12-07 15:55:03 +08:00
shaoyue bbdd1dbef9
[skip ci] Add comment for etcd_kv.go (#12449)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-11-30 16:58:14 +08:00
edward.zeng c9d31f0b73
[skip ci] Refine etcd kv comment (#12374)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-11-29 19:25:49 +08:00
edward.zeng a92a6f34b4
[skip ci] Fix typo in etcd kv comment (#12091)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-11-18 19:25:19 +08:00
edward.zeng 77264ae493
[skip ci] Refine etcd kv comment (#12090)
Signed-off-by: Edward Zeng <jie.zeng@zilliz.com>
2021-11-18 19:23:25 +08:00
shaoyue 585d9be439
[skip ci] Add comments for exported funcs in etcd_kv.go (#11975)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-11-17 16:09:23 +08:00
shaoyue 6542b092b2
[skip ci] Add comments of exported items in etcd_kv.go (#11884)
Signed-off-by: shaoyue.chen <shaoyue.chen@zilliz.com>
2021-11-16 17:41:11 +08:00
XuanYang-cn 005d177f68
[skip ci]Update license for kv etcdkv (#10894)
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-10-29 13:11:24 +08:00
congqixia ed2b8d67c0
Reduce info saved in SnapshotMeta (#10288)
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
2021-10-21 14:04:36 +08:00
Xiaofan 2f92f78e7b
Remove meaningless Etcd kv logs (#8019)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-09-22 20:27:54 +08:00
Xiaofan 58b2089692
Import Embedded Etcd Kv Part 1(#7112) (#7174)
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
2021-08-24 09:45:51 +08:00
XuanYang-cn 6c5be83ea1
Refactor NewEtcdKV API (#7075)
This PR mainly did the following 3 things:

- Refactor NewEtcdKV API
- Add unittests for `kv/etcd/`, raise the coverage
up to 94%
- Correct some APIs from version to revision

The old NewEtcdKV() API took `clientv3.Client` as
one of the input, making everyone who using this API
had to create a new `clientv3.Client`. So there're a lot
of repeated codes everywhere.

Meanwhile, someplace didn't even check whether the
`clientv3.New()` returned error or not, and the old API
also didn't check whether the clientv3.Client was Nil.
This caused issue#6955.

Ectd's version and revision have nothing alike, they
represent different concepts, but our APIs kind of
mixed them all up. So I correct those APIs' names.

Resolves: #6955

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
2021-08-13 11:04:09 +08:00
cai.zhang a3c662c7bf
Add watchWithVersion interface for etcdKV (#6663)
* Add watchWithVersion interface for etcdKV

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Add unittest

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>

* Add LoadWithVersion interface

Signed-off-by: xiaocai2333 <cai.zhang@zilliz.com>
2021-07-21 18:20:11 +08:00