diff --git a/internal/util/mqclient/pulsar_consumer.go b/internal/util/mqclient/pulsar_consumer.go index f29430814c..6cd61a82ae 100644 --- a/internal/util/mqclient/pulsar_consumer.go +++ b/internal/util/mqclient/pulsar_consumer.go @@ -12,7 +12,8 @@ package mqclient import ( - "time" + "reflect" + "unsafe" "github.com/apache/pulsar-client-go/pulsar" "github.com/milvus-io/milvus/internal/log" @@ -32,8 +33,18 @@ func (pc *pulsarConsumer) Subscription() string { func (pc *pulsarConsumer) Chan() <-chan ConsumerMessage { if pc.msgChannel == nil { pc.msgChannel = make(chan ConsumerMessage) + // this part handles msgstream expectation when the consumer is not seeked + // pulsar's default behavior is setting postition to the earliest pointer when client of the same subscription pointer is not acked + // yet, our message stream is to setting to the very start point of the topic if !pc.hasSeek { - pc.c.SeekByTime(time.Unix(0, 0)) + // the concrete value of the MessageID is pulsar.messageID{-1,-1,-1,-1} + // but Seek function logic does not allow partitionID -1, See line 618-620 of github.com/apache/pulsar-client-go@v0.5.0 pulsar/consumer_impl.go + mid := pulsar.EarliestMessageID() + // the patch function use unsafe pointer to set partitionIdx to 0, which is the valid default partition index of current use case + // NOTE: when pulsar client version check, do check this logic is fixed or offset is changed!!! + // NOTE: unsafe solution, check implementation asap + patchEarliestMessageID(&mid) + pc.c.Seek(mid) } go func() { for { //nolint:gosimple @@ -72,3 +83,38 @@ func (pc *pulsarConsumer) Close() { pc.c.Close() close(pc.closeCh) } + +// patchEarliestMessageID unsafe patch logic to change messageID partitionIdx to 0 +// ONLY used in Chan() function +// DON'T use elsewhere +func patchEarliestMessageID(mid *pulsar.MessageID) { + v := reflect.ValueOf(mid) + v = v.Elem() + // cannot use field.SetInt(), since partitionIdx is not exported + + // this reflect+ unsafe solution is disable by go vet + + //ifData := v.InterfaceData() // unwrap interface + //ifData[1] is the pointer to the exact struct + // 20 is the offset of paritionIdx of messageID + //lint:ignore unsafeptr: possible misuse of unsafe.Pointer (govet), hardcoded offset + //*(*int32)(unsafe.Pointer(v.InterfaceData()[1] + 20)) = 0 + + // use direct unsafe conversion + r := (*iface)(unsafe.Pointer(mid)) + id := (*messageID)(r.Data) + id.partitionIdx = 0 +} + +// unsafe access pointer, same as pulsar.messageID +type messageID struct { + ledgerID int64 + entryID int64 + batchID int32 + partitionIdx int32 +} + +// interface struct mapping +type iface struct { + Type, Data unsafe.Pointer +} diff --git a/internal/util/mqclient/pulsar_consumer_test.go b/internal/util/mqclient/pulsar_consumer_test.go new file mode 100644 index 0000000000..8a9bb54cf1 --- /dev/null +++ b/internal/util/mqclient/pulsar_consumer_test.go @@ -0,0 +1,31 @@ +// Copyright (C) 2019-2020 Zilliz. All rights reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software distributed under the License +// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express +// or implied. See the License for the specific language governing permissions and limitations under the License. + +package mqclient + +import ( + "fmt" + "testing" + + "github.com/apache/pulsar-client-go/pulsar" + "github.com/stretchr/testify/assert" +) + +func TestPatchEarliestMessageID(t *testing.T) { + mid := pulsar.EarliestMessageID() + + // String() -> ledgerID:entryID:partitionIdx + assert.Equal(t, "-1:-1:-1", fmt.Sprintf("%v", mid)) + + patchEarliestMessageID(&mid) + + assert.Equal(t, "-1:-1:0", fmt.Sprintf("%v", mid)) +}