milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Time Tick Failed need log (#15225) 

Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com>
pull/15227/head
Xiaofan 2022-01-14 23:55:34 +08:00 committed by GitHub
parent 1601a61b78
commit f617c8887b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 27 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/indexcoord/meta_table.go
View File

@ -382,8 +382,6 @@ func (mt *metaTable) UpdateRecycleState(indexBuildID UniqueID) error {
func (mt *metaTable) GetUnusedIndexFiles(limit int) []Meta {
mt.lock.Lock()
defer mt.lock.Unlock()
log.Debug("IndexCoord get the meta which need to recycle")
var metas []Meta
for _, meta := range mt.indexBuildID2Meta {
if meta.indexMeta.State == commonpb.IndexState_Finished && (meta.indexMeta.MarkDeleted || !meta.indexMeta.Recycled) {

13
internal/querynode/impl.go
View File

@ -572,12 +572,13 @@ func (node *QueryNode) GetMetrics(ctx context.Context, req *milvuspb.GetMetricsR
if metricType == metricsinfo.SystemInfoMetrics {
metrics, err := getSystemInfoMetrics(ctx, req, node)
log.Debug("QueryNode.GetMetrics",
zap.Int64("node_id", Params.QueryNodeCfg.QueryNodeID),
zap.String("req", req.Request),
zap.String("metric_type", metricType),
zap.Error(err))
if err != nil {
log.Warn("QueryNode.GetMetrics failed",
zap.Int64("node_id", Params.QueryNodeCfg.QueryNodeID),
zap.String("req", req.Request),
zap.String("metric_type", metricType),
zap.Error(err))
}
return metrics, nil
}

5
internal/rootcoord/root_coord.go
View File

@ -281,7 +281,10 @@ func (c *Core) startTimeTickLoop() {
case <-ticker.C:
c.ddlLock.Lock()
if ts, err := c.TSOAllocator(1); err == nil {
c.SendTimeTick(ts, "timetick loop")
err := c.SendTimeTick(ts, "timetick loop")
if err != nil {
log.Warn("Failed to send timetick", zap.Error(err))
}
}
c.ddlLock.Unlock()
}

21
internal/rootcoord/task.go
View File

@ -238,7 +238,10 @@ func (t *CreateCollectionReqTask) Execute(ctx context.Context) error {
// use addDdlTimeTick and removeDdlTimeTick to mark DDL operation in process
t.core.chanTimeTick.removeDdlTimeTick(ts, reason)
t.core.SendTimeTick(ts, reason)
errTimeTick := t.core.SendTimeTick(ts, reason)
if errTimeTick != nil {
log.Warn("Failed to send timetick", zap.Error(errTimeTick))
}
return nil
}
@ -330,8 +333,10 @@ func (t *DropCollectionReqTask) Execute(ctx context.Context) error {
// use addDdlTimeTick and removeDdlTimeTick to mark DDL operation in process
t.core.chanTimeTick.removeDdlTimeTick(ts, reason)
t.core.SendTimeTick(ts, reason)
errTimeTick := t.core.SendTimeTick(ts, reason)
if errTimeTick != nil {
log.Warn("Failed to send timetick", zap.Error(errTimeTick))
}
// send tt into deleted channels to tell data_node to clear flowgragh
t.core.chanTimeTick.sendTimeTickToChannel(collMeta.PhysicalChannelNames, ts)
@ -543,7 +548,10 @@ func (t *CreatePartitionReqTask) Execute(ctx context.Context) error {
// use addDdlTimeTick and removeDdlTimeTick to mark DDL operation in process
t.core.chanTimeTick.removeDdlTimeTick(ts, reason)
t.core.SendTimeTick(ts, reason)
errTimeTick := t.core.SendTimeTick(ts, reason)
if errTimeTick != nil {
log.Warn("Failed to send timetick", zap.Error(errTimeTick))
}
return nil
}
@ -627,7 +635,10 @@ func (t *DropPartitionReqTask) Execute(ctx context.Context) error {
// use addDdlTimeTick and removeDdlTimeTick to mark DDL operation in process
t.core.chanTimeTick.removeDdlTimeTick(ts, reason)
t.core.SendTimeTick(ts, reason)
errTimeTick := t.core.SendTimeTick(ts, reason)
if errTimeTick != nil {
log.Warn("Failed to send timetick", zap.Error(errTimeTick))
}
return nil
}