milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add data sync service close log for watch stuck debugging (#26332) 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/26347/head
congqixia 2023-08-16 10:57:32 +08:00 committed by GitHub
parent 78bc688d16
commit f371ec0316
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
internal/datanode/data_sync_service.go
View File

@ -160,18 +160,25 @@ func (dsService *dataSyncService) start() {
func (dsService *dataSyncService) close() {
dsService.stopOnce.Do(func() {
log := log.Ctx(context.Background()).With(
zap.Int64("collectionID", dsService.collectionID),
zap.String("vChanName", dsService.vchannelName),
)
if dsService.fg != nil {
log.Info("dataSyncService closing flowgraph", zap.Int64("collectionID", dsService.collectionID),
zap.String("vChanName", dsService.vchannelName))
log.Info("dataSyncService closing flowgraph")
dsService.dispClient.Deregister(dsService.vchannelName)
dsService.fg.Close()
log.Info("dataSyncService flowgraph closed")
}
dsService.clearGlobalFlushingCache()
close(dsService.flushCh)
dsService.flushManager.close()
log.Info("dataSyncService flush manager closed")
dsService.cancelFn()
dsService.channel.close()
log.Info("dataSyncService closed")
})
}

1
internal/datanode/flush_manager.go
View File

@ -656,6 +656,7 @@ func (m *rendezvousFlushManager) close() {
return true
})
m.waitForAllFlushQueue()
log.Ctx(context.Background()).Info("flush manager closed", zap.Int64("collectionID", m.Channel.getCollectionID()))
}
type flushBufferInsertTask struct {