milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix some memleak in rocksmq (#8405) 

Signed-off-by: fishpenguin <kun.yu@zilliz.com>
pull/8246/head
yukun 2021-09-23 17:21:54 +08:00 committed by GitHub
parent b47ff1f97f
commit f34e5205f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
internal/util/rocksmq/server/rocksmq/rocksmq_impl.go
View File

@ -402,6 +402,7 @@ func (rmq *rocksmq) Produce(topicName string, messages []ProducerMessage) error
/* Step I: Insert data to store system */
batch := gorocksdb.NewWriteBatch()
defer batch.Destroy()
msgSizes := make(map[UniqueID]int64)
msgIDs := make([]UniqueID, msgLen)
for i := 0; i < msgLen && idStart+UniqueID(i) < idEnd; i++ {
@ -416,8 +417,9 @@ func (rmq *rocksmq) Produce(topicName string, messages []ProducerMessage) error
msgSizes[msgID] = int64(len(messages[i].Payload))
}
err = rmq.store.Write(gorocksdb.NewDefaultWriteOptions(), batch)
batch.Destroy()
opts := gorocksdb.NewDefaultWriteOptions()
defer opts.Destroy()
err = rmq.store.Write(opts, batch)
if err != nil {
log.Debug("RocksMQ: write batch failed")
return err
@ -624,8 +626,9 @@ func (rmq *rocksmq) Seek(topicName string, groupName string, msgID UniqueID) err
return err
}
val, err := rmq.store.Get(gorocksdb.NewDefaultReadOptions(), []byte(storeKey))
defer val.Free()
opts := gorocksdb.NewDefaultReadOptions()
defer opts.Destroy()
_, err = rmq.store.Get(opts, []byte(storeKey))
if err != nil {
log.Debug("RocksMQ: get " + storeKey + " failed")
return err