milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix empty auth config unmarshal (#21473) 

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
pull/21486/head
wei liu 2023-01-03 10:11:34 +08:00 committed by GitHub
parent 289df1cc3d
commit e735485bb8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/util/paramtable/service_param.go
View File

@ -414,9 +414,6 @@ func (p *PulsarConfig) Init(base *BaseTable) {
}
}
if len(jsonMap) == 0 {
return ""
}
jsonData, _ := json.Marshal(&jsonMap)
return string(jsonData)
},

9
internal/util/paramtable/service_param_test.go
View File

@ -110,7 +110,14 @@ func TestServiceParam(t *testing.T) {
Params := SParams.PulsarCfg
assert.Equal(t, "", Params.AuthPlugin.GetValue())
assert.Equal(t, "", Params.AuthParams.GetValue())
assert.Equal(t, "{}", Params.AuthParams.GetValue())
})
t.Run("test pulsar auth config formatter", func(t *testing.T) {
Params := SParams.PulsarCfg
assert.Equal(t, "{}", Params.AuthParams.Formatter(""))
assert.Equal(t, "{\"a\":\"b\"}", Params.AuthParams.Formatter("a:b"))
})
t.Run("test pulsar tenant/namespace config", func(t *testing.T) {