Stop querynode for unit tests (#20665)

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

internal/querynode/impl_test.go

@@ -544,7 +544,8 @@ func TestImpl_ReleaseSegments(t *testing.T) {
 
 	t.Run("test valid", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		req := &queryPb.ReleaseSegmentsRequest{
 			Base:         genCommonMsgBase(commonpb.MsgType_ReleaseSegments, node.session.ServerID),
@@ -568,7 +569,8 @@ func TestImpl_ReleaseSegments(t *testing.T) {
 
 	t.Run("test invalid query node", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		req := &queryPb.ReleaseSegmentsRequest{
 			Base:         genCommonMsgBase(commonpb.MsgType_ReleaseSegments, node.session.ServerID),
@@ -585,7 +587,8 @@ func TestImpl_ReleaseSegments(t *testing.T) {
 
 	t.Run("test target not matched", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		req := &queryPb.ReleaseSegmentsRequest{
 			Base:         genCommonMsgBase(commonpb.MsgType_ReleaseSegments, -1),
@@ -601,7 +604,8 @@ func TestImpl_ReleaseSegments(t *testing.T) {
 
 	t.Run("test segment not exists", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		req := &queryPb.ReleaseSegmentsRequest{
 			Base:         genCommonMsgBase(commonpb.MsgType_ReleaseSegments, node.session.ServerID),
@@ -619,7 +623,8 @@ func TestImpl_ReleaseSegments(t *testing.T) {
 
 	t.Run("test no collection", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 		err = node.metaReplica.removeCollection(defaultCollectionID)
 		assert.NoError(t, err)
 
@@ -640,6 +645,7 @@ func TestImpl_Search(t *testing.T) {
 
 	node, err := genSimpleQueryNode(ctx)
 	require.NoError(t, err)
+	defer node.Stop()
 
 	schema := genTestCollectionSchema()
 	req, err := genSearchRequest(defaultNQ, IndexFaissIDMap, schema)
@@ -674,6 +680,7 @@ func TestImpl_searchWithDmlChannel(t *testing.T) {
 
 	node, err := genSimpleQueryNode(ctx)
 	require.NoError(t, err)
+	defer node.Stop()
 
 	schema := genTestCollectionSchema()
 	req, err := genSearchRequest(defaultNQ, IndexFaissIDMap, schema)
@@ -706,8 +713,8 @@ func TestImpl_GetCollectionStatistics(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	defer node.Stop()
 	require.NoError(t, err)
+	defer node.Stop()
 
 	req, err := genGetCollectionStatisticRequest()
 	require.NoError(t, err)
@@ -727,8 +734,8 @@ func TestImpl_GetPartitionStatistics(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	defer node.Stop()
 	require.NoError(t, err)
+	defer node.Stop()
 
 	req, err := genGetPartitionStatisticRequest()
 	require.NoError(t, err)
@@ -748,8 +755,8 @@ func TestImpl_Query(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	defer node.Stop()
 	require.NoError(t, err)
+	defer node.Stop()
 
 	schema := genTestCollectionSchema()
 	req, err := genRetrieveRequest(schema)
@@ -783,8 +790,8 @@ func TestImpl_queryWithDmlChannel(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	defer node.Stop()
 	require.NoError(t, err)
+	defer node.Stop()
 
 	schema := genTestCollectionSchema()
 	req, err := genRetrieveRequest(schema)
@@ -817,8 +824,8 @@ func TestImpl_SyncReplicaSegments(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		node.UpdateStateCode(commonpb.StateCode_Abnormal)
 
@@ -831,8 +838,8 @@ func TestImpl_SyncReplicaSegments(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		resp, err := node.SyncReplicaSegments(ctx, &querypb.SyncReplicaSegmentsRequest{
 			VchannelName: defaultDMLChannel,
@@ -854,8 +861,8 @@ func TestImpl_SyncReplicaSegments(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		node.ShardClusterService.addShardCluster(defaultCollectionID, defaultReplicaID, defaultDMLChannel, defaultVersion)
 		cs, ok := node.ShardClusterService.getShardCluster(defaultDMLChannel)
@@ -892,8 +899,8 @@ func TestSyncDistribution(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		node.UpdateStateCode(commonpb.StateCode_Abnormal)
 
@@ -906,8 +913,8 @@ func TestSyncDistribution(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		resp, err := node.SyncDistribution(ctx, &querypb.SyncDistributionRequest{
 			Base:         &commonpb.MsgBase{TargetID: -1},
@@ -931,8 +938,8 @@ func TestSyncDistribution(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		resp, err := node.SyncDistribution(ctx, &querypb.SyncDistributionRequest{
 			Base:         &commonpb.MsgBase{TargetID: node.session.ServerID},
@@ -956,8 +963,8 @@ func TestSyncDistribution(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		node.ShardClusterService.addShardCluster(defaultCollectionID, defaultReplicaID, defaultDMLChannel, defaultVersion)
 		cs, ok := node.ShardClusterService.getShardCluster(defaultDMLChannel)
@@ -1016,8 +1023,8 @@ func TestGetDataDistribution(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		node.UpdateStateCode(commonpb.StateCode_Abnormal)
 
@@ -1030,8 +1037,8 @@ func TestGetDataDistribution(t *testing.T) {
 		ctx, cancel := context.WithCancel(context.Background())
 		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
+		require.NoError(t, err)
 		defer node.Stop()
-		assert.NoError(t, err)
 
 		resp, err := node.GetDataDistribution(ctx, &querypb.GetDataDistributionRequest{
 			Base: &commonpb.MsgBase{TargetID: -1},

internal/querynode/load_segment_task_test.go

@@ -24,6 +24,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
 
 	"github.com/milvus-io/milvus-proto/go-api/commonpb"
 	"github.com/milvus-io/milvus-proto/go-api/schemapb"
@@ -80,7 +81,8 @@ func TestTask_loadSegmentsTask(t *testing.T) {
 
 	t.Run("test execute grpc", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		node.metaReplica.removeSegment(defaultSegmentID, segmentTypeSealed)
 
@@ -114,7 +116,8 @@ func TestTask_loadSegmentsTask(t *testing.T) {
 
 	t.Run("test repeated load", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		node.metaReplica.removeSegment(defaultSegmentID, segmentTypeSealed)
 
@@ -157,8 +160,11 @@ func TestTask_loadSegmentsTask(t *testing.T) {
 	})
 
 	t.Run("test FromDmlCPLoadDelete", func(t *testing.T) {
+		ctx, cancel := context.WithCancel(ctx)
+		defer cancel()
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		vDmChannel := "by-dev-rootcoord-dml_1_2021v1"
 		pDmChannel := funcutil.ToPhysicalChannel(vDmChannel)
@@ -270,7 +276,8 @@ func TestTask_loadSegmentsTask(t *testing.T) {
 
 	t.Run("test OOM", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		totalRAM := int64(hardware.GetMemoryCount())
 
@@ -313,7 +320,9 @@ func TestTask_loadSegmentsTask(t *testing.T) {
 
 	t.Run("test FromDmlCPLoadDelete failed", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		node.metaReplica.removeSegment(defaultSegmentID, segmentTypeSealed)
 
 		msgStream := &LoadDeleteMsgStream{}
@@ -366,7 +375,8 @@ func TestTask_loadSegmentsTaskLoadDelta(t *testing.T) {
 
 	t.Run("test repeated load delta channel", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 		vDmChannel := "by-dev-rootcoord-dml-test_2_2021v2"
 
 		segmentLoadInfo := &querypb.SegmentLoadInfo{

internal/querynode/metrics_info_test.go

@@ -21,6 +21,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 
 	"github.com/milvus-io/milvus-proto/go-api/commonpb"
 	"github.com/milvus-io/milvus-proto/go-api/milvuspb"
@@ -35,7 +36,8 @@ func TestGetSystemInfoMetrics(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
 
 	etcdCli, err := etcd.GetEtcdClient(&Params.EtcdCfg)
 	assert.NoError(t, err)
@@ -62,7 +64,8 @@ func TestGetComponentConfigurationsFailed(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
 
 	etcdCli, err := etcd.GetEtcdClient(&Params.EtcdCfg)
 	assert.NoError(t, err)

internal/querynode/query_node_test.go

@@ -22,11 +22,11 @@ import (
 	"net/url"
 	"os"
 	"runtime"
-	"sync"
 	"testing"
 	"time"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	"go.etcd.io/etcd/server/v3/embed"
 
 	"github.com/milvus-io/milvus/internal/util/concurrency"
@@ -170,7 +170,8 @@ func TestQueryNode_register(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
 
 	etcdcli, err := etcd.GetEtcdClient(&Params.EtcdCfg)
 	assert.NoError(t, err)
@@ -189,7 +190,9 @@ func TestQueryNode_init(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
+
 	etcdcli, err := etcd.GetEtcdClient(&Params.EtcdCfg)
 	assert.NoError(t, err)
 	defer etcdcli.Close()
@@ -222,20 +225,16 @@ func TestQueryNode_adjustByChangeInfo(t *testing.T) {
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 
-	var wg sync.WaitGroup
-	wg.Add(1)
 	t.Run("test cleanup segments", func(t *testing.T) {
-		defer wg.Done()
-		_, err := genSimpleQueryNodeToTestWatchChangeInfo(ctx)
-		assert.NoError(t, err)
-
+		node, err := genSimpleQueryNodeToTestWatchChangeInfo(ctx)
+		require.NoError(t, err)
+		defer node.Stop()
 	})
 
-	wg.Add(1)
 	t.Run("test cleanup segments no segment", func(t *testing.T) {
-		defer wg.Done()
 		node, err := genSimpleQueryNodeToTestWatchChangeInfo(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		node.metaReplica.removeSegment(defaultSegmentID, segmentTypeSealed)
 		segmentChangeInfos := genSimpleChangeInfo()
@@ -249,5 +248,4 @@ func TestQueryNode_adjustByChangeInfo(t *testing.T) {
 		*/
 
 	})
-	wg.Wait()
 }

internal/querynode/query_shard_service_test.go

@@ -27,6 +27,7 @@ import (
 func TestQueryShardService(t *testing.T) {
 	qn, err := genSimpleQueryNode(context.Background())
 	require.NoError(t, err)
+	defer qn.Stop()
 
 	qss, err := newQueryShardService(context.Background(), qn.metaReplica, qn.tSafeReplica, qn.ShardClusterService, qn.factory, qn.scheduler)
 	assert.NoError(t, err)
@@ -50,6 +51,7 @@ func TestQueryShardService(t *testing.T) {
 func TestQueryShardService_InvalidChunkManager(t *testing.T) {
 	qn, err := genSimpleQueryNode(context.Background())
 	require.NoError(t, err)
+	defer qn.Stop()
 
 	qss, err := newQueryShardService(context.Background(), qn.metaReplica, qn.tSafeReplica, qn.ShardClusterService, qn.factory, qn.scheduler)
 	assert.NoError(t, err)

internal/querynode/reduce_test.go

@@ -26,6 +26,7 @@ import (
 
 	"github.com/golang/protobuf/proto"
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 
 	"github.com/milvus-io/milvus-proto/go-api/commonpb"
 	"github.com/milvus-io/milvus/internal/common"
@@ -49,7 +50,8 @@ func TestReduce_AllFunc(t *testing.T) {
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
 
 	collection, err := node.metaReplica.getCollectionByID(defaultCollectionID)
 	assert.NoError(t, err)

internal/querynode/segment_loader_test.go

@@ -53,7 +53,8 @@ func TestSegmentLoader_loadSegment(t *testing.T) {
 
 	t.Run("test load segment", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		node.metaReplica.removeSegment(defaultSegmentID, segmentTypeSealed)
 		loader := node.loader
@@ -83,7 +84,8 @@ func TestSegmentLoader_loadSegment(t *testing.T) {
 
 	t.Run("test set segment error due to without partition", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		err = node.metaReplica.removePartition(defaultPartitionID)
 		assert.NoError(t, err)
@@ -114,7 +116,7 @@ func TestSegmentLoader_loadSegment(t *testing.T) {
 
 	t.Run("test load segment with nil base message", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
 
 		loader := node.loader
 		assert.NotNil(t, loader)
@@ -132,7 +134,9 @@ func TestSegmentLoader_loadSegmentFieldsData(t *testing.T) {
 
 	runLoadSegmentFieldData := func(dataType schemapb.DataType, pkType schemapb.DataType) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -226,7 +230,9 @@ func TestSegmentLoader_invalid(t *testing.T) {
 
 	t.Run("test no collection", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -254,7 +260,9 @@ func TestSegmentLoader_invalid(t *testing.T) {
 
 	t.Run("test no vec field 2", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -292,7 +300,8 @@ func TestSegmentLoader_invalid(t *testing.T) {
 
 	t.Run("Test Invalid SegmentType", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -317,7 +326,9 @@ func TestSegmentLoader_invalid(t *testing.T) {
 
 	t.Run("Test load file failed", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -359,9 +370,10 @@ func TestSegmentLoader_invalid(t *testing.T) {
 	})
 
 	t.Run("Test load index failed", func(t *testing.T) {
-
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -411,7 +423,9 @@ func TestSegmentLoader_checkSegmentSize(t *testing.T) {
 	defer cancel()
 
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
+
 	loader := node.loader
 	assert.NotNil(t, loader)
 
@@ -425,7 +439,9 @@ func TestSegmentLoader_testLoadGrowing(t *testing.T) {
 
 	t.Run("test load growing segments", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -454,7 +470,9 @@ func TestSegmentLoader_testLoadGrowing(t *testing.T) {
 
 	t.Run("test invalid insert data", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
+
 		loader := node.loader
 		assert.NotNil(t, loader)
 
@@ -495,7 +513,8 @@ func TestSegmentLoader_testLoadGrowingAndSealed(t *testing.T) {
 
 	t.Run("test load sealed segments", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		loader := node.loader
 		assert.NotNil(t, loader)
@@ -556,7 +575,8 @@ func TestSegmentLoader_testLoadGrowingAndSealed(t *testing.T) {
 
 	t.Run("test load growing segments", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		loader := node.loader
 		assert.NotNil(t, loader)
@@ -642,7 +662,9 @@ func TestSegmentLoader_testLoadSealedSegmentWithIndex(t *testing.T) {
 
 	// generate segmentLoader
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
+
 	loader := node.loader
 	assert.NotNil(t, loader)
 
@@ -763,7 +785,9 @@ func testSeekFailWhenConsumingDeltaMsg(ctx context.Context, t *testing.T, positi
 
 	factory := &mockMsgStreamFactory{mockMqStream: msgStream}
 	node, err := genSimpleQueryNodeWithMQFactory(ctx, factory)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
+
 	loader := node.loader
 	assert.NotNil(t, loader)
 
@@ -796,7 +820,8 @@ func testConsumingDeltaMsg(ctx context.Context, t *testing.T, position *msgstrea
 	msgStream.On("Chan").Return(msgChan)
 	factory := &mockMsgStreamFactory{mockMqStream: msgStream}
 	node, err := genSimpleQueryNodeWithMQFactory(ctx, factory)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
 
 	loader := node.loader
 	assert.NotNil(t, loader)

internal/querynode/segment_test.go

@@ -409,7 +409,8 @@ func TestSegment_segmentSearch(t *testing.T) {
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
 	node, err := genSimpleQueryNode(ctx)
-	assert.NoError(t, err)
+	require.NoError(t, err)
+	defer node.Stop()
 
 	collection, err := node.metaReplica.getCollectionByID(defaultCollectionID)
 	assert.NoError(t, err)

internal/querynode/shard_cluster_service_test.go

@@ -39,6 +39,7 @@ func TestShardClusterService(t *testing.T) {
 func TestShardClusterService_SyncReplicaSegments(t *testing.T) {
 	qn, err := genSimpleQueryNode(context.Background())
 	require.NoError(t, err)
+	defer qn.Stop()
 
 	client := v3client.New(embedetcdServer.Server)
 	defer client.Close()

internal/querynode/task_test.go

@@ -75,7 +75,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 
 	t.Run("test execute loadCollection", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -94,7 +95,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 
 	t.Run("test execute repeated watchDmChannelTask", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -118,7 +120,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 
 	t.Run("test execute loadPartition", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -141,7 +144,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 
 	t.Run("test execute loadPartition without init collection and partition", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -161,7 +165,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 
 	t.Run("test execute seek error", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -217,7 +222,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 	t.Run("test add excluded segment for flushed segment", func(t *testing.T) {
 
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -242,7 +248,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 
 	t.Run("test add excluded segment for dropped segment", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -267,7 +274,8 @@ func TestTask_watchDmChannelsTask(t *testing.T) {
 
 	t.Run("test load growing segment", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := watchDmChannelsTask{
 			req:  genWatchDMChannelsRequest(),
@@ -325,7 +333,8 @@ func TestTask_releaseCollectionTask(t *testing.T) {
 
 	t.Run("test execute", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		/*
 			err = node.queryService.addQueryCollection(defaultCollectionID)
@@ -341,7 +350,8 @@ func TestTask_releaseCollectionTask(t *testing.T) {
 
 	t.Run("test execute no collection", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		err = node.metaReplica.removeCollection(defaultCollectionID)
 		assert.NoError(t, err)
@@ -356,7 +366,8 @@ func TestTask_releaseCollectionTask(t *testing.T) {
 
 	t.Run("test execute remove deltaVChannel tSafe", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		/*
 			err = node.queryService.addQueryCollection(defaultCollectionID)
@@ -413,7 +424,8 @@ func TestTask_releasePartitionTask(t *testing.T) {
 
 	t.Run("test isAllPartitionsReleased", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := releasePartitionsTask{
 			req:  genReleasePartitionsRequest(),
@@ -435,7 +447,8 @@ func TestTask_releasePartitionTask(t *testing.T) {
 
 	t.Run("test execute", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		/*
 			err = node.queryService.addQueryCollection(defaultCollectionID)
@@ -453,7 +466,8 @@ func TestTask_releasePartitionTask(t *testing.T) {
 
 	t.Run("test execute no collection", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := releasePartitionsTask{
 			req:  genReleasePartitionsRequest(),
@@ -468,7 +482,8 @@ func TestTask_releasePartitionTask(t *testing.T) {
 
 	t.Run("test execute no partition", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		task := releasePartitionsTask{
 			req:  genReleasePartitionsRequest(),
@@ -483,7 +498,8 @@ func TestTask_releasePartitionTask(t *testing.T) {
 
 	t.Run("test execute non-exist partition", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		req := genReleasePartitionsRequest()
 		req.PartitionIDs = []int64{-1}
@@ -498,7 +514,8 @@ func TestTask_releasePartitionTask(t *testing.T) {
 
 	t.Run("test execute remove deltaVChannel", func(t *testing.T) {
 		node, err := genSimpleQueryNode(ctx)
-		assert.NoError(t, err)
+		require.NoError(t, err)
+		defer node.Stop()
 
 		col, err := node.metaReplica.getCollectionByID(defaultCollectionID)
 		assert.NoError(t, err)