From e15ac2b4722940dcd5f3fa3799f1ca86014063a4 Mon Sep 17 00:00:00 2001 From: "yihao.dai" Date: Mon, 8 Jul 2024 20:00:14 +0800 Subject: [PATCH] fix: Fix incorrect segment num rows (#34441) Repeated calls to UpdateStatistics, this PR correct it. issue: https://github.com/milvus-io/milvus/issues/34440 --------- Signed-off-by: bigsheeper --- internal/datanode/writebuffer/insert_buffer.go | 1 - internal/datanode/writebuffer/write_buffer.go | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/datanode/writebuffer/insert_buffer.go b/internal/datanode/writebuffer/insert_buffer.go index c17beba4bd..b7f496e83a 100644 --- a/internal/datanode/writebuffer/insert_buffer.go +++ b/internal/datanode/writebuffer/insert_buffer.go @@ -107,7 +107,6 @@ func (ib *InsertBuffer) buffer(inData *storage.InsertData, tr TimeRange, startPo // buffer := ib.currentBuffer() // storage.MergeInsertData(buffer.buffer, inData) ib.buffers = append(ib.buffers, inData) - ib.UpdateStatistics(int64(inData.GetRowNum()), int64(inData.GetMemorySize()), tr, startPos, endPos) } func (ib *InsertBuffer) Yield() []*storage.InsertData { diff --git a/internal/datanode/writebuffer/write_buffer.go b/internal/datanode/writebuffer/write_buffer.go index 9eccc09179..7f28c288c2 100644 --- a/internal/datanode/writebuffer/write_buffer.go +++ b/internal/datanode/writebuffer/write_buffer.go @@ -597,7 +597,7 @@ func (wb *writeBufferBase) getSyncTask(ctx context.Context, segmentID int64) (sy actions := []metacache.SegmentAction{} for _, chunk := range insert { - batchSize = int64(chunk.GetRowNum()) + batchSize += int64(chunk.GetRowNum()) totalMemSize += float64(chunk.GetMemorySize()) }