enhance: Add unittest for `storage.DeleteLog` (#34190)

See also #33787
Backport unit test part in #34188

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>

internal/storage/delta_data_test.go

@@ -0,0 +1,152 @@
+// Licensed to the LF AI & Data foundation under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package storage
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/suite"
+)
+
+type DeleteLogSuite struct {
+	suite.Suite
+}
+
+func (s *DeleteLogSuite) TestParse() {
+	type testCase struct {
+		tag       string
+		input     string
+		expectErr bool
+		expectID  any // int64 or string
+		expectTs  uint64
+	}
+
+	cases := []testCase{
+		{
+			tag:      "normal_int64",
+			input:    `{"pkType":5,"ts":1000,"pk":100}`,
+			expectID: int64(100),
+			expectTs: 1000,
+		},
+		{
+			tag:      "normal_varchar",
+			input:    `{"pkType":21,"ts":1000,"pk":"100"}`,
+			expectID: "100",
+			expectTs: 1000,
+		},
+		{
+			tag:      "legacy_format",
+			input:    `100,1000`,
+			expectID: int64(100),
+			expectTs: 1000,
+		},
+		{
+			tag:       "bad_format",
+			input:     "abc",
+			expectErr: true,
+		},
+		{
+			tag:       "bad_legacy_id",
+			input:     "abc,100",
+			expectErr: true,
+		},
+		{
+			tag:       "bad_legacy_ts",
+			input:     "100,timestamp",
+			expectErr: true,
+		},
+	}
+
+	for _, tc := range cases {
+		s.Run(tc.tag, func() {
+			dl := &DeleteLog{}
+			err := dl.Parse((tc.input))
+			if tc.expectErr {
+				s.Error(err)
+				return
+			}
+
+			s.NoError(err)
+			s.EqualValues(tc.expectID, dl.Pk.GetValue())
+			s.Equal(tc.expectTs, dl.Ts)
+		})
+	}
+}
+
+func (s *DeleteLogSuite) TestUnmarshalJSON() {
+	type testCase struct {
+		tag       string
+		input     string
+		expectErr bool
+		expectID  any // int64 or string
+		expectTs  uint64
+	}
+
+	cases := []testCase{
+		{
+			tag:      "normal_int64",
+			input:    `{"pkType":5,"ts":1000,"pk":100}`,
+			expectID: int64(100),
+			expectTs: 1000,
+		},
+		{
+			tag:      "normal_varchar",
+			input:    `{"pkType":21,"ts":1000,"pk":"100"}`,
+			expectID: "100",
+			expectTs: 1000,
+		},
+		{
+			tag:       "bad_format",
+			input:     "abc",
+			expectErr: true,
+		},
+		{
+			tag:       "bad_pk_type",
+			input:     `{"pkType":"unknown","ts":1000,"pk":100}`,
+			expectErr: true,
+		},
+		{
+			tag:       "bad_id_type",
+			input:     `{"pkType":5,"ts":1000,"pk":"abc"}`,
+			expectErr: true,
+		},
+		{
+			tag:       "bad_ts_type",
+			input:     `{"pkType":5,"ts":{},"pk":100}`,
+			expectErr: true,
+		},
+	}
+
+	for _, tc := range cases {
+		s.Run(tc.tag, func() {
+			dl := &DeleteLog{}
+			err := dl.UnmarshalJSON([]byte(tc.input))
+			if tc.expectErr {
+				s.Error(err)
+				return
+			}
+
+			s.NoError(err)
+			s.EqualValues(tc.expectID, dl.Pk.GetValue())
+			s.Equal(tc.expectTs, dl.Ts)
+		})
+	}
+}
+
+func TestDeleteLog(t *testing.T) {
+	suite.Run(t, new(DeleteLogSuite))
+}