milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Standard indexnode log printing (#8587) 

Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
pull/8630/head
cai.zhang 2021-09-26 21:22:04 +08:00 committed by GitHub
parent 8465d03dec
commit df30315144
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/indexnode/indexnode.go
View File

@ -132,7 +132,7 @@ func (i *IndexNode) Init() error {
}
err := retry.Do(i.loopCtx, connectEtcdFn, retry.Attempts(300))
if err != nil {
log.Debug("IndexNode try connect etcd failed", zap.Error(err))
log.Error("IndexNode try connect etcd failed", zap.Error(err))
initErr = err
return
}
@ -148,7 +148,7 @@ func (i *IndexNode) Init() error {
}
i.kv, err = miniokv.NewMinIOKV(i.loopCtx, option)
if err != nil {
log.Debug("IndexNode NewMinIOKV failed", zap.Error(err))
log.Error("IndexNode NewMinIOKV failed", zap.Error(err))
initErr = err
return
}

4
internal/indexnode/indexnode_mock.go
View File

@ -85,7 +85,7 @@ func (inm *Mock) buildIndexTask() {
}
err := retry.Do(context.Background(), saveIndexMeta, retry.Attempts(3))
if err != nil {
log.Debug("IndexNode Mock saveIndexMeta error", zap.Error(err))
log.Error("IndexNode Mock saveIndexMeta error", zap.Error(err))
}
} else {
saveIndexMeta := func() error {
@ -127,7 +127,7 @@ func (inm *Mock) buildIndexTask() {
}
err := retry.Do(context.Background(), saveIndexMeta, retry.Attempts(3))
if err != nil {
log.Debug("IndexNode Mock saveIndexMeta error", zap.Error(err))
log.Error("IndexNode Mock saveIndexMeta error", zap.Error(err))
}
}
}

14
internal/indexnode/task.go
View File

@ -122,19 +122,19 @@ func (it *IndexBuildTask) checkIndexMeta(ctx context.Context, pre bool) error {
indexMeta := indexpb.IndexMeta{}
_, values, versions, err := it.etcdKV.LoadWithPrefix2(it.req.MetaPath)
if err != nil {
log.Debug("IndexNode checkIndexMeta", zap.Any("load meta error with path", it.req.MetaPath),
log.Error("IndexNode checkIndexMeta", zap.Any("load meta error with path", it.req.MetaPath),
zap.Error(err), zap.Any("pre", pre))
return err
}
log.Debug("IndexNode checkIndexMeta load meta success", zap.Any("path", it.req.MetaPath), zap.Any("pre", pre))
err = proto.UnmarshalText(values[0], &indexMeta)
if err != nil {
log.Debug("IndexNode checkIndexMeta Unmarshal", zap.Error(err))
log.Error("IndexNode checkIndexMeta Unmarshal", zap.Error(err))
return err
}
log.Debug("IndexNode checkIndexMeta Unmarshal success", zap.Any("IndexMeta", indexMeta))
if indexMeta.Version > it.req.Version || indexMeta.State == commonpb.IndexState_Finished {
log.Debug("IndexNode checkIndexMeta Notify build index this version is not the latest version", zap.Any("version", it.req.Version))
log.Warn("IndexNode checkIndexMeta Notify build index this version is not the latest version", zap.Any("version", it.req.Version))
return nil
}
if indexMeta.MarkDeleted {
@ -154,7 +154,7 @@ func (it *IndexBuildTask) checkIndexMeta(ctx context.Context, pre bool) error {
indexMeta.IndexFilePaths = it.savePaths
indexMeta.State = commonpb.IndexState_Finished
if it.err != nil {
log.Debug("IndexNode CreateIndex Failed", zap.Int64("IndexBuildID", indexMeta.IndexBuildID), zap.Any("err", err))
log.Error("IndexNode CreateIndex Failed", zap.Int64("IndexBuildID", indexMeta.IndexBuildID), zap.Any("err", err))
indexMeta.State = commonpb.IndexState_Failed
indexMeta.FailReason = it.err.Error()
}
@ -364,18 +364,18 @@ func (it *IndexBuildTask) Execute(ctx context.Context) error {
saveIndexFileFn := func() error {
v, err := it.etcdKV.Load(it.req.MetaPath)
if err != nil {
log.Debug("IndexNode load meta failed", zap.Any("path", it.req.MetaPath), zap.Error(err))
log.Error("IndexNode load meta failed", zap.Any("path", it.req.MetaPath), zap.Error(err))
return err
}
indexMeta := indexpb.IndexMeta{}
err = proto.UnmarshalText(v, &indexMeta)
if err != nil {
log.Debug("IndexNode Unmarshal indexMeta error ", zap.Error(err))
log.Error("IndexNode Unmarshal indexMeta error ", zap.Error(err))
return err
}
//log.Debug("IndexNode Unmarshal indexMeta success ", zap.Any("meta", indexMeta))
if indexMeta.Version > it.req.Version {
log.Debug("IndexNode try saveIndexFile failed req.Version is low", zap.Any("req.Version", it.req.Version),
log.Warn("IndexNode try saveIndexFile failed req.Version is low", zap.Any("req.Version", it.req.Version),
zap.Any("indexMeta.Version", indexMeta.Version))
return errors.New("This task has been reassigned ")
}