milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable tt delay protection (#20658) 

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
pull/20693/head
bigsheeper 2022-11-17 20:21:14 +08:00 committed by GitHub
parent 8b682fdeac
commit dbcbe4d8f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configs/milvus.yaml
View File

@ -447,7 +447,7 @@ quotaAndLimits:
# specific conditions, such as memory of nodes to water marker), `true` means always reject all dml requests. # specific conditions, such as memory of nodes to water marker), `true` means always reject all dml requests.
forceDeny: false forceDeny: false
ttProtection: ttProtection:
enabled: true enabled: false
# maxTimeTickDelay indicates the backpressure for DML Operations. # maxTimeTickDelay indicates the backpressure for DML Operations.
# DML rates would be reduced according to the ratio of time tick delay to maxTimeTickDelay, # DML rates would be reduced according to the ratio of time tick delay to maxTimeTickDelay,
# if time tick delay is greater than maxTimeTickDelay, all DML requests would be rejected. # if time tick delay is greater than maxTimeTickDelay, all DML requests would be rejected.

5
internal/util/paramtable/quota_param_test.go
View File

@ -19,7 +19,6 @@ package paramtable
import ( import (
"math" "math"
"testing" "testing"
"time"
"github.com/stretchr/testify/assert" "github.com/stretchr/testify/assert"
) )
@ -72,8 +71,8 @@ func TestQuotaParam(t *testing.T) {
t.Run("test limit writing", func(t *testing.T) { t.Run("test limit writing", func(t *testing.T) {
assert.False(t, qc.ForceDenyWriting) assert.False(t, qc.ForceDenyWriting)
assert.Equal(t, true, qc.TtProtectionEnabled) assert.Equal(t, false, qc.TtProtectionEnabled)
assert.Equal(t, 300*time.Second, qc.MaxTimeTickDelay) assert.Equal(t, math.MaxInt64, int(qc.MaxTimeTickDelay))
assert.Equal(t, defaultLowWaterLevel, qc.DataNodeMemoryLowWaterLevel) assert.Equal(t, defaultLowWaterLevel, qc.DataNodeMemoryLowWaterLevel)
assert.Equal(t, defaultHighWaterLevel, qc.DataNodeMemoryHighWaterLevel) assert.Equal(t, defaultHighWaterLevel, qc.DataNodeMemoryHighWaterLevel)
assert.Equal(t, defaultLowWaterLevel, qc.QueryNodeMemoryLowWaterLevel) assert.Equal(t, defaultLowWaterLevel, qc.QueryNodeMemoryLowWaterLevel)