fix: return correct compaction plan count by datacoord (#29980)

issue: #29943

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
pull/30149/head
Bingyi Sun 2024-01-19 21:06:55 +08:00 committed by GitHub
parent a762561730
commit d8025177fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 1 deletions

View File

@ -2477,6 +2477,15 @@ func TestManualCompaction(t *testing.T) {
},
}
mockHandler := NewMockCompactionPlanContext(t)
mockHandler.EXPECT().getCompactionTasksBySignalID(mock.Anything).Return(
[]*compactionTask{
{
triggerInfo: &compactionSignal{id: 1},
state: executing,
},
})
svr.compactionHandler = mockHandler
resp, err := svr.ManualCompaction(context.TODO(), &milvuspb.ManualCompactionRequest{
CollectionID: 1,
Timetravel: 1,

View File

@ -1078,8 +1078,16 @@ func (s *Server) ManualCompaction(ctx context.Context, req *milvuspb.ManualCompa
return resp, nil
}
plans := s.compactionHandler.getCompactionTasksBySignalID(id)
if len(plans) == 0 {
resp.CompactionID = -1
resp.CompactionPlanCount = 0
} else {
resp.CompactionID = id
resp.CompactionPlanCount = int32(len(plans))
}
log.Info("success to trigger manual compaction", zap.Int64("compactionID", id))
resp.CompactionID = id
return resp, nil
}