enhance: Continue loop when reassign channel fails (#34331)

Log will be confusing when `Reassign` channel operation failed for both
success & failure log will be printed in row. This PR continue the loop
to avoid this output.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/34417/head
congqixia 2024-07-04 14:20:10 +08:00 committed by GitHub
parent c6e2900cfc
commit d51d0954bd
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions

View File

@ -23,7 +23,6 @@ import (
"time"
"github.com/cockroachdb/errors"
"github.com/golang/protobuf/proto"
"github.com/samber/lo"
"go.uber.org/zap"
@ -488,6 +487,7 @@ func (m *ChannelManagerImplV2) advanceStandbys(_ context.Context, standbys []*No
zap.Int64("nodeID", nodeAssign.NodeID),
zap.Strings("channels", chNames),
)
continue
}
log.Info("Reassign standby channels to node",
@ -523,7 +523,7 @@ func (m *ChannelManagerImplV2) advanceToNotifies(ctx context.Context, toNotifies
)
for _, ch := range nodeAssign.Channels {
innerCh := ch
tmpWatchInfo := proto.Clone(innerCh.GetWatchInfo()).(*datapb.ChannelWatchInfo)
tmpWatchInfo := typeutil.Clone(innerCh.GetWatchInfo())
tmpWatchInfo.Vchan = m.h.GetDataVChanPositions(innerCh, allPartitionID)
future := getOrCreateIOPool().Submit(func() (any, error) {