milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix getting query segment info error during the period of loading and unloading segments (#20549) 

issue: #20281

Signed-off-by: MrPresent-Han <jamesharden11122@gmail.com>

Signed-off-by: MrPresent-Han <jamesharden11122@gmail.com>
pull/20724/head
MrPresent-Han 2022-11-21 10:41:10 +08:00 committed by GitHub
parent bf2107ecf5
commit d44d50e735
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/querycoordv2/handlers.go
View File

@ -62,8 +62,20 @@ func (s *Server) checkAnyReplicaAvailable(collectionID int64) bool {
func (s *Server) getCollectionSegmentInfo(collection int64) []*querypb.SegmentInfo {
segments := s.dist.SegmentDistManager.GetByCollection(collection)
currentTargetSegmentsMap := s.targetMgr.GetHistoricalSegmentsByCollection(collection, meta.CurrentTarget)
infos := make(map[int64]*querypb.SegmentInfo)
for _, segment := range segments {
if _, existCurrentTarget := currentTargetSegmentsMap[segment.GetID()]; !existCurrentTarget {
//if one segment exists in distMap but doesn't exist in currentTargetMap
//in order to guarantee that get segment request launched by sdk could get
//consistent result, for example
//sdk insert three segments:A, B, D, then A + B----compact--> C
//In this scenario, we promise that clients see either 2 segments(C,D) or 3 segments(A, B, D)
//rather than 4 segments(A, B, C, D), in which query nodes are loading C but have completed loading process
log.Info("filtered segment being in the intermediate status",
zap.Int64("segmentID", segment.GetID()))
continue
}
info, ok := infos[segment.GetID()]
if !ok {
info = &querypb.SegmentInfo{}