milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce go unittest time cost (#8448) 

Signed-off-by: yhmo <yihua.mo@zilliz.com>
pull/8479/head
groot 2021-09-24 15:27:54 +08:00 committed by GitHub
parent 4fba738bec
commit d28341932e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
internal/proxy/util.go
View File

@ -26,7 +26,7 @@ import (
"github.com/milvus-io/milvus/internal/util/retry"
)
func GetPulsarConfig(protocol, ip, port, url string) (map[string]interface{}, error) {
func GetPulsarConfig(protocol, ip, port, url string, args ...int64) (map[string]interface{}, error) {
var resp *http.Response
var err error
@ -36,13 +36,25 @@ func GetPulsarConfig(protocol, ip, port, url string) (map[string]interface{}, er
return err
}
err = retry.Do(context.TODO(), getResp, retry.Attempts(10), retry.Sleep(time.Second))
var attempt uint = 10
var interval time.Duration = time.Second
if len(args) > 0 && args[0] > 0 {
attempt = uint(args[0])
}
if len(args) > 1 && args[1] > 0 {
interval = time.Duration(args[1])
}
err = retry.Do(context.TODO(), getResp, retry.Attempts(attempt), retry.Sleep(interval))
if err != nil {
log.Debug("failed to get config", zap.String("error", err.Error()))
return nil, err
}
defer resp.Body.Close()
body, err := ioutil.ReadAll(resp.Body)
log.Debug("get config", zap.String("config", string(body)))
if err != nil {
return nil, err
}

2
internal/proxy/util_test.go
View File

@ -101,7 +101,7 @@ func TestGetPulsarConfig_Error(t *testing.T) {
port := "17777"
url := "/admin/v2/brokers/configuration/runtime"
ret, err := GetPulsarConfig(protocol, ip, port, url)
ret, err := GetPulsarConfig(protocol, ip, port, url, 1, 1)
assert.NotNil(t, err)
assert.Nil(t, ret)
}