milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MS-492 Drop index failed if index have been created with index_type: FLAT 

Former-commit-id: 6451e083ad60c076e98d063662a914f09832abfc
pull/191/head
starlord 2019-09-06 14:39:26 +08:00
parent acae77d694
commit ce7de0941f
2 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cpp/CHANGELOG.md
View File

@ -26,6 +26,7 @@ Please mark all change in change log and use the ticket from JIRA.
- MS-467 - mysql db test failed - MS-467 - mysql db test failed
- MS-470 - Drop index success, which table not created - MS-470 - Drop index success, which table not created
- MS-471 - code coverage run failed - MS-471 - code coverage run failed
- MS-492 - Drop index failed if index have been created with index_type: FLAT
## Improvement ## Improvement
- MS-327 - Clean code for milvus - MS-327 - Clean code for milvus

11
cpp/src/server/grpc_impl/GrpcRequestTask.cpp
View File

@ -955,15 +955,8 @@ DropIndexTask::OnExecute() {
return SetError(res, "Invalid table name: " + table_name_); return SetError(res, "Invalid table name: " + table_name_);
} }
//step 2:check index existence //step 2: check table existence
engine::TableIndex index; auto stat = DBWrapper::DB()->DropIndex(table_name_);
engine::Status stat = DBWrapper::DB()->DescribeIndex(table_name_, index);
if (index.engine_type_ == 1) {
return SetError(SERVER_UNEXPECTED_ERROR, "index not existed");
}
//step 3: check table existence
stat = DBWrapper::DB()->DropIndex(table_name_);
if (!stat.ok()) { if (!stat.ok()) {
return SetError(DB_META_TRANSACTION_FAILED, stat.ToString()); return SetError(DB_META_TRANSACTION_FAILED, stat.ToString());
} }