milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Limit max shard num to 64 (#19776) 

Signed-off-by: longjiquan <jiquan.long@zilliz.com>

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
pull/19714/head
Jiquan Long 2022-10-14 14:51:23 +08:00 committed by GitHub
parent 8c9c1672ae
commit cb51d410a2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/rootcoord/constrant.go
View File

@ -6,4 +6,6 @@ const (
globalIDAllocatorSubPath = "gid" globalIDAllocatorSubPath = "gid"
globalTSOAllocatorKey = "timestamp" globalTSOAllocatorKey = "timestamp"
globalTSOAllocatorSubPath = "tso" globalTSOAllocatorSubPath = "tso"
maxShardNum = 64
) )

4
internal/rootcoord/create_collection_task.go
View File

@ -50,6 +50,10 @@ func (t *createCollectionTask) validate() error {
return err return err
} }
if t.Req.GetShardsNum() >= maxShardNum {
return fmt.Errorf("shard num (%d) exceeds limit (%d)", t.Req.GetShardsNum(), maxShardNum)
}
return nil return nil
} }

11
internal/rootcoord/create_collection_task_test.go
View File

@ -40,6 +40,17 @@ func Test_createCollectionTask_validate(t *testing.T) {
assert.Error(t, err) assert.Error(t, err)
}) })
t.Run("shard num exceeds limit", func(t *testing.T) {
task := createCollectionTask{
Req: &milvuspb.CreateCollectionRequest{
Base: &commonpb.MsgBase{MsgType: commonpb.MsgType_CreateCollection},
ShardsNum: maxShardNum + 1,
},
}
err := task.validate()
assert.Error(t, err)
})
t.Run("normal case", func(t *testing.T) { t.Run("normal case", func(t *testing.T) {
task := createCollectionTask{ task := createCollectionTask{
Req: &milvuspb.CreateCollectionRequest{ Req: &milvuspb.CreateCollectionRequest{