milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[skip ci] Check the grammar of root_coord_recovery docs (#12746) 

Signed-off-by: min.tian <min.tian.cn@gmail.com>
pull/12784/merge
min.tian 2021-12-06 18:00:07 +08:00 committed by GitHub
parent 92eff1565c
commit cac577a073
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/design_docs/root_coordinator_recovery_on_power_failure.md
View File

@ -33,7 +33,7 @@
### 2.3 `create index` requests from grpc
1. In the processing of `create index`, `RC` calls `metaTable`'s `GetNotIndexedSegments` to get all segment ids that are not indexed
2. After getting the segment ids, `RC` call `IC` to create index on these segment ids.
2. After getting the segment ids, `RC` calls `IC` to create index on these segment ids.
3. In the current implementation, the `create index` requests will return after the segment ids are put into a go channel.
4. The `RC` starts a background task that keeps reading the segment ids from the go channel, and then calls the `IC` to create the index.
5. There is a fault here, the segment ids have been put into the go channel in the processing function of the grpc request, and then the grpc returns, but the `RC`'s background task has not yet read them from the go channel, then `RC` crashes. At this time, the client thinks that the index is created, but the `RC` does not call `IC` to create the index.