milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix:remove unnecessary error logs (#38245) 

#38241

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
pull/38028/head^2
zhagnlu 2024-12-08 17:20:40 +08:00 committed by GitHub
parent 8d2eefb264
commit c522ce84b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/datacoord/task_index.go
View File

@ -211,7 +211,7 @@ func (it *indexBuildTask) PreCheck(ctx context.Context, dependency *taskSchedule
optionalFields := make([]*indexpb.OptionalFieldInfo, 0) optionalFields := make([]*indexpb.OptionalFieldInfo, 0)
partitionKeyIsolation := false partitionKeyIsolation := false
isVectorTypeSupported := typeutil.IsDenseFloatVectorType(field.DataType) || typeutil.IsBinaryVectorType(field.DataType) isVectorTypeSupported := typeutil.IsDenseFloatVectorType(field.DataType) || typeutil.IsBinaryVectorType(field.DataType)
if Params.CommonCfg.EnableMaterializedView.GetAsBool() && isOptionalScalarFieldSupported(indexType) && isVectorTypeSupported { if Params.CommonCfg.EnableMaterializedView.GetAsBool() && isVectorTypeSupported && isMvSupported(indexType) {
if collectionInfo == nil { if collectionInfo == nil {
log.Ctx(ctx).Warn("get collection failed", zap.Int64("collID", segIndex.CollectionID), zap.Error(err)) log.Ctx(ctx).Warn("get collection failed", zap.Int64("collID", segIndex.CollectionID), zap.Error(err))
it.SetState(indexpb.JobState_JobStateInit, err.Error()) it.SetState(indexpb.JobState_JobStateInit, err.Error())

2
internal/datacoord/util.go
View File

@ -207,7 +207,7 @@ func isNoTrainIndex(indexType string) bool {
return vecindexmgr.GetVecIndexMgrInstance().IsNoTrainIndex(indexType) return vecindexmgr.GetVecIndexMgrInstance().IsNoTrainIndex(indexType)
} }
func isOptionalScalarFieldSupported(indexType string) bool { func isMvSupported(indexType string) bool {
return vecindexmgr.GetVecIndexMgrInstance().IsMvSupported(indexType) return vecindexmgr.GetVecIndexMgrInstance().IsMvSupported(indexType)
} }

1
internal/util/vecindexmgr/vector_index_mgr.go
View File

@ -87,7 +87,6 @@ type vecIndexMgrImpl struct {
func (mgr *vecIndexMgrImpl) GetFeature(indexType IndexType) (uint64, bool) { func (mgr *vecIndexMgrImpl) GetFeature(indexType IndexType) (uint64, bool) {
feature, ok := mgr.features[indexType] feature, ok := mgr.features[indexType]
if !ok { if !ok {
log.Error("can not find index " + indexType + " in the index feature map")
return 0, false return 0, false
} }
return feature, true return feature, true