milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: enable multiple chunked segment by default (#37570) 

Signed-off-by: sunby <sunbingyi1992@gmail.com>
pull/37561/head
Bingyi Sun 2024-11-12 09:20:28 +08:00 committed by GitHub
parent 81141bd18d
commit c1eccce2fa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
configs/milvus.yaml
View File

@ -403,7 +403,7 @@ queryNode:
nprobe: 16 # nprobe to search small index, based on your accuracy requirement, must smaller than nlist
memExpansionRate: 1.15 # extra memory needed by building interim index
buildParallelRate: 0.5 # the ratio of building interim index parallel matched with cpu num
multipleChunkedEnable: false # Enable multiple chunked search
multipleChunkedEnable: true # Enable multiple chunked search
knowhereScoreConsistency: false # Enable knowhere strong consistency score computation logic
loadMemoryUsageFactor: 1 # The multiply factor of calculating the memory usage while loading segments
enableDisk: false # enable querynode load disk index, and search on disk index

9
internal/core/src/segcore/SegmentChunkReader.cpp
View File

@ -125,9 +125,6 @@ SegmentChunkReader::GetChunkDataAccessor<std::string>(
auto chunk_info =
segment_->chunk_view<std::string_view>(field_id, current_chunk_id);
auto chunk_data = chunk_info.first.data();
auto chunk_valid_data = chunk_info.second;
auto current_chunk_size =
segment_->chunk_size(field_id, current_chunk_id);
return [=,
@ -136,13 +133,13 @@ SegmentChunkReader::GetChunkDataAccessor<std::string>(
if (current_chunk_pos >= current_chunk_size) {
current_chunk_id++;
current_chunk_pos = 0;
auto chunk_info = segment_->chunk_view<std::string_view>(
chunk_info = segment_->chunk_view<std::string_view>(
field_id, current_chunk_id);
chunk_data = chunk_info.first.data();
chunk_valid_data = chunk_info.second;
current_chunk_size =
segment_->chunk_size(field_id, current_chunk_id);
}
auto chunk_data = chunk_info.first;
auto chunk_valid_data = chunk_info.second;
if (current_chunk_pos < chunk_valid_data.size() &&
!chunk_valid_data[current_chunk_pos]) {
current_chunk_pos++;