milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix golint error in proxy (#10620) 

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
pull/10619/head
zhenshan.cao 2021-10-26 10:38:41 +08:00 committed by GitHub
parent 1478b9298c
commit bb08df28f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/proxy/task.go
View File

@ -1141,7 +1141,7 @@ func (cct *createCollectionTask) PreExecute(ctx context.Context) error {
return err return err
} }
if err := ValidateDuplicatedFieldName(cct.schema.Fields); err != nil { if err := validateDuplicatedFieldName(cct.schema.Fields); err != nil {
return err return err
} }

2
internal/proxy/task_test.go
View File

@ -1004,7 +1004,7 @@ func TestCreateCollectionTask(t *testing.T) {
err = task.PreExecute(ctx) err = task.PreExecute(ctx)
assert.Error(t, err) assert.Error(t, err)
// ValidateDuplicatedFieldName // validateDuplicatedFieldName
schema = proto.Clone(schemaBackup).(*schemapb.CollectionSchema) schema = proto.Clone(schemaBackup).(*schemapb.CollectionSchema)
schema.Fields = append(schema.Fields, schema.Fields[0]) schema.Fields = append(schema.Fields, schema.Fields[0])
duplicatedFieldsSchema, err := proto.Marshal(schema) duplicatedFieldsSchema, err := proto.Marshal(schema)

2
internal/proxy/validate_util.go
View File

@ -162,7 +162,7 @@ func validateVectorFieldMetricType(field *schemapb.FieldSchema) error {
return errors.New("vector float without metric_type") return errors.New("vector float without metric_type")
} }
func ValidateDuplicatedFieldName(fields []*schemapb.FieldSchema) error { func validateDuplicatedFieldName(fields []*schemapb.FieldSchema) error {
names := make(map[string]bool) names := make(map[string]bool)
for _, field := range fields { for _, field := range fields {
_, ok := names[field.Name] _, ok := names[field.Name]

4
internal/proxy/validate_util_test.go
View File

@ -138,11 +138,11 @@ func TestValidateDuplicatedFieldName(t *testing.T) {
{Name: "abc"}, {Name: "abc"},
{Name: "def"}, {Name: "def"},
} }
assert.Nil(t, ValidateDuplicatedFieldName(fields)) assert.Nil(t, validateDuplicatedFieldName(fields))
fields = append(fields, &schemapb.FieldSchema{ fields = append(fields, &schemapb.FieldSchema{
Name: "abc", Name: "abc",
}) })
assert.NotNil(t, ValidateDuplicatedFieldName(fields)) assert.NotNil(t, validateDuplicatedFieldName(fields))
} }
func TestValidatePrimaryKey(t *testing.T) { func TestValidatePrimaryKey(t *testing.T) {