Add enum Role in internal.proto

Signed-off-by: XuanYang-cn <xuan.yang@zilliz.com>

internal/allocator/segment.go

@@ -262,7 +262,7 @@ func (sa *SegIDAssigner) syncSegments() bool {
 	defer cancel()
 	req := &datapb.AssignSegIDRequest{
 		NodeID:        sa.PeerID,
-		PeerRole:      "ProxyNode",
+		PeerRole:      typeutil.ProxyNodeRole,
 		SegIDRequests: sa.segReqs,
 	}
 

internal/master/master_test.go

@@ -15,6 +15,7 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/zilliztech/milvus-distributed/internal/util/tsoutil"
+	"github.com/zilliztech/milvus-distributed/internal/util/typeutil"
 
 	"github.com/golang/protobuf/proto"
 	"github.com/stretchr/testify/assert"
@@ -1147,7 +1148,7 @@ func TestMaster(t *testing.T) {
 
 		resp, err := cli.AssignSegmentID(ctx, &datapb.AssignSegIDRequest{
 			NodeID:   1,
-			PeerRole: "ProxyNode",
+			PeerRole: typeutil.ProxyNodeRole,
 			SegIDRequests: []*datapb.SegIDRequest{
 				{Count: 10000, ChannelName: "0", CollName: collName, PartitionName: partitionName},
 			},

internal/masterservice/master_service.go

@@ -612,7 +612,7 @@ func (c *Core) GetComponentStates(empty *commonpb.Empty) (*internalpb2.Component
 	return &internalpb2.ComponentStates{
 		State: &internalpb2.ComponentInfo{
 			NodeID:    int64(Params.NodeID),
-			Role:      "master",
+			Role:      typeutil.MasterServiceRole,
 			StateCode: code,
 			ExtraInfo: nil,
 		},

internal/proto/internal.proto

@@ -10,7 +10,6 @@ enum StateCode {
   ABNORMAL = 2;
 }
 
-
 message ComponentInfo {
   int64  nodeID = 1;
   string role = 2;

internal/querynode/query_node.go

@@ -182,7 +182,7 @@ func (node *QueryNode) GetComponentStates() (*internalpb2.ComponentStates, error
 	}
 	info := &internalpb2.ComponentInfo{
 		NodeID:    Params.QueryNodeID,
-		Role:      "query-node",
+		Role:      typeutil.QueryNodeRole,
 		StateCode: code,
 	}
 	stats := &internalpb2.ComponentStates{

internal/util/typeutil/type.go

@@ -3,3 +3,15 @@ package typeutil
 type Timestamp = uint64
 type IntPrimaryKey = int64
 type UniqueID = int64
+
+const (
+	MasterServiceRole = "MasterService"
+	ProxyServiceRole  = "ProxyService"
+	ProxyNodeRole     = "ProxyNode"
+	QueryServiceRole  = "QueryService"
+	QueryNodeRole     = "QueryNode"
+	IndexServiceRole  = "IndexService"
+	IndexNodeRole     = "IndexNode"
+	DataServiceRole   = "DataService"
+	DataNodeRole      = "DataNode"
+)

scripts/run_go_unittest.sh

@@ -17,6 +17,7 @@ echo $MILVUS_DIR
 go test -race -cover "${MILVUS_DIR}/kv/..." -failfast
 go test -race -cover "${MILVUS_DIR}/proxynode/..." -failfast
 go test -race -cover "${MILVUS_DIR}/writenode/..." -failfast
+go test -race -cover "${MILVUS_DIR}/datanode/..." -failfast
 go test -race -cover "${MILVUS_DIR}/master/..." -failfast
 go test -race -cover "${MILVUS_DIR}/indexnode/..." -failfast
 go test -race -cover "${MILVUS_DIR}/msgstream/..." "${MILVUS_DIR}/querynode/..." "${MILVUS_DIR}/storage"   "${MILVUS_DIR}/util/..." -failfast