From b4c749dcd5dfed51204fc4b9014e0114b206ea1d Mon Sep 17 00:00:00 2001 From: aoiasd <45024769+aoiasd@users.noreply.github.com> Date: Thu, 7 Nov 2024 11:18:26 +0800 Subject: [PATCH] fix: merge sort segment loss data (#37400) relate: https://github.com/milvus-io/milvus/issues/37238 Signed-off-by: aoiasd --- internal/datanode/compaction/merge_sort.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/internal/datanode/compaction/merge_sort.go b/internal/datanode/compaction/merge_sort.go index bcf8dd8bb7..a43cc0c179 100644 --- a/internal/datanode/compaction/merge_sort.go +++ b/internal/datanode/compaction/merge_sort.go @@ -105,6 +105,12 @@ func mergeSortMultipleSegments(ctx context.Context, deletedRowCount++ continue } + + // Filtering expired entity + if isExpiredEntity(collectionTtl, currentTs, typeutil.Timestamp(v.Timestamp)) { + expiredRowCount++ + continue + } return v, nil } } @@ -125,12 +131,6 @@ func mergeSortMultipleSegments(ctx context.Context, smallest := heap.Pop(&pq).(*PQItem) v := smallest.Value - // Filtering expired entity - if isExpiredEntity(collectionTtl, currentTs, typeutil.Timestamp(v.Timestamp)) { - expiredRowCount++ - continue - } - err := mWriter.Write(v) if err != nil { log.Warn("compact wrong, failed to writer row", zap.Error(err))