From b205d7e29f19e78f35ef608186becb0cbd77aba0 Mon Sep 17 00:00:00 2001 From: "yihao.dai" Date: Mon, 27 May 2024 01:37:41 +0800 Subject: [PATCH] fix: Fix frequent 'failed to get request info' log (#33334) (#33337) issue: issue: https://github.com/milvus-io/milvus/issues/33333 pr: https://github.com/milvus-io/milvus/pull/33334 Signed-off-by: bigsheeper --- internal/proxy/rate_limit_interceptor.go | 4 ++-- internal/proxy/rate_limit_interceptor_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/proxy/rate_limit_interceptor.go b/internal/proxy/rate_limit_interceptor.go index 49e3c11b80..01030fb8f1 100644 --- a/internal/proxy/rate_limit_interceptor.go +++ b/internal/proxy/rate_limit_interceptor.go @@ -41,7 +41,7 @@ func RateLimitInterceptor(limiter types.Limiter) grpc.UnaryServerInterceptor { return func(ctx context.Context, req any, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { dbID, collectionIDToPartIDs, rt, n, err := getRequestInfo(ctx, req) if err != nil { - log.RatedWarn(10, "failed to get request info", zap.Error(err)) + log.Warn("failed to get request info", zap.Error(err)) return handler(ctx, req) } @@ -205,7 +205,7 @@ func getRequestInfo(ctx context.Context, req interface{}) (int64, map[int64][]in if req == nil { return util.InvalidDBID, map[int64][]int64{}, 0, 0, fmt.Errorf("null request") } - return util.InvalidDBID, map[int64][]int64{}, 0, 0, fmt.Errorf("unsupported request type %T", req) + return util.InvalidDBID, map[int64][]int64{}, 0, 0, nil } } diff --git a/internal/proxy/rate_limit_interceptor_test.go b/internal/proxy/rate_limit_interceptor_test.go index 5440123da6..b046a3f8a3 100644 --- a/internal/proxy/rate_limit_interceptor_test.go +++ b/internal/proxy/rate_limit_interceptor_test.go @@ -257,7 +257,7 @@ func TestRateLimitInterceptor(t *testing.T) { assert.Error(t, err) _, _, _, _, err = getRequestInfo(context.Background(), &milvuspb.CalcDistanceRequest{}) - assert.Error(t, err) + assert.NoError(t, err) }) t.Run("test getFailedResponse", func(t *testing.T) {