From af18aa709bbd8ae26717c7c52c863b1158c85163 Mon Sep 17 00:00:00 2001 From: congqixia Date: Wed, 22 Nov 2023 14:52:23 +0800 Subject: [PATCH] fix: Remove not needed `BlockAll` call in `SyncSegments` (#28632) See also #28628 Previous compaction task blocked the segment sync task and may block the flowgraph when sync task is generated by auto sync policy This `BlockAll` call will block forever and cause whole fg stuck Signed-off-by: Congqi Xia --- internal/datanode/services.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/datanode/services.go b/internal/datanode/services.go index 8d71c0b7f5..b403c29726 100644 --- a/internal/datanode/services.go +++ b/internal/datanode/services.go @@ -325,8 +325,6 @@ func (node *DataNode) SyncSegments(ctx context.Context, req *datapb.SyncSegments return merr.Status(err), nil } bfs := metacache.NewBloomFilterSet(pks...) - ds.fg.Blockall() - defer ds.fg.Unblock() ds.metacache.CompactSegments(req.GetCompactedTo(), req.GetPartitionId(), req.GetNumOfRows(), bfs, req.GetCompactedFrom()...) node.compactionExecutor.injectDone(req.GetPlanID(), true) return merr.Success(), nil