milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix time tick lag too much (#23265) (#23267) 

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
pull/23284/head
Jiquan Long 2023-04-07 14:28:31 +08:00 committed by GitHub
parent d9b4303056
commit ac479318d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
internal/rootcoord/timeticksync.go
View File

@ -125,7 +125,9 @@ func newTimeTickSync(ctx context.Context, sourceID int64, factory msgstream.Fact
lock: sync.Mutex{},
sess2ChanTsMap: make(map[typeutil.UniqueID]*chanTsMsg),
sendChan: make(chan map[typeutil.UniqueID]*chanTsMsg, 16),
// 1 is the most reasonable capacity. In fact, Milvus can only focus on the latest time tick.
sendChan: make(chan map[typeutil.UniqueID]*chanTsMsg, 1),
syncedTtHistogram: newTtHistogram(),
}
@ -166,7 +168,16 @@ func (t *timetickSync) sendToChannel() {
ptt[k] = v
t.sess2ChanTsMap[k] = nil
}
t.sendChan <- ptt
select {
case t.sendChan <- ptt:
default:
// The consumer of `sendChan` haven't completed its operation. If we send the `ptt` here, the consumer will
// always get an older time tick. The older time tick in `sendChan` will block newer time tick in next window.
// However, in fact the consumer can only focus on the newest.
// TODO: maybe a metric should be here.
}
}
// UpdateTimeTick check msg validation and send it to local channel