milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: Fix import hanging and improve logging output (#32166) 

Fix import hanging when the previous import task failed, and improve
parquet import logging outout.

issue: https://github.com/milvus-io/milvus/issues/31834

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
pull/32177/head
yihao.dai 2024-04-13 22:03:23 +08:00 committed by GitHub
parent 4fb85be525
commit aa96843d31
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/datanode/importv2/scheduler.go
View File

@ -98,7 +98,7 @@ func (s *scheduler) Start() {
for taskID, fs := range futures { for taskID, fs := range futures {
err := conc.AwaitAll(fs...) err := conc.AwaitAll(fs...)
if err != nil { if err != nil {
return continue
} }
s.manager.Update(taskID, UpdateState(datapb.ImportTaskStateV2_Completed)) s.manager.Update(taskID, UpdateState(datapb.ImportTaskStateV2_Completed))
log.Info("preimport/import done", zap.Int64("taskID", taskID)) log.Info("preimport/import done", zap.Int64("taskID", taskID))

3
internal/util/importutilv2/parquet/util.go
View File

@ -76,6 +76,9 @@ func CreateFieldReaders(ctx context.Context, fileReader *pqarrow.FileReader, sch
} }
} }
if !isConvertible(arrowType, dataType, isList) { if !isConvertible(arrowType, dataType, isList) {
if isList {
return nil, WrapTypeErr(dataType.String(), pqField.Type.(*arrow.ListType).ElemField().Type.Name(), field)
}
return nil, WrapTypeErr(dataType.String(), pqField.Type.Name(), field) return nil, WrapTypeErr(dataType.String(), pqField.Type.Name(), field)
} }