milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: balance_unstable_view unit test (#29127) 

fix: #29126
Allow unstable output channel balance plan

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/29075/head
congqixia 2023-12-12 10:02:39 +08:00 committed by GitHub
parent 9d54d6f590
commit a67fc08865
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/querycoordv2/balance/rowcount_based_balancer_test.go
View File

@ -148,6 +148,7 @@ func (suite *RowCountBasedBalancerTestSuite) TestBalance() {
distributionChannels map[int64][]*meta.DmChannel distributionChannels map[int64][]*meta.DmChannel
expectPlans []SegmentAssignPlan expectPlans []SegmentAssignPlan
expectChannelPlans []ChannelAssignPlan expectChannelPlans []ChannelAssignPlan
multiple bool
}{ }{
{ {
name: "normal balance", name: "normal balance",
@ -307,7 +308,9 @@ func (suite *RowCountBasedBalancerTestSuite) TestBalance() {
expectPlans: []SegmentAssignPlan{}, expectPlans: []SegmentAssignPlan{},
expectChannelPlans: []ChannelAssignPlan{ expectChannelPlans: []ChannelAssignPlan{
{Channel: &meta.DmChannel{VchannelInfo: &datapb.VchannelInfo{CollectionID: 1, ChannelName: "v2"}, Node: 1}, From: 1, To: 2, ReplicaID: 1}, {Channel: &meta.DmChannel{VchannelInfo: &datapb.VchannelInfo{CollectionID: 1, ChannelName: "v2"}, Node: 1}, From: 1, To: 2, ReplicaID: 1},
{Channel: &meta.DmChannel{VchannelInfo: &datapb.VchannelInfo{CollectionID: 1, ChannelName: "v2"}, Node: 1}, From: 1, To: 3, ReplicaID: 1},
}, },
multiple: true,
}, },
{ {
name: "already balanced", name: "already balanced",
@ -385,8 +388,13 @@ func (suite *RowCountBasedBalancerTestSuite) TestBalance() {
} }
segmentPlans, channelPlans := suite.getCollectionBalancePlans(balancer, 1) segmentPlans, channelPlans := suite.getCollectionBalancePlans(balancer, 1)
suite.ElementsMatch(c.expectChannelPlans, channelPlans) if !c.multiple {
suite.ElementsMatch(c.expectPlans, segmentPlans) suite.ElementsMatch(c.expectChannelPlans, channelPlans)
suite.ElementsMatch(c.expectPlans, segmentPlans)
} else {
suite.Subset(c.expectPlans, segmentPlans)
suite.Subset(c.expectChannelPlans, channelPlans)
}
// clear distribution // clear distribution
for node := range c.distributions { for node := range c.distributions {