milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix metrics info panic when network error happens (#22802) 

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/22807/head
congqixia 2023-03-16 22:43:55 +08:00 committed by GitHub
parent 6eef5df9ab
commit a48349a9a1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
internal/proxy/metrics_info.go
View File

@ -187,8 +187,11 @@ func getSystemInfoMetrics(
defer wg.Done()
queryCoordResp, queryCoordErr = node.queryCoord.GetMetrics(ctx, request)
if queryCoordErr != nil {
return
}
queryCoordRoleName = queryCoordResp.GetComponentName()
queryCoordErr = metricsinfo.UnmarshalTopology(queryCoordResp.Response, &queryCoordTopology)
queryCoordErr = metricsinfo.UnmarshalTopology(queryCoordResp.GetResponse(), &queryCoordTopology)
}()
wg.Add(1)
@ -196,8 +199,11 @@ func getSystemInfoMetrics(
defer wg.Done()
dataCoordResp, dataCoordErr = node.dataCoord.GetMetrics(ctx, request)
if dataCoordErr != nil {
return
}
dataCoordRoleName = dataCoordResp.GetComponentName()
dataCoordErr = metricsinfo.UnmarshalTopology(dataCoordResp.Response, &dataCoordTopology)
dataCoordErr = metricsinfo.UnmarshalTopology(dataCoordResp.GetResponse(), &dataCoordTopology)
}()
wg.Add(1)
@ -205,8 +211,11 @@ func getSystemInfoMetrics(
defer wg.Done()
indexCoordResp, indexCoordErr = node.indexCoord.GetMetrics(ctx, request)
if indexCoordErr != nil {
return
}
indexCoordRoleName = indexCoordResp.GetComponentName()
indexCoordErr = metricsinfo.UnmarshalTopology(indexCoordResp.Response, &indexCoordTopology)
indexCoordErr = metricsinfo.UnmarshalTopology(indexCoordResp.GetResponse(), &indexCoordTopology)
}()
wg.Add(1)
@ -214,8 +223,11 @@ func getSystemInfoMetrics(
defer wg.Done()
rootCoordResp, rootCoordErr = node.rootCoord.GetMetrics(ctx, request)
if rootCoordErr != nil {
return
}
rootCoordRoleName = rootCoordResp.GetComponentName()
rootCoordErr = metricsinfo.UnmarshalTopology(rootCoordResp.Response, &rootCoordTopology)
rootCoordErr = metricsinfo.UnmarshalTopology(rootCoordResp.GetResponse(), &rootCoordTopology)
}()
wg.Wait()