From 9dbd67879f4294be2db6ac319a640ca554f4e289 Mon Sep 17 00:00:00 2001 From: Bingyi Sun Date: Wed, 20 Mar 2024 17:55:08 +0800 Subject: [PATCH] enhance: use mmap prefix to define all mmap related configs (#31436) Signed-off-by: sunby --- configs/milvus.yaml | 3 ++- pkg/util/paramtable/component_param.go | 6 ++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/configs/milvus.yaml b/configs/milvus.yaml index 0f19ee0a2f..f33e9d83d4 100644 --- a/configs/milvus.yaml +++ b/configs/milvus.yaml @@ -356,7 +356,8 @@ queryNode: taskQueueExpire: 60 # 1 min by default, expire time of inner user task queue since queue is empty. enableCrossUserGrouping: false # false by default Enable Cross user grouping when using user-task-polling policy. (close it if task of any user can not merge others). maxPendingTaskPerUser: 1024 # 50 by default, max pending task in scheduler per user. - mmapEnabled: false # enable mmap global, if set true, will use mmap to load segment data + mmap: + mmapEnabled: false # enable mmap global, if set true, will use mmap to load segment data # can specify ip for example # ip: 127.0.0.1 diff --git a/pkg/util/paramtable/component_param.go b/pkg/util/paramtable/component_param.go index 575474dcc9..23f8c49537 100644 --- a/pkg/util/paramtable/component_param.go +++ b/pkg/util/paramtable/component_param.go @@ -2205,17 +2205,19 @@ func (p *queryNodeConfig) init(base *BaseTable) { p.CacheEnabled.Init(base.mgr) p.MmapDirPath = ParamItem{ - Key: "queryNode.mmapDirPath", + Key: "queryNode.mmap.mmapDirPath", Version: "2.3.0", DefaultValue: "", + FallbackKeys: []string{"queryNode.mmapDirPath"}, Doc: "The folder that storing data files for mmap, setting to a path will enable Milvus to load data with mmap", } p.MmapDirPath.Init(base.mgr) p.MmapEnabled = ParamItem{ - Key: "queryNode.mmapEnabled", + Key: "queryNode.mmap.mmapEnabled", Version: "2.4.0", DefaultValue: "false", + FallbackKeys: []string{"queryNode.mmapEnabled"}, Doc: "Enable mmap for loading data", } p.MmapEnabled.Init(base.mgr)