milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enhance: [cherry-pick] change cp metric to absolute unix ts (#29328) (#29337) 

Cherry pick from master
pr: #29328 

See also #29327

Change channel checkpoint metrics to unix seconds instead of checkpoint
timestamp lag value

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/29350/head
congqixia 2023-12-20 15:04:42 +08:00 committed by GitHub
parent 8e13199da2
commit 9acf32a0b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
internal/datacoord/meta.go
View File

@ -1290,8 +1290,8 @@ func (m *meta) UpdateChannelCheckpoint(vChannel string, pos *msgpb.MsgPosition)
zap.Uint64("ts", pos.GetTimestamp()), zap.Uint64("ts", pos.GetTimestamp()),
zap.ByteString("msgID", pos.GetMsgID()), zap.ByteString("msgID", pos.GetMsgID()),
zap.Time("time", ts)) zap.Time("time", ts))
metrics.DataCoordCheckpointLag.WithLabelValues(fmt.Sprint(paramtable.GetNodeID()), vChannel). metrics.DataCoordCheckpointUnixSeconds.WithLabelValues(fmt.Sprint(paramtable.GetNodeID()), vChannel).
Set(float64(time.Since(ts).Milliseconds())) Set(float64(ts.Unix()))
} }
return nil return nil
} }

2
internal/datacoord/services.go
View File

@ -559,7 +559,7 @@ func (s *Server) DropVirtualChannel(ctx context.Context, req *datapb.DropVirtual
s.segmentManager.DropSegmentsOfChannel(ctx, channel) s.segmentManager.DropSegmentsOfChannel(ctx, channel)
metrics.CleanupDataCoordNumStoredRows(collectionID) metrics.CleanupDataCoordNumStoredRows(collectionID)
metrics.DataCoordCheckpointLag.DeleteLabelValues(fmt.Sprint(paramtable.GetNodeID()), channel) metrics.DataCoordCheckpointUnixSeconds.DeleteLabelValues(fmt.Sprint(paramtable.GetNodeID()), channel)
// no compaction triggered in Drop procedure // no compaction triggered in Drop procedure
return resp, nil return resp, nil

8
pkg/metrics/datacoord_metrics.go
View File

@ -100,12 +100,12 @@ var (
channelNameLabelName, channelNameLabelName,
}) })
DataCoordCheckpointLag = prometheus.NewGaugeVec( DataCoordCheckpointUnixSeconds = prometheus.NewGaugeVec(
prometheus.GaugeOpts{ prometheus.GaugeOpts{
Namespace: milvusNamespace, Namespace: milvusNamespace,
Subsystem: typeutil.DataCoordRole, Subsystem: typeutil.DataCoordRole,
Name: "channel_checkpoint_ts_lag_ms", Name: "channel_checkpoint_unix_seconds",
Help: "channel checkpoint timestamp lag in milliseconds", Help: "channel checkpoint timestamp in unix seconds",
}, []string{ }, []string{
nodeIDLabelName, nodeIDLabelName,
channelNameLabelName, channelNameLabelName,
@ -261,7 +261,7 @@ func RegisterDataCoord(registry *prometheus.Registry) {
registry.MustRegister(DataCoordNumStoredRows) registry.MustRegister(DataCoordNumStoredRows)
registry.MustRegister(DataCoordNumStoredRowsCounter) registry.MustRegister(DataCoordNumStoredRowsCounter)
registry.MustRegister(DataCoordConsumeDataNodeTimeTickLag) registry.MustRegister(DataCoordConsumeDataNodeTimeTickLag)
registry.MustRegister(DataCoordCheckpointLag) registry.MustRegister(DataCoordCheckpointUnixSeconds)
registry.MustRegister(DataCoordStoredBinlogSize) registry.MustRegister(DataCoordStoredBinlogSize)
registry.MustRegister(DataCoordSegmentBinLogFileCount) registry.MustRegister(DataCoordSegmentBinLogFileCount)
registry.MustRegister(DataCoordDmlChannelNum) registry.MustRegister(DataCoordDmlChannelNum)