From 99b7a6882c36e09ede13a1807dfb456efee0ea05 Mon Sep 17 00:00:00 2001 From: yah01 Date: Thu, 25 May 2023 21:35:27 +0800 Subject: [PATCH] Fix the nested path lost when reuse the expression (#24417) Signed-off-by: yah01 --- internal/core/src/query/visitors/ExecExprVisitor.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/internal/core/src/query/visitors/ExecExprVisitor.cpp b/internal/core/src/query/visitors/ExecExprVisitor.cpp index e1039e1c2c..b1523926e8 100644 --- a/internal/core/src/query/visitors/ExecExprVisitor.cpp +++ b/internal/core/src/query/visitors/ExecExprVisitor.cpp @@ -430,7 +430,7 @@ ExecExprVisitor::ExecUnaryRangeVisitorDispatcherJson(UnaryRangeExpr& expr_raw) auto op = expr.op_type_; auto val = expr.value_; - auto pointer = milvus::Json::pointer(std::move(expr.column_.nested_path)); + auto pointer = milvus::Json::pointer(expr.column_.nested_path); auto field_id = expr.column_.field_id; auto index_func = [=](Index* index) { return TargetBitmap{}; }; using GetType = @@ -696,7 +696,7 @@ ExecExprVisitor::ExecBinaryArithOpEvalRangeVisitorDispatcherJson( auto right_operand = expr.right_operand_; auto op = expr.op_type_; auto val = expr.value_; - auto pointer = milvus::Json::pointer(std::move(expr.column_.nested_path)); + auto pointer = milvus::Json::pointer(expr.column_.nested_path); #define BinaryArithRangeJSONCompare(cmp) \ do { \ @@ -930,7 +930,7 @@ ExecExprVisitor::ExecBinaryRangeVisitorDispatcherJson(BinaryRangeExpr& expr_raw) bool upper_inclusive = expr.upper_inclusive_; ExprValueType val1 = expr.lower_value_; ExprValueType val2 = expr.upper_value_; - auto pointer = milvus::Json::pointer(std::move(expr.column_.nested_path)); + auto pointer = milvus::Json::pointer(expr.column_.nested_path); // no json index now auto index_func = [=](Index* index) { return TargetBitmap{}; }; @@ -1742,7 +1742,7 @@ ExecExprVisitor::ExecTermVisitorImplTemplateJson(TermExpr& expr_raw) -> BitsetType { using Index = index::ScalarIndex; auto& expr = static_cast&>(expr_raw); - auto pointer = milvus::Json::pointer(std::move(expr.column_.nested_path)); + auto pointer = milvus::Json::pointer(expr.column_.nested_path); auto index_func = [=](Index* index) { return TargetBitmap{}; }; std::unordered_set term_set(expr.terms_.begin(), @@ -1852,7 +1852,7 @@ ExecExprVisitor::visit(ExistsExpr& expr) { AssertInfo(expr.column_.data_type == field_meta.get_data_type(), "[ExecExprVisitor]DataType of expr isn't field_meta data type"); BitsetType res; - auto pointer = milvus::Json::pointer(std::move(expr.column_.nested_path)); + auto pointer = milvus::Json::pointer(expr.column_.nested_path); switch (expr.column_.data_type) { case DataType::JSON: { using Index = index::ScalarIndex;