milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: [Cherry-pick] Verify PlaceHolderValue type before search (#31626) (#31653) 

Cherry-pick from master
pr: #31626
See also #31625

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
pull/31683/head
congqixia 2024-03-28 10:21:11 +08:00 committed by GitHub
parent d37e1fdd9f
commit 97c28edb04
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/core/src/query/Plan.cpp
View File

@ -45,6 +45,9 @@ ParsePlaceholderGroup(const Plan* plan,
Assert(plan->tag2field_.count(element.tag_));
auto field_id = plan->tag2field_.at(element.tag_);
auto& field_meta = plan->schema_[field_id];
AssertInfo(static_cast<int>(field_meta.get_data_type()) ==
static_cast<int>(info.type()),
"vector type must be the same");
element.num_of_queries_ = info.values_size();
AssertInfo(element.num_of_queries_ > 0, "must have queries");
if (info.type() ==

10
tests/python_client/testcases/test_search.py
View File

@ -1398,7 +1398,10 @@ class TestCollectionSearch(TestcaseBase):
def random_primary_key(self, request):
yield request.param
@pytest.fixture(scope="function", params=["FLOAT_VECTOR", "FLOAT16_VECTOR", "BFLOAT16_VECTOR"])
# skip fp16/bf16 for now, the case need to be modified
# see also https://github.com/milvus-io/milvus/issues/31625
# @pytest.fixture(scope="function", params=["FLOAT_VECTOR", "FLOAT16_VECTOR", "BFLOAT16_VECTOR"])
@pytest.fixture(scope="function", params=["FLOAT_VECTOR"])
def vector_data_type(self, request):
yield request.param
@ -10456,7 +10459,10 @@ class TestCollectionHybridSearchValid(TestcaseBase):
def random_primary_key(self, request):
yield request.param
@pytest.fixture(scope="function", params=["FLOAT_VECTOR", "FLOAT16_VECTOR", "BFLOAT16_VECTOR"])
# skip fp16/bf16 for now, the case need to be modified
# see also https://github.com/milvus-io/milvus/issues/31625
# @pytest.fixture(scope="function", params=["FLOAT_VECTOR", "FLOAT16_VECTOR", "BFLOAT16_VECTOR"])
@pytest.fixture(scope="function", params=["FLOAT_VECTOR"])
def vector_data_type(self, request):
yield request.param