milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Refine log level (#20904) 

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
pull/20914/head
zhenshan.cao 2022-12-01 20:07:15 +08:00 committed by GitHub
parent 8f449f2996
commit 9724ae5e27
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
internal/datanode/compactor.go
View File

@ -423,7 +423,7 @@ func (t *compactionTask) merge(
func (t *compactionTask) compact() (*datapb.CompactionResult, error) {
compactStart := time.Now()
if ok := funcutil.CheckCtxValid(t.ctx); !ok {
log.Error("compact wrong, task context done or timeout")
log.Warn("compact wrong, task context done or timeout")
return nil, errContext
}
@ -435,17 +435,17 @@ func (t *compactionTask) compact() (*datapb.CompactionResult, error) {
switch {
case t.plan.GetType() == datapb.CompactionType_UndefinedCompaction:
log.Error("compact wrong, compaction type undefined")
log.Warn("compact wrong, compaction type undefined")
return nil, errCompactionTypeUndifined
case len(t.plan.GetSegmentBinlogs()) < 1:
log.Error("compact wrong, there's no segments in segment binlogs")
log.Warn("compact wrong, there's no segments in segment binlogs")
return nil, errIllegalCompactionPlan
case t.plan.GetType() == datapb.CompactionType_MergeCompaction || t.plan.GetType() == datapb.CompactionType_MixCompaction:
targetSegID, err = t.allocID()
if err != nil {
log.Error("compact wrong", zap.Error(err))
log.Warn("compact wrong", zap.Error(err))
return nil, err
}
}
@ -458,7 +458,7 @@ func (t *compactionTask) compact() (*datapb.CompactionResult, error) {
_, partID, meta, err := t.getSegmentMeta(segIDs[0])
if err != nil {
log.Error("compact wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
log.Warn("compact wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
return nil, err
}
@ -587,7 +587,7 @@ func (t *compactionTask) compact() (*datapb.CompactionResult, error) {
}
// Unable to deal with all empty segments cases, so return error
if binlogNum == 0 {
log.Error("compact wrong, all segments' binlogs are empty", zap.Int64("planID", t.plan.GetPlanID()))
log.Warn("compact wrong, all segments' binlogs are empty", zap.Int64("planID", t.plan.GetPlanID()))
return nil, errIllegalCompactionPlan
}
@ -627,7 +627,7 @@ func (t *compactionTask) compact() (*datapb.CompactionResult, error) {
}()
if err != nil {
log.Error("compaction IO wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
log.Warn("compaction IO wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
return nil, err
}
@ -638,14 +638,14 @@ func (t *compactionTask) compact() (*datapb.CompactionResult, error) {
inPaths, statsPaths, numRows, err := t.merge(ctxTimeout, allPs, targetSegID, partID, meta, deltaPk2Ts)
if err != nil {
log.Error("compact wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
log.Warn("compact wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
return nil, err
}
uploadDeltaStart := time.Now()
deltaInfo, err := t.uploadDeltaLog(ctxTimeout, targetSegID, partID, deltaBuf.delData, meta)
if err != nil {
log.Error("compact wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
log.Warn("compact wrong", zap.Int64("planID", t.plan.GetPlanID()), zap.Error(err))
return nil, err
}
log.Info("upload delta log elapse in ms", zap.Int64("planID", t.plan.GetPlanID()), zap.Float64("elapse", nano2Milli(time.Since(uploadDeltaStart))))

2
internal/metastore/kv/rootcoord/kv_catalog.go
View File

@ -716,7 +716,7 @@ func (kc *Catalog) ListRole(ctx context.Context, tenant string, entity *milvuspb
roleKey := funcutil.HandleTenantForEtcdKey(RolePrefix, tenant, entity.Name)
_, err := kc.Txn.Load(roleKey)
if err != nil {
log.Error("fail to load a role", zap.String("key", roleKey), zap.Error(err))
log.Warn("fail to load a role", zap.String("key", roleKey), zap.Error(err))
return results, err
}
appendRoleResult(entity.Name)

2
internal/querynode/segment_loader.go
View File

@ -125,7 +125,7 @@ func (loader *segmentLoader) LoadSegment(ctx context.Context, req *querypb.LoadS
err := loader.checkSegmentSize(req.CollectionID, req.Infos, concurrencyLevel)
if err != nil {
log.Error("load failed, OOM if loaded",
log.Warn("load failed, OOM if loaded",
zap.Int64("loadSegmentRequest msgID", req.Base.MsgID),
zap.Error(err))
return nil, err

6
internal/util/grpcclient/client.go
View File

@ -146,7 +146,7 @@ func (c *ClientBase[T]) resetConnection(client T) {
func (c *ClientBase[T]) connect(ctx context.Context) error {
addr, err := c.getAddrFunc()
if err != nil {
log.Error("failed to get client address", zap.Error(err))
log.Warn("failed to get client address", zap.Error(err))
return err
}
@ -275,7 +275,7 @@ func (c *ClientBase[T]) Call(ctx context.Context, caller func(client T) (any, er
ret, err := c.callOnce(ctx, caller)
if err != nil {
traceErr := fmt.Errorf("err: %w\n, %s", err, trace.StackTrace())
log.Error("ClientBase Call grpc first call get error", zap.String("role", c.GetRole()), zap.Error(traceErr))
log.Warn("ClientBase Call grpc first call get error", zap.String("role", c.GetRole()), zap.Error(traceErr))
return generic.Zero[T](), traceErr
}
return ret, err
@ -302,7 +302,7 @@ func (c *ClientBase[T]) ReCall(ctx context.Context, caller func(client T) (any,
ret, err = c.callOnce(ctx, caller)
if err != nil {
traceErr = fmt.Errorf("err: %w\n, %s", err, trace.StackTrace())
log.Error("ClientBase ReCall grpc second call get error", zap.String("role", c.GetRole()), zap.Error(traceErr))
log.Warn("ClientBase ReCall grpc second call get error", zap.String("role", c.GetRole()), zap.Error(traceErr))
return generic.Zero[T](), traceErr
}
return ret, err