From 4e5b778a3d79e2fd95251ddaf03f82152342e4d4 Mon Sep 17 00:00:00 2001
From: jielinxu <52057195+jielinxu@users.noreply.github.com>
Date: Mon, 28 Oct 2019 11:19:09 +0800
Subject: [PATCH 01/13] [skip ci] Add Contributors section

Former-commit-id: 6c3a3fa7b3556bf904eee77225730f3d9a1befba
---
 README.md | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/README.md b/README.md
index f18328f748..43f117ff92 100644
--- a/README.md
+++ b/README.md
@@ -178,6 +178,13 @@ We use [GitHub issues](https://github.com/milvus-io/milvus/issues/new/choose) to
 
 To connect with other users and contributors, welcome to join our [slack channel](https://join.slack.com/t/milvusio/shared_invite/enQtNzY1OTQ0NDI3NjMzLWNmYmM1NmNjOTQ5MGI5NDhhYmRhMGU5M2NhNzhhMDMzY2MzNDdlYjM5ODQ5MmE3ODFlYzU3YjJkNmVlNDQ2ZTk). 
 
+## Contributors
+
+Deep thanks and appreciation go to the following people.
+
+- [akihoni](https://github.com/akihoni) found a broken link and a small typo in the README file.
+
+
 ## Milvus Roadmap
 
 Please read our [roadmap](https://milvus.io/docs/en/roadmap/) to learn about upcoming features.

From a10f83c69c87f72a745aafc033f291f2740badf6 Mon Sep 17 00:00:00 2001
From: jielinxu <52057195+jielinxu@users.noreply.github.com>
Date: Mon, 28 Oct 2019 17:12:51 +0800
Subject: [PATCH 02/13] [skip ci] Typo change

Former-commit-id: 0438b3ee8770228d39d0146e35b154a88381bf1f
---
 README.md | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 43f117ff92..9ff0d4a3ae 100644
--- a/README.md
+++ b/README.md
@@ -20,7 +20,7 @@
 
 ## What is Milvus
 
-Milvus is an open source similarity search engine for massive feature vectors. Designed with heterogeneous computing architecture for the best cost efficiency. Searches over billion-scale vectors take only milliseconds with minimum computing resources.
+Milvus is an open source similarity search engine for massive-scale feature vectors. Built with heterogeneous computing architecture for the best cost efficiency. Searches over billion-scale vectors take only milliseconds with minimum computing resources.
 
 Milvus provides stable Python, Java and C++ APIs.
 
@@ -28,7 +28,7 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea
 
 - Heterogeneous computing
 
-  Milvus is designed with heterogeneous computing architecture for the best performance and cost efficiency. 
+  Milvus is built with heterogeneous computing architecture for the best performance and cost efficiency. 
 
 - Multiple indexes
 
@@ -64,14 +64,14 @@ Keep up-to-date with newest releases and latest updates by reading Milvus [relea
 
 ## Get started
 
-### Hardware Requirements
+### Hardware requirements
 
 | Component | Recommended configuration           |
 | --------- | ----------------------------------- |
 | CPU       | Intel CPU Haswell or higher         |
 | GPU       | NVIDIA Pascal series or higher      |
-| Memory    | 8 GB or more (depends on data size) |
-| Storage   | SATA 3.0 SSD or higher              |
+| RAM       | 8 GB or more (depends on data size) |
+| Hard drive| SATA 3.0 SSD or higher              |
 
 ### Install using docker
 
@@ -185,7 +185,7 @@ Deep thanks and appreciation go to the following people.
 - [akihoni](https://github.com/akihoni) found a broken link and a small typo in the README file.
 
 
-## Milvus Roadmap
+## Milvus roadmap
 
 Please read our [roadmap](https://milvus.io/docs/en/roadmap/) to learn about upcoming features.
 

From baeff23c6bba1840ec9c62e1493a71e0bc53a5d0 Mon Sep 17 00:00:00 2001
From: jielinxu <52057195+jielinxu@users.noreply.github.com>
Date: Mon, 28 Oct 2019 17:32:49 +0800
Subject: [PATCH 03/13] [skip ci] minor change

Former-commit-id: 5b3a820dc9d017c5dfcb8aa60ed7d3d92d5ef114
---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 9ff0d4a3ae..3dfd95d2f4 100644
--- a/README.md
+++ b/README.md
@@ -180,7 +180,7 @@ To connect with other users and contributors, welcome to join our [slack channel
 
 ## Contributors
 
-Deep thanks and appreciation go to the following people.
+We greatly appreciate the help and contributions of the following people.
 
 - [akihoni](https://github.com/akihoni) found a broken link and a small typo in the README file.
 

From a1d5ff06df232b9fdab143cedeac02505b177272 Mon Sep 17 00:00:00 2001
From: jielinxu <52057195+jielinxu@users.noreply.github.com>
Date: Mon, 28 Oct 2019 17:48:00 +0800
Subject: [PATCH 04/13] [skip ci] minor change

Former-commit-id: 10f0bf48d869fc193e33c1065f43d11c76560594
---
 README.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index 3dfd95d2f4..5c5065442f 100644
--- a/README.md
+++ b/README.md
@@ -178,9 +178,9 @@ We use [GitHub issues](https://github.com/milvus-io/milvus/issues/new/choose) to
 
 To connect with other users and contributors, welcome to join our [slack channel](https://join.slack.com/t/milvusio/shared_invite/enQtNzY1OTQ0NDI3NjMzLWNmYmM1NmNjOTQ5MGI5NDhhYmRhMGU5M2NhNzhhMDMzY2MzNDdlYjM5ODQ5MmE3ODFlYzU3YjJkNmVlNDQ2ZTk). 
 
-## Contributors
+## Thanks
 
-We greatly appreciate the help and contributions of the following people.
+We greatly appreciate the help of the following people.
 
 - [akihoni](https://github.com/akihoni) found a broken link and a small typo in the README file.
 

From 12b7d6f5d8011ec9b60e3f6184467f11873ec9e7 Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Mon, 28 Oct 2019 20:24:13 +0800
Subject: [PATCH 05/13] #90 The server start error messages could be improved
 to enhance user experience

Former-commit-id: 746b126621cd845c2848bb850b5c2eb6d3b65a6d
---
 CHANGELOG.md                    |   1 +
 core/src/server/Config.cpp      | 134 +++++++++++++++++++++++---------
 core/src/server/DBWrapper.cpp   |  47 +++++++----
 core/unittest/db/utils.cpp      |   2 +-
 core/unittest/wrapper/utils.cpp |   2 +-
 5 files changed, 133 insertions(+), 53 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0925fa1a68..c4643c0adc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,7 @@ Please mark all change in change log and use the ticket from JIRA.
 # Milvus 0.5.1 (TODO)
 
 ## Bug
+- \#90 - The server start error messages could be improved to enhance user experience
 - \#104 - test_scheduler core dump
 
 ## Improvement
diff --git a/core/src/server/Config.cpp b/core/src/server/Config.cpp
index 7de84cbccc..b20d6c2436 100644
--- a/core/src/server/Config.cpp
+++ b/core/src/server/Config.cpp
@@ -363,7 +363,9 @@ Config::PrintAll() {
 Status
 Config::CheckServerConfigAddress(const std::string& value) {
     if (!ValidationUtil::ValidateIpAddress(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid server config address: " + value);
+        std::string msg = "Invalid server IP address: " + value
+                          + ". Possible reason: server_config.address is invalid in server_config.yaml.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -371,11 +373,15 @@ Config::CheckServerConfigAddress(const std::string& value) {
 Status
 Config::CheckServerConfigPort(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid server config port: " + value);
+        std::string msg = "Port " + value + " is not a number. "
+                          + "Possible reason: server_config.port in server_config.yaml is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int32_t port = std::stoi(value);
         if (!(port > 1024 && port < 65535)) {
-            return Status(SERVER_INVALID_ARGUMENT, "Server config port out of range (1024, 65535): " + value);
+            std::string msg = "Port " + value + " is not in range [1025, 65534]. "
+                              + "Possible reason: server_config.port in server_config.yaml is invalid.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
     return Status::OK();
@@ -385,7 +391,8 @@ Status
 Config::CheckServerConfigDeployMode(const std::string& value) {
     if (value != "single" && value != "cluster_readonly" && value != "cluster_writable") {
         return Status(SERVER_INVALID_ARGUMENT,
-                      "Invalid server config mode [single, cluster_readonly, cluster_writable]: " + value);
+                      "Error: server_config.deploy_mode in server_config.yaml is not one of "
+                      "single, cluster_readonly, and cluster_writable.");
     }
     return Status::OK();
 }
@@ -411,7 +418,8 @@ Config::CheckServerConfigTimeZone(const std::string& value) {
 Status
 Config::CheckDBConfigPrimaryPath(const std::string& value) {
     if (value.empty()) {
-        return Status(SERVER_INVALID_ARGUMENT, "DB config primary_path empty");
+        return Status(SERVER_INVALID_ARGUMENT,
+                      "db_path is empty. Possible reason: db_config.db_path in server_config.yaml is empty.");
     }
     return Status::OK();
 }
@@ -424,7 +432,11 @@ Config::CheckDBConfigSecondaryPath(const std::string& value) {
 Status
 Config::CheckDBConfigBackendUrl(const std::string& value) {
     if (!ValidationUtil::ValidateDbURI(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid DB config backend_url: " + value);
+        std::string msg =
+            "Invalid db_backend_url: " + value
+            + ". Possible reason: db_config.db_backend_url is invalid in server_config.yaml. "
+            + "The correct format should be like sqlite://:@:/ or mysql://root:123456@127.0.0.1:3306/milvus.";
+        return Status(SERVER_INVALID_ARGUMENT, "invalid db_backend_url: " + value);
     }
     return Status::OK();
 }
@@ -432,7 +444,9 @@ Config::CheckDBConfigBackendUrl(const std::string& value) {
 Status
 Config::CheckDBConfigArchiveDiskThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid DB config archive_disk_threshold: " + value);
+        std::string msg = "Invalid archive disk threshold: " + value
+                          + "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -440,7 +454,9 @@ Config::CheckDBConfigArchiveDiskThreshold(const std::string& value) {
 Status
 Config::CheckDBConfigArchiveDaysThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid DB config archive_days_threshold: " + value);
+        std::string msg = "Invalid archive days threshold: " + value
+                          + "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -448,13 +464,17 @@ Config::CheckDBConfigArchiveDaysThreshold(const std::string& value) {
 Status
 Config::CheckDBConfigInsertBufferSize(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid DB config insert_buffer_size: " + value);
+        std::string msg = "Invalid insert buffer size: " + value
+                          + "Possible reason: db_config.insert_buffer_size in server_config.yaml is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int64_t buffer_size = std::stoi(value) * GB;
         uint64_t total_mem = 0, free_mem = 0;
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
         if (buffer_size >= total_mem) {
-            return Status(SERVER_INVALID_ARGUMENT, "DB config insert_buffer_size exceed system memory: " + value);
+            std::string msg = "Invalid insert buffer size: " + value
+                              + "Possible reason: insert buffer size exceed system memory.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
     return Status::OK();
@@ -463,7 +483,9 @@ Config::CheckDBConfigInsertBufferSize(const std::string& value) {
 Status
 Config::CheckMetricConfigEnableMonitor(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsBool(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid metric config auto_bootup: " + value);
+        std::string msg = "Invalid metric config: " + value
+                          + "Possible reason: metric_config.enable_monitor is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -471,7 +493,9 @@ Config::CheckMetricConfigEnableMonitor(const std::string& value) {
 Status
 Config::CheckMetricConfigCollector(const std::string& value) {
     if (value != "prometheus") {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid metric config collector: " + value);
+        std::string msg = "Invalid metric config: " + value
+                          + "Possible reason: metric_config.collector is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -479,6 +503,8 @@ Config::CheckMetricConfigCollector(const std::string& value) {
 Status
 Config::CheckMetricConfigPrometheusPort(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
+        std::string msg = "Invalid metric config: " + value
+                          + "Possible reason: metric_config.prometheus_config.port is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, "Invalid metric config prometheus_port: " + value);
     }
     return Status::OK();
@@ -487,15 +513,19 @@ Config::CheckMetricConfigPrometheusPort(const std::string& value) {
 Status
 Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid cache config cpu_cache_capacity: " + value);
+        std::string msg = "Invalid cpu cache capacity: " + value
+                          + "Possible reason: cache_config.cpu_cache_capacity is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         uint64_t cpu_cache_capacity = std::stoi(value) * GB;
         uint64_t total_mem = 0, free_mem = 0;
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
         if (cpu_cache_capacity >= total_mem) {
-            return Status(SERVER_INVALID_ARGUMENT, "Cache config cpu_cache_capacity exceed system memory: " + value);
+            std::string msg = "Invalid cpu cache capacity: " + value
+                              + "Possible reason: Cache config cpu_cache_capacity exceed system memory.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         } else if (cpu_cache_capacity > static_cast<double>(total_mem * 0.9)) {
-            std::cerr << "Warning: cpu_cache_capacity value is too big" << std::endl;
+            std::cerr << "WARNING: cpu cache capacity value is too big" << std::endl;
         }
 
         int32_t buffer_value;
@@ -506,7 +536,10 @@ Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
 
         int64_t insert_buffer_size = buffer_value * GB;
         if (insert_buffer_size + cpu_cache_capacity >= total_mem) {
-            return Status(SERVER_INVALID_ARGUMENT, "Sum of cpu_cache_capacity and buffer_size exceed system memory");
+            std::string msg = "Invalid cpu cache capacity: " + value
+                              + "Possible reason: sum of cache_config.cpu_cache_capacity and "
+                                "db_config.insert_buffer_size exceeds system memory.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
     return Status::OK();
@@ -515,11 +548,15 @@ Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
 Status
 Config::CheckCacheConfigCpuCacheThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsFloat(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid cache config cpu_cache_threshold: " + value);
+        std::string msg = "Invalid cpu cache threshold: " + value
+                          + "Possible reason: cache_config.cpu_cache_threshold is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         float cpu_cache_threshold = std::stof(value);
         if (cpu_cache_threshold <= 0.0 || cpu_cache_threshold >= 1.0) {
-            return Status(SERVER_INVALID_ARGUMENT, "Invalid cache config cpu_cache_threshold: " + value);
+            std::string msg = "Invalid cpu cache threshold: " + value
+                              + "Possible reason: cache_config.cpu_cache_threshold is invalid.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
     return Status::OK();
@@ -528,7 +565,9 @@ Config::CheckCacheConfigCpuCacheThreshold(const std::string& value) {
 Status
 Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid cache config gpu_cache_capacity: " + value);
+        std::string msg = "Invalid gpu cache capacity: " + value
+                          + "Possible reason: cache_config.gpu_cache_capacity is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         uint64_t gpu_cache_capacity = std::stoi(value) * GB;
         int gpu_index;
@@ -539,13 +578,14 @@ Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
 
         size_t gpu_memory;
         if (!ValidationUtil::GetGpuMemory(gpu_index, gpu_memory).ok()) {
-            return Status(SERVER_UNEXPECTED_ERROR,
-                          "Fail to get GPU memory for GPU device: " + std::to_string(gpu_index));
+            std::string msg = "Fail to get GPU memory for GPU device: " + std::to_string(gpu_index);
+            return Status(SERVER_UNEXPECTED_ERROR, msg);
         } else if (gpu_cache_capacity >= gpu_memory) {
-            return Status(SERVER_INVALID_ARGUMENT,
-                          "Cache config gpu_cache_capacity exceed GPU memory: " + std::to_string(gpu_memory));
+            std::string msg = "Invalid gpu cache capacity: " + value
+                              + "Possible reason: cache_config.gpu_cache_capacity exceed GPU memory.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         } else if (gpu_cache_capacity > (double)gpu_memory * 0.9) {
-            std::cerr << "Warning: gpu_cache_capacity value is too big" << std::endl;
+            std::cerr << "Warning: gpu cache capacity value is too big" << std::endl;
         }
     }
     return Status::OK();
@@ -554,11 +594,15 @@ Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
 Status
 Config::CheckCacheConfigGpuCacheThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsFloat(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid cache config gpu_cache_threshold: " + value);
+        std::string msg = "Invalid gpu cache threshold: " + value
+                          + "Possible reason: cache_config.gpu_cache_threshold is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         float gpu_cache_threshold = std::stof(value);
         if (gpu_cache_threshold <= 0.0 || gpu_cache_threshold >= 1.0) {
-            return Status(SERVER_INVALID_ARGUMENT, "Invalid cache config gpu_cache_threshold: " + value);
+            std::string msg = "Invalid gpu cache threshold: " + value
+                              + "Possible reason: cache_config.gpu_cache_threshold is invalid.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
     return Status::OK();
@@ -567,7 +611,9 @@ Config::CheckCacheConfigGpuCacheThreshold(const std::string& value) {
 Status
 Config::CheckCacheConfigCacheInsertData(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsBool(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid cache config cache_insert_data: " + value);
+        std::string msg = "Invalid cache insert option: " + value
+                          + "Possible reason: cache_config.cache_insert_data is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -575,7 +621,9 @@ Config::CheckCacheConfigCacheInsertData(const std::string& value) {
 Status
 Config::CheckEngineConfigUseBlasThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid engine config use_blas_threshold: " + value);
+        std::string msg = "Invalid blas threshold: " + value
+                          + "Possible reason: engine_config.use_blas_threshold is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -583,14 +631,18 @@ Config::CheckEngineConfigUseBlasThreshold(const std::string& value) {
 Status
 Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid engine config omp_thread_num: " + value);
+        std::string msg = "Invalid omp thread number: " + value
+                          + "Possible reason: engine_config.omp_thread_num is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
     int32_t omp_thread = std::stoi(value);
     uint32_t sys_thread_cnt = 8;
     CommonUtil::GetSystemAvailableThreads(sys_thread_cnt);
     if (omp_thread > static_cast<int32_t>(sys_thread_cnt)) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid engine config omp_thread_num: " + value);
+        std::string msg = "Invalid omp thread number: " + value
+                          + "Possible reason: engine_config.omp_thread_num is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -598,7 +650,9 @@ Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
 Status
 Config::CheckResourceConfigMode(const std::string& value) {
     if (value != "simple") {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid resource config mode: " + value);
+        std::string msg = "Invalid resource mode: " + value
+                          + "Possible reason: resource_config.mode is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -608,12 +662,16 @@ CheckGpuDevice(const std::string& value) {
     const std::regex pat("gpu(\\d+)");
     std::cmatch m;
     if (!std::regex_match(value.c_str(), m, pat)) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid gpu device: " + value);
+        std::string msg = "Invalid gpu device: " + value
+                          + "Possible reason: resource_config.search_resources is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
     int32_t gpu_index = std::stoi(value.substr(3));
     if (!ValidationUtil::ValidateGpuIndex(gpu_index).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid gpu device: " + value);
+        std::string msg = "Invalid gpu device: " + value
+                          + "Possible reason: resource_config.search_resources is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
@@ -621,11 +679,15 @@ CheckGpuDevice(const std::string& value) {
 Status
 Config::CheckResourceConfigSearchResources(const std::vector<std::string>& value) {
     if (value.empty()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Empty resource config search_resources");
+        std::string msg = "Invalid search resource. "
+                          "Possible reason: resource_config.search_resources is empty.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
     for (auto& gpu_device : value) {
         if (!CheckGpuDevice(gpu_device).ok()) {
+            std::string msg = "Invalid search resource: " + gpu_device
+                              + "Possible reason: resource_config.search_resources is invalid.";
             return Status(SERVER_INVALID_ARGUMENT, "Invalid resource config search_resources: " + gpu_device);
         }
     }
@@ -635,7 +697,9 @@ Config::CheckResourceConfigSearchResources(const std::vector<std::string>& value
 Status
 Config::CheckResourceConfigIndexBuildDevice(const std::string& value) {
     if (!CheckGpuDevice(value).ok()) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid resource config index_build_device: " + value);
+        std::string msg = "Invalid index build device: " + value
+                          + "Possible reason: resource_config.index_build_device is invalid.";
+        return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
 }
diff --git a/core/src/server/DBWrapper.cpp b/core/src/server/DBWrapper.cpp
index a5b892ad47..2217b29e1c 100644
--- a/core/src/server/DBWrapper.cpp
+++ b/core/src/server/DBWrapper.cpp
@@ -54,7 +54,8 @@ DBWrapper::StartService() {
     std::string db_slave_path;
     s = config.GetDBConfigSecondaryPath(db_slave_path);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     StringHelpFunctions::SplitStringByDelimeter(db_slave_path, ";", opt.meta_.slave_paths_);
@@ -62,13 +63,15 @@ DBWrapper::StartService() {
     // cache config
     s = config.GetCacheConfigCacheInsertData(opt.insert_cache_immediately_);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     std::string mode;
     s = config.GetServerConfigDeployMode(mode);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     if (mode == "single") {
@@ -78,7 +81,8 @@ DBWrapper::StartService() {
     } else if (mode == "cluster_writable") {
         opt.mode_ = engine::DBOptions::MODE::CLUSTER_WRITABLE;
     } else {
-        std::cerr << "ERROR: mode specified in server_config must be ['single', 'cluster_readonly', 'cluster_writable']"
+        std::cerr << "Error: server_config.deploy_mode in server_config.yaml is not one of "
+                  << "single, cluster_readonly, and cluster_writable."
                   << std::endl;
         kill(0, SIGUSR1);
     }
@@ -87,7 +91,8 @@ DBWrapper::StartService() {
     int32_t omp_thread;
     s = config.GetEngineConfigOmpThreadNum(omp_thread);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     if (omp_thread > 0) {
@@ -105,7 +110,8 @@ DBWrapper::StartService() {
     int32_t use_blas_threshold;
     s = config.GetEngineConfigUseBlasThreshold(use_blas_threshold);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     faiss::distance_compute_blas_threshold = use_blas_threshold;
@@ -115,7 +121,8 @@ DBWrapper::StartService() {
     int32_t disk, days;
     s = config.GetDBConfigArchiveDiskThreshold(disk);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     if (disk > 0) {
@@ -124,7 +131,8 @@ DBWrapper::StartService() {
 
     s = config.GetDBConfigArchiveDaysThreshold(days);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     if (days > 0) {
@@ -133,16 +141,20 @@ DBWrapper::StartService() {
     opt.meta_.archive_conf_.SetCriterias(criterial);
 
     // create db root folder
-    Status status = CommonUtil::CreateDirectory(opt.meta_.path_);
-    if (!status.ok()) {
-        std::cerr << "ERROR! Failed to create database root path: " << opt.meta_.path_ << std::endl;
+    s = CommonUtil::CreateDirectory(opt.meta_.path_);
+    if (!s.ok()) {
+        std::cerr << "Error: Failed to create database primary path: " << path
+                  << ". Possible reason: db_config.primary_path is wrong in server_config.yaml or not available."
+                  << std::endl;
         kill(0, SIGUSR1);
     }
 
     for (auto& path : opt.meta_.slave_paths_) {
-        status = CommonUtil::CreateDirectory(path);
-        if (!status.ok()) {
-            std::cerr << "ERROR! Failed to create database slave path: " << path << std::endl;
+        s = CommonUtil::CreateDirectory(path);
+        if (!s.ok()) {
+            std::cerr << "Error: Failed to create database secondary path: " << path
+                      << ". Possible reason: db_config.secondary_path is wrong in server_config.yaml or not available."
+                      << std::endl;
             kill(0, SIGUSR1);
         }
     }
@@ -151,7 +163,9 @@ DBWrapper::StartService() {
     try {
         db_ = engine::DBFactory::Build(opt);
     } catch (std::exception& ex) {
-        std::cerr << "ERROR! Failed to open database: " << ex.what() << std::endl;
+        std::cerr << "Error: failed to open database: " << ex.what()
+                << ". Possible reason: the meta system does not work."
+                << std::endl;
         kill(0, SIGUSR1);
     }
 
@@ -161,7 +175,8 @@ DBWrapper::StartService() {
     std::string preload_tables;
     s = config.GetDBConfigPreloadTable(preload_tables);
     if (!s.ok()) {
-        return s;
+        std::cerr << s.ToString() << std::endl;
+        kill(0, SIGUSR1);
     }
 
     s = PreloadTables(preload_tables);
diff --git a/core/unittest/db/utils.cpp b/core/unittest/db/utils.cpp
index 8903ce14ea..7cc2f28745 100644
--- a/core/unittest/db/utils.cpp
+++ b/core/unittest/db/utils.cpp
@@ -68,7 +68,7 @@ static const char
                    "  blas_threshold: 20\n"
                    "\n"
                    "resource_config:\n"
-                   "  resource_pool:\n"
+                   "  search_resources:\n"
                    "    - gpu0\n"
                    "  index_build_device: gpu0          # GPU used for building index";
 
diff --git a/core/unittest/wrapper/utils.cpp b/core/unittest/wrapper/utils.cpp
index 6204ac0c05..b397a35d7c 100644
--- a/core/unittest/wrapper/utils.cpp
+++ b/core/unittest/wrapper/utils.cpp
@@ -58,7 +58,7 @@ static const char
                    "  blas_threshold: 20\n"
                    "\n"
                    "resource_config:\n"
-                   "  resource_pool:\n"
+                   "  search_resources:\n"
                    "    - gpu0\n"
                    "  index_build_device: gpu0          # GPU used for building index";
 

From d109a3778c4849548298921833390acc18a1b680 Mon Sep 17 00:00:00 2001
From: jielinxu <52057195+jielinxu@users.noreply.github.com>
Date: Tue, 29 Oct 2019 09:32:36 +0800
Subject: [PATCH 06/13] [skip ci] Move Roadmap section ahead

Former-commit-id: c2a065f0192c4bc6ab948d8c4c972847bfcb771b
---
 README.md | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/README.md b/README.md
index 5c5065442f..884ddb01ca 100644
--- a/README.md
+++ b/README.md
@@ -168,6 +168,10 @@ Make sure Java 8 or higher is already installed.
 
 Refer to [this link](https://github.com/milvus-io/milvus-sdk-java/tree/master/examples) for the example code.
 
+## Milvus roadmap
+
+Please read our [roadmap](https://milvus.io/docs/en/roadmap/) to learn about upcoming features.
+
 ## Contribution guidelines
 
 Contributions are welcomed and greatly appreciated. Please read our [contribution guidelines](CONTRIBUTING.md) for detailed contribution workflow. This project adheres to the [code of conduct](CODE_OF_CONDUCT.md) of Milvus. By participating, you are expected to uphold this code.
@@ -184,11 +188,6 @@ We greatly appreciate the help of the following people.
 
 - [akihoni](https://github.com/akihoni) found a broken link and a small typo in the README file.
 
-
-## Milvus roadmap
-
-Please read our [roadmap](https://milvus.io/docs/en/roadmap/) to learn about upcoming features.
-
 ## Resources
 
 [Milvus official website](https://www.milvus.io)
@@ -203,7 +202,6 @@ Please read our [roadmap](https://milvus.io/docs/en/roadmap/) to learn about upc
 
 [Milvus roadmap](https://milvus.io/docs/en/roadmap/)
 
-
 ## License
 
 [Apache License 2.0](LICENSE)

From a78e928dfaa389d2c6b02ae1dc7cc60bc0a712f0 Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Tue, 29 Oct 2019 15:16:04 +0800
Subject: [PATCH 07/13] #90 The server start error messages could be improved
 to enhance user experience

Former-commit-id: e3ad89ab67f2c46bc4cb4e6d094a7763fb098664
---
 core/conf/server_config.template |  20 ++---
 core/src/server/Config.cpp       | 145 +++++++++++++++++--------------
 core/src/server/DBWrapper.cpp    |   6 +-
 3 files changed, 91 insertions(+), 80 deletions(-)

diff --git a/core/conf/server_config.template b/core/conf/server_config.template
index 7abfb8b055..3b366f1bd4 100644
--- a/core/conf/server_config.template
+++ b/core/conf/server_config.template
@@ -4,7 +4,7 @@ server_config:
   address: 0.0.0.0                  # milvus server ip address (IPv4)
   port: 19530                       # port range: 1025 ~ 65534
   deploy_mode: single               # deployment type: single, cluster_readonly, cluster_writable
-  time_zone: UTC+8
+  time_zone: UTC+8                  # time zone, must be in format: UTC+X
 
 db_config:
   primary_path: @MILVUS_DB_PATH@    # path used to store data and meta
@@ -14,30 +14,30 @@ db_config:
                                     # Keep 'dialect://:@:/', and replace other texts with real values
                                     # Replace 'dialect' with 'mysql' or 'sqlite'
 
-  insert_buffer_size: 4             # GB, maximum insert buffer size allowed
+  insert_buffer_size: 4             # GB, maximum insert buffer size allowed, must be a positive integer
                                     # sum of insert_buffer_size and cpu_cache_capacity cannot exceed total memory
 
   preload_table:                    # preload data at startup, '*' means load all tables, empty value means no preload
                                     # you can specify preload tables like this: table1,table2,table3
 
 metric_config:
-  enable_monitor: false             # enable monitoring or not
+  enable_monitor: false             # enable monitoring or not, must be a boolean
   collector: prometheus             # prometheus
   prometheus_config:
-    port: 8080                      # port prometheus uses to fetch metrics
+    port: 8080                      # port prometheus uses to fetch metrics, range: 1025 ~ 65534
 
 cache_config:
-  cpu_cache_capacity: 16            # GB, CPU memory used for cache
-  cpu_cache_threshold: 0.85         # percentage of data that will be kept when cache cleanup is triggered
-  gpu_cache_capacity: 4             # GB, GPU memory used for cache
-  gpu_cache_threshold: 0.85         # percentage of data that will be kept when cache cleanup is triggered
-  cache_insert_data: false          # whether to load inserted data into cache
+  cpu_cache_capacity: 16            # GB, CPU memory used for cache, must be a positive integer
+  cpu_cache_threshold: 0.85         # percentage of data that will be kept when cache cleanup is triggered, must be in range (0.0, 1.0]
+  gpu_cache_capacity: 4             # GB, GPU memory used for cache, must be a positive integer
+  gpu_cache_threshold: 0.85         # percentage of data that will be kept when cache cleanup is triggered, must be in range (0.0, 1.0]
+  cache_insert_data: false          # whether to load inserted data into cache, must be a boolean
 
 engine_config:
   use_blas_threshold: 20            # if nq <  use_blas_threshold, use SSE, faster with fluctuated response times
                                     # if nq >= use_blas_threshold, use OpenBlas, slower with stable response times
 
 resource_config:
-  search_resources:                 # define the GPUs used for search computation, valid value: gpux
+  search_resources:                 # define the GPUs used for search computation, must be in format: gpux
     - gpu0
   index_build_device: gpu0          # GPU used for building index
\ No newline at end of file
diff --git a/core/src/server/Config.cpp b/core/src/server/Config.cpp
index b20d6c2436..51449cb1de 100644
--- a/core/src/server/Config.cpp
+++ b/core/src/server/Config.cpp
@@ -363,8 +363,8 @@ Config::PrintAll() {
 Status
 Config::CheckServerConfigAddress(const std::string& value) {
     if (!ValidationUtil::ValidateIpAddress(value).ok()) {
-        std::string msg = "Invalid server IP address: " + value
-                          + ". Possible reason: server_config.address is invalid in server_config.yaml.";
+        std::string msg = "Invalid server IP address: " + value +
+                          ". Possible reason: server_config.address is invalid in server_config.yaml.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -373,14 +373,14 @@ Config::CheckServerConfigAddress(const std::string& value) {
 Status
 Config::CheckServerConfigPort(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Port " + value + " is not a number. "
-                          + "Possible reason: server_config.port in server_config.yaml is invalid.";
+        std::string msg = "Port " + value + " is not a number. " +
+                          "Possible reason: server_config.port in server_config.yaml is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int32_t port = std::stoi(value);
         if (!(port > 1024 && port < 65535)) {
-            std::string msg = "Port " + value + " is not in range [1025, 65534]. "
-                              + "Possible reason: server_config.port in server_config.yaml is invalid.";
+            std::string msg = "Port " + value + " is not in range [1025, 65534]. " +
+                              "Possible reason: server_config.port in server_config.yaml is invalid.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -433,9 +433,9 @@ Status
 Config::CheckDBConfigBackendUrl(const std::string& value) {
     if (!ValidationUtil::ValidateDbURI(value).ok()) {
         std::string msg =
-            "Invalid db_backend_url: " + value
-            + ". Possible reason: db_config.db_backend_url is invalid in server_config.yaml. "
-            + "The correct format should be like sqlite://:@:/ or mysql://root:123456@127.0.0.1:3306/milvus.";
+            "Invalid db_backend_url: " + value +
+            ". Possible reason: db_config.db_backend_url is invalid in server_config.yaml. " +
+            "The correct format should be like sqlite://:@:/ or mysql://root:123456@127.0.0.1:3306/milvus.";
         return Status(SERVER_INVALID_ARGUMENT, "invalid db_backend_url: " + value);
     }
     return Status::OK();
@@ -444,8 +444,8 @@ Config::CheckDBConfigBackendUrl(const std::string& value) {
 Status
 Config::CheckDBConfigArchiveDiskThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid archive disk threshold: " + value
-                          + "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
+        std::string msg = "Invalid archive disk threshold: " + value +
+                          "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -454,8 +454,8 @@ Config::CheckDBConfigArchiveDiskThreshold(const std::string& value) {
 Status
 Config::CheckDBConfigArchiveDaysThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid archive days threshold: " + value
-                          + "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
+        std::string msg = "Invalid archive days threshold: " + value +
+                          "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -464,16 +464,24 @@ Config::CheckDBConfigArchiveDaysThreshold(const std::string& value) {
 Status
 Config::CheckDBConfigInsertBufferSize(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid insert buffer size: " + value
-                          + "Possible reason: db_config.insert_buffer_size in server_config.yaml is invalid.";
+        std::string msg = "Invalid insert buffer size: " + value +
+                          "Possible reason: db_config.insert_buffer_size in server_config.yaml "
+                          "is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int64_t buffer_size = std::stoi(value) * GB;
+        if (buffer_size <= 0) {
+            std::string msg = "Invalid insert buffer size: " + value +
+                              "Possible reason: db_config.insert_buffer_size in server_config.yaml "
+                              "is not a positive integer.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
+        }
+
         uint64_t total_mem = 0, free_mem = 0;
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
         if (buffer_size >= total_mem) {
-            std::string msg = "Invalid insert buffer size: " + value
-                              + "Possible reason: insert buffer size exceed system memory.";
+            std::string msg =
+                "Invalid insert buffer size: " + value + "Possible reason: insert buffer size exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -483,8 +491,8 @@ Config::CheckDBConfigInsertBufferSize(const std::string& value) {
 Status
 Config::CheckMetricConfigEnableMonitor(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsBool(value).ok()) {
-        std::string msg = "Invalid metric config: " + value
-                          + "Possible reason: metric_config.enable_monitor is invalid.";
+        std::string msg =
+            "Invalid metric config: " + value + "Possible reason: metric_config.enable_monitor is not a boolean.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -493,8 +501,7 @@ Config::CheckMetricConfigEnableMonitor(const std::string& value) {
 Status
 Config::CheckMetricConfigCollector(const std::string& value) {
     if (value != "prometheus") {
-        std::string msg = "Invalid metric config: " + value
-                          + "Possible reason: metric_config.collector is invalid.";
+        std::string msg = "Invalid metric config: " + value + "Possible reason: metric_config.collector is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -503,8 +510,8 @@ Config::CheckMetricConfigCollector(const std::string& value) {
 Status
 Config::CheckMetricConfigPrometheusPort(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid metric config: " + value
-                          + "Possible reason: metric_config.prometheus_config.port is invalid.";
+        std::string msg = "Invalid metric config: " + value +
+                          "Possible reason: metric_config.prometheus_config.port is not in range [1025, 65534].";
         return Status(SERVER_INVALID_ARGUMENT, "Invalid metric config prometheus_port: " + value);
     }
     return Status::OK();
@@ -513,18 +520,24 @@ Config::CheckMetricConfigPrometheusPort(const std::string& value) {
 Status
 Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid cpu cache capacity: " + value
-                          + "Possible reason: cache_config.cpu_cache_capacity is invalid.";
+        std::string msg = "Invalid cpu cache capacity: " + value +
+                          "Possible reason: cache_config.cpu_cache_capacity is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
-        uint64_t cpu_cache_capacity = std::stoi(value) * GB;
+        int64_t cpu_cache_capacity = std::stoi(value) * GB;
+        if (cpu_cache_capacity <= 0) {
+            std::string msg = "Invalid cpu cache capacity: " + value +
+                              "Possible reason: cache_config.cpu_cache_capacity is not a positive integer.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
+        }
+
         uint64_t total_mem = 0, free_mem = 0;
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
-        if (cpu_cache_capacity >= total_mem) {
-            std::string msg = "Invalid cpu cache capacity: " + value
-                              + "Possible reason: Cache config cpu_cache_capacity exceed system memory.";
+        if (static_cast<uint64_t>(cpu_cache_capacity) >= total_mem) {
+            std::string msg = "Invalid cpu cache capacity: " + value +
+                              "Possible reason: Cache config cpu_cache_capacity exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
-        } else if (cpu_cache_capacity > static_cast<double>(total_mem * 0.9)) {
+        } else if (static_cast<double>(cpu_cache_capacity) > static_cast<double>(total_mem * 0.9)) {
             std::cerr << "WARNING: cpu cache capacity value is too big" << std::endl;
         }
 
@@ -536,9 +549,9 @@ Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
 
         int64_t insert_buffer_size = buffer_value * GB;
         if (insert_buffer_size + cpu_cache_capacity >= total_mem) {
-            std::string msg = "Invalid cpu cache capacity: " + value
-                              + "Possible reason: sum of cache_config.cpu_cache_capacity and "
-                                "db_config.insert_buffer_size exceeds system memory.";
+            std::string msg = "Invalid cpu cache capacity: " + value +
+                              "Possible reason: sum of cache_config.cpu_cache_capacity and "
+                              "db_config.insert_buffer_size exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -548,14 +561,14 @@ Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
 Status
 Config::CheckCacheConfigCpuCacheThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsFloat(value).ok()) {
-        std::string msg = "Invalid cpu cache threshold: " + value
-                          + "Possible reason: cache_config.cpu_cache_threshold is invalid.";
+        std::string msg = "Invalid cpu cache threshold: " + value +
+                          "Possible reason: cache_config.cpu_cache_threshold is not in range (0.0, 1.0].";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         float cpu_cache_threshold = std::stof(value);
         if (cpu_cache_threshold <= 0.0 || cpu_cache_threshold >= 1.0) {
-            std::string msg = "Invalid cpu cache threshold: " + value
-                              + "Possible reason: cache_config.cpu_cache_threshold is invalid.";
+            std::string msg = "Invalid cpu cache threshold: " + value +
+                              "Possible reason: cache_config.cpu_cache_threshold is not in range (0.0, 1.0].";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -565,8 +578,8 @@ Config::CheckCacheConfigCpuCacheThreshold(const std::string& value) {
 Status
 Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid gpu cache capacity: " + value
-                          + "Possible reason: cache_config.gpu_cache_capacity is invalid.";
+        std::string msg = "Invalid gpu cache capacity: " + value +
+                          "Possible reason: cache_config.gpu_cache_capacity is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         uint64_t gpu_cache_capacity = std::stoi(value) * GB;
@@ -581,8 +594,8 @@ Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
             std::string msg = "Fail to get GPU memory for GPU device: " + std::to_string(gpu_index);
             return Status(SERVER_UNEXPECTED_ERROR, msg);
         } else if (gpu_cache_capacity >= gpu_memory) {
-            std::string msg = "Invalid gpu cache capacity: " + value
-                              + "Possible reason: cache_config.gpu_cache_capacity exceed GPU memory.";
+            std::string msg = "Invalid gpu cache capacity: " + value +
+                              "Possible reason: cache_config.gpu_cache_capacity exceeds GPU memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         } else if (gpu_cache_capacity > (double)gpu_memory * 0.9) {
             std::cerr << "Warning: gpu cache capacity value is too big" << std::endl;
@@ -594,14 +607,14 @@ Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
 Status
 Config::CheckCacheConfigGpuCacheThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsFloat(value).ok()) {
-        std::string msg = "Invalid gpu cache threshold: " + value
-                          + "Possible reason: cache_config.gpu_cache_threshold is invalid.";
+        std::string msg = "Invalid gpu cache threshold: " + value +
+                          "Possible reason: cache_config.gpu_cache_threshold is not in range (0.0, 1.0].";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         float gpu_cache_threshold = std::stof(value);
         if (gpu_cache_threshold <= 0.0 || gpu_cache_threshold >= 1.0) {
-            std::string msg = "Invalid gpu cache threshold: " + value
-                              + "Possible reason: cache_config.gpu_cache_threshold is invalid.";
+            std::string msg = "Invalid gpu cache threshold: " + value +
+                              "Possible reason: cache_config.gpu_cache_threshold is not in range (0.0, 1.0].";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -611,8 +624,8 @@ Config::CheckCacheConfigGpuCacheThreshold(const std::string& value) {
 Status
 Config::CheckCacheConfigCacheInsertData(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsBool(value).ok()) {
-        std::string msg = "Invalid cache insert option: " + value
-                          + "Possible reason: cache_config.cache_insert_data is invalid.";
+        std::string msg = "Invalid cache insert option: " + value +
+                          "Possible reason: cache_config.cache_insert_data is not a boolean.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -621,8 +634,8 @@ Config::CheckCacheConfigCacheInsertData(const std::string& value) {
 Status
 Config::CheckEngineConfigUseBlasThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid blas threshold: " + value
-                          + "Possible reason: engine_config.use_blas_threshold is invalid.";
+        std::string msg = "Invalid blas threshold: " + value +
+                          "Possible reason: engine_config.use_blas_threshold is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -631,8 +644,8 @@ Config::CheckEngineConfigUseBlasThreshold(const std::string& value) {
 Status
 Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid omp thread number: " + value
-                          + "Possible reason: engine_config.omp_thread_num is invalid.";
+        std::string msg = "Invalid omp thread number: " + value +
+                          "Possible reason: engine_config.omp_thread_num is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
@@ -640,8 +653,8 @@ Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
     uint32_t sys_thread_cnt = 8;
     CommonUtil::GetSystemAvailableThreads(sys_thread_cnt);
     if (omp_thread > static_cast<int32_t>(sys_thread_cnt)) {
-        std::string msg = "Invalid omp thread number: " + value
-                          + "Possible reason: engine_config.omp_thread_num is invalid.";
+        std::string msg = "Invalid omp thread number: " + value +
+                          "Possible reason: engine_config.omp_thread_num exceeds system cpu cores.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -650,8 +663,7 @@ Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
 Status
 Config::CheckResourceConfigMode(const std::string& value) {
     if (value != "simple") {
-        std::string msg = "Invalid resource mode: " + value
-                          + "Possible reason: resource_config.mode is invalid.";
+        std::string msg = "Invalid resource mode: " + value + "Possible reason: resource_config.mode is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -662,15 +674,15 @@ CheckGpuDevice(const std::string& value) {
     const std::regex pat("gpu(\\d+)");
     std::cmatch m;
     if (!std::regex_match(value.c_str(), m, pat)) {
-        std::string msg = "Invalid gpu device: " + value
-                          + "Possible reason: resource_config.search_resources is invalid.";
+        std::string msg = "Invalid gpu device: " + value +
+                          "Possible reason: resource_config.search_resources does not match your hardware.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
     int32_t gpu_index = std::stoi(value.substr(3));
     if (!ValidationUtil::ValidateGpuIndex(gpu_index).ok()) {
-        std::string msg = "Invalid gpu device: " + value
-                          + "Possible reason: resource_config.search_resources is invalid.";
+        std::string msg = "Invalid gpu device: " + value +
+                          "Possible reason: resource_config.search_resources does not match your hardware.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -679,16 +691,17 @@ CheckGpuDevice(const std::string& value) {
 Status
 Config::CheckResourceConfigSearchResources(const std::vector<std::string>& value) {
     if (value.empty()) {
-        std::string msg = "Invalid search resource. "
-                          "Possible reason: resource_config.search_resources is empty.";
+        std::string msg =
+            "Invalid search resource. "
+            "Possible reason: resource_config.search_resources is empty.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
     for (auto& gpu_device : value) {
         if (!CheckGpuDevice(gpu_device).ok()) {
-            std::string msg = "Invalid search resource: " + gpu_device
-                              + "Possible reason: resource_config.search_resources is invalid.";
-            return Status(SERVER_INVALID_ARGUMENT, "Invalid resource config search_resources: " + gpu_device);
+            std::string msg = "Invalid search resource: " + gpu_device +
+                              "Possible reason: resource_config.search_resources does not match your hardware.";
+            return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
     return Status::OK();
@@ -697,8 +710,8 @@ Config::CheckResourceConfigSearchResources(const std::vector<std::string>& value
 Status
 Config::CheckResourceConfigIndexBuildDevice(const std::string& value) {
     if (!CheckGpuDevice(value).ok()) {
-        std::string msg = "Invalid index build device: " + value
-                          + "Possible reason: resource_config.index_build_device is invalid.";
+        std::string msg = "Invalid index build device: " + value +
+                          "Possible reason: resource_config.index_build_device does not match your hardware.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
diff --git a/core/src/server/DBWrapper.cpp b/core/src/server/DBWrapper.cpp
index 2217b29e1c..7efb71075a 100644
--- a/core/src/server/DBWrapper.cpp
+++ b/core/src/server/DBWrapper.cpp
@@ -82,8 +82,7 @@ DBWrapper::StartService() {
         opt.mode_ = engine::DBOptions::MODE::CLUSTER_WRITABLE;
     } else {
         std::cerr << "Error: server_config.deploy_mode in server_config.yaml is not one of "
-                  << "single, cluster_readonly, and cluster_writable."
-                  << std::endl;
+                  << "single, cluster_readonly, and cluster_writable." << std::endl;
         kill(0, SIGUSR1);
     }
 
@@ -164,8 +163,7 @@ DBWrapper::StartService() {
         db_ = engine::DBFactory::Build(opt);
     } catch (std::exception& ex) {
         std::cerr << "Error: failed to open database: " << ex.what()
-                << ". Possible reason: the meta system does not work."
-                << std::endl;
+                  << ". Possible reason: the meta system does not work." << std::endl;
         kill(0, SIGUSR1);
     }
 

From a05cebf5133538650fcbee0601bcc1bdebdfdfa9 Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Tue, 29 Oct 2019 15:18:54 +0800
Subject: [PATCH 08/13] fix job.h header cpplint error

Former-commit-id: c5bfb2f7acdfad00adf818b9cc4b20ce42b7c9e1
---
 core/src/scheduler/job/Job.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/src/scheduler/job/Job.cpp b/core/src/scheduler/job/Job.cpp
index 1199fe17a6..06a163b959 100644
--- a/core/src/scheduler/job/Job.cpp
+++ b/core/src/scheduler/job/Job.cpp
@@ -15,7 +15,7 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include "Job.h"
+#include "scheduler/job/Job.h"
 
 namespace milvus {
 namespace scheduler {

From 96dffcf8ab7219b20621a64efe62ffbf2f7996e1 Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Tue, 29 Oct 2019 15:37:08 +0800
Subject: [PATCH 09/13] format code

Former-commit-id: f809ffd4505ada713620e4996d6fe1004bcc69dc
---
 core/src/server/DBWrapper.cpp | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/core/src/server/DBWrapper.cpp b/core/src/server/DBWrapper.cpp
index 7efb71075a..e3d319ac53 100644
--- a/core/src/server/DBWrapper.cpp
+++ b/core/src/server/DBWrapper.cpp
@@ -40,12 +40,14 @@ DBWrapper::StartService() {
     engine::DBOptions opt;
     s = config.GetDBConfigBackendUrl(opt.meta_.backend_uri_);
     if (!s.ok()) {
+        std::cerr << s.ToString() << std::endl;
         return s;
     }
 
     std::string path;
     s = config.GetDBConfigPrimaryPath(path);
     if (!s.ok()) {
+        std::cerr << s.ToString() << std::endl;
         return s;
     }
 
@@ -55,7 +57,7 @@ DBWrapper::StartService() {
     s = config.GetDBConfigSecondaryPath(db_slave_path);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     StringHelpFunctions::SplitStringByDelimeter(db_slave_path, ";", opt.meta_.slave_paths_);
@@ -64,14 +66,14 @@ DBWrapper::StartService() {
     s = config.GetCacheConfigCacheInsertData(opt.insert_cache_immediately_);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     std::string mode;
     s = config.GetServerConfigDeployMode(mode);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     if (mode == "single") {
@@ -91,7 +93,7 @@ DBWrapper::StartService() {
     s = config.GetEngineConfigOmpThreadNum(omp_thread);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     if (omp_thread > 0) {
@@ -110,7 +112,7 @@ DBWrapper::StartService() {
     s = config.GetEngineConfigUseBlasThreshold(use_blas_threshold);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     faiss::distance_compute_blas_threshold = use_blas_threshold;
@@ -121,7 +123,7 @@ DBWrapper::StartService() {
     s = config.GetDBConfigArchiveDiskThreshold(disk);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     if (disk > 0) {
@@ -131,7 +133,7 @@ DBWrapper::StartService() {
     s = config.GetDBConfigArchiveDaysThreshold(days);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     if (days > 0) {
@@ -174,7 +176,7 @@ DBWrapper::StartService() {
     s = config.GetDBConfigPreloadTable(preload_tables);
     if (!s.ok()) {
         std::cerr << s.ToString() << std::endl;
-        kill(0, SIGUSR1);
+        return s;
     }
 
     s = PreloadTables(preload_tables);

From c63c622cf5c4bcec43a33dacfa2b68518a5a1ddc Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Tue, 29 Oct 2019 16:06:27 +0800
Subject: [PATCH 10/13] update message

Former-commit-id: 568dbdc5d6dc233716682ebec33e6bd3dfe45500
---
 core/conf/server_config.template |  6 +++---
 core/src/server/Config.cpp       | 29 ++++++++++++-----------------
 2 files changed, 15 insertions(+), 20 deletions(-)

diff --git a/core/conf/server_config.template b/core/conf/server_config.template
index 3b366f1bd4..3cb899d1b9 100644
--- a/core/conf/server_config.template
+++ b/core/conf/server_config.template
@@ -2,7 +2,7 @@
 
 server_config:
   address: 0.0.0.0                  # milvus server ip address (IPv4)
-  port: 19530                       # port range: 1025 ~ 65534
+  port: 19530                       # milvus server port, must in range [1025, 6553]
   deploy_mode: single               # deployment type: single, cluster_readonly, cluster_writable
   time_zone: UTC+8                  # time zone, must be in format: UTC+X
 
@@ -24,7 +24,7 @@ metric_config:
   enable_monitor: false             # enable monitoring or not, must be a boolean
   collector: prometheus             # prometheus
   prometheus_config:
-    port: 8080                      # port prometheus uses to fetch metrics, range: 1025 ~ 65534
+    port: 8080                      # port prometheus uses to fetch metrics, must in range [1025, 6553]
 
 cache_config:
   cpu_cache_capacity: 16            # GB, CPU memory used for cache, must be a positive integer
@@ -40,4 +40,4 @@ engine_config:
 resource_config:
   search_resources:                 # define the GPUs used for search computation, must be in format: gpux
     - gpu0
-  index_build_device: gpu0          # GPU used for building index
\ No newline at end of file
+  index_build_device: gpu0          # GPU used for building index, must be in format: gpux
\ No newline at end of file
diff --git a/core/src/server/Config.cpp b/core/src/server/Config.cpp
index 51449cb1de..684d92674c 100644
--- a/core/src/server/Config.cpp
+++ b/core/src/server/Config.cpp
@@ -363,8 +363,8 @@ Config::PrintAll() {
 Status
 Config::CheckServerConfigAddress(const std::string& value) {
     if (!ValidationUtil::ValidateIpAddress(value).ok()) {
-        std::string msg = "Invalid server IP address: " + value +
-                          ". Possible reason: server_config.address is invalid in server_config.yaml.";
+        std::string msg =
+            "Invalid server IP address: " + value + ". Possible reason: server_config.address is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -373,14 +373,13 @@ Config::CheckServerConfigAddress(const std::string& value) {
 Status
 Config::CheckServerConfigPort(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Port " + value + " is not a number. " +
-                          "Possible reason: server_config.port in server_config.yaml is invalid.";
+        std::string msg = "Port " + value + " is not a number. " + "Possible reason: server_config.port is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int32_t port = std::stoi(value);
         if (!(port > 1024 && port < 65535)) {
             std::string msg = "Port " + value + " is not in range [1025, 65534]. " +
-                              "Possible reason: server_config.port in server_config.yaml is invalid.";
+                              "Possible reason: server_config.port is invalid.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -391,7 +390,7 @@ Status
 Config::CheckServerConfigDeployMode(const std::string& value) {
     if (value != "single" && value != "cluster_readonly" && value != "cluster_writable") {
         return Status(SERVER_INVALID_ARGUMENT,
-                      "Error: server_config.deploy_mode in server_config.yaml is not one of "
+                      "Error: server_config.deploy_mode is not one of "
                       "single, cluster_readonly, and cluster_writable.");
     }
     return Status::OK();
@@ -418,8 +417,7 @@ Config::CheckServerConfigTimeZone(const std::string& value) {
 Status
 Config::CheckDBConfigPrimaryPath(const std::string& value) {
     if (value.empty()) {
-        return Status(SERVER_INVALID_ARGUMENT,
-                      "db_path is empty. Possible reason: db_config.db_path in server_config.yaml is empty.");
+        return Status(SERVER_INVALID_ARGUMENT, "db_path is empty. Possible reason: db_config.db_path is empty.");
     }
     return Status::OK();
 }
@@ -433,8 +431,7 @@ Status
 Config::CheckDBConfigBackendUrl(const std::string& value) {
     if (!ValidationUtil::ValidateDbURI(value).ok()) {
         std::string msg =
-            "Invalid db_backend_url: " + value +
-            ". Possible reason: db_config.db_backend_url is invalid in server_config.yaml. " +
+            "Invalid db_backend_url: " + value + ". Possible reason: db_config.db_backend_url is invalid. " +
             "The correct format should be like sqlite://:@:/ or mysql://root:123456@127.0.0.1:3306/milvus.";
         return Status(SERVER_INVALID_ARGUMENT, "invalid db_backend_url: " + value);
     }
@@ -445,7 +442,7 @@ Status
 Config::CheckDBConfigArchiveDiskThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid archive disk threshold: " + value +
-                          "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
+                          "Possible reason: db_config.archive_disk_threshold is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -455,7 +452,7 @@ Status
 Config::CheckDBConfigArchiveDaysThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid archive days threshold: " + value +
-                          "Possible reason: db_config.archive_disk_threshold in server_config.yaml is invalid.";
+                          "Possible reason: db_config.archive_disk_threshold is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -465,15 +462,13 @@ Status
 Config::CheckDBConfigInsertBufferSize(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid insert buffer size: " + value +
-                          "Possible reason: db_config.insert_buffer_size in server_config.yaml "
-                          "is not a positive integer.";
+                          "Possible reason: db_config.insert_buffer_size is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int64_t buffer_size = std::stoi(value) * GB;
         if (buffer_size <= 0) {
             std::string msg = "Invalid insert buffer size: " + value +
-                              "Possible reason: db_config.insert_buffer_size in server_config.yaml "
-                              "is not a positive integer.";
+                              "Possible reason: db_config.insert_buffer_size is not a positive integer.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
 
@@ -535,7 +530,7 @@ Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
         if (static_cast<uint64_t>(cpu_cache_capacity) >= total_mem) {
             std::string msg = "Invalid cpu cache capacity: " + value +
-                              "Possible reason: Cache config cpu_cache_capacity exceeds system memory.";
+                              "Possible reason: cache_config.cpu_cache_capacity exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         } else if (static_cast<double>(cpu_cache_capacity) > static_cast<double>(total_mem * 0.9)) {
             std::cerr << "WARNING: cpu cache capacity value is too big" << std::endl;

From bfdc80401d4c560b256cb9e887543cbd17b57e7b Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Tue, 29 Oct 2019 16:15:14 +0800
Subject: [PATCH 11/13] fix typo

Former-commit-id: bc177ec75ef30265a1358961f89966c8d6ea535c
---
 core/conf/server_config.template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/conf/server_config.template b/core/conf/server_config.template
index 3cb899d1b9..3feb16fd63 100644
--- a/core/conf/server_config.template
+++ b/core/conf/server_config.template
@@ -2,7 +2,7 @@
 
 server_config:
   address: 0.0.0.0                  # milvus server ip address (IPv4)
-  port: 19530                       # milvus server port, must in range [1025, 6553]
+  port: 19530                       # milvus server port, must in range [1025, 65534]
   deploy_mode: single               # deployment type: single, cluster_readonly, cluster_writable
   time_zone: UTC+8                  # time zone, must be in format: UTC+X
 
@@ -24,7 +24,7 @@ metric_config:
   enable_monitor: false             # enable monitoring or not, must be a boolean
   collector: prometheus             # prometheus
   prometheus_config:
-    port: 8080                      # port prometheus uses to fetch metrics, must in range [1025, 6553]
+    port: 8080                      # port prometheus uses to fetch metrics, must in range [1025, 65534]
 
 cache_config:
   cpu_cache_capacity: 16            # GB, CPU memory used for cache, must be a positive integer

From dcc7fbd439ca674bc39aeb859e001c6e4fbe4311 Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Tue, 29 Oct 2019 16:50:55 +0800
Subject: [PATCH 12/13] update message

Former-commit-id: 84f9b8ce2ac8050128f678754123ae2716e3b342
---
 core/src/server/Config.cpp | 75 +++++++++++++++++++-------------------
 1 file changed, 38 insertions(+), 37 deletions(-)

diff --git a/core/src/server/Config.cpp b/core/src/server/Config.cpp
index 684d92674c..937556824e 100644
--- a/core/src/server/Config.cpp
+++ b/core/src/server/Config.cpp
@@ -373,13 +373,13 @@ Config::CheckServerConfigAddress(const std::string& value) {
 Status
 Config::CheckServerConfigPort(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Port " + value + " is not a number. " + "Possible reason: server_config.port is invalid.";
+        std::string msg = "Invalid server port: " + value + ". Possible reason: server_config.port is not a number.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int32_t port = std::stoi(value);
         if (!(port > 1024 && port < 65535)) {
-            std::string msg = "Port " + value + " is not in range [1025, 65534]. " +
-                              "Possible reason: server_config.port is invalid.";
+            std::string msg = "Invalid server port: " + value +
+                              ". Possible reason: server_config.port is not in range [1025, 65534].";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -390,7 +390,7 @@ Status
 Config::CheckServerConfigDeployMode(const std::string& value) {
     if (value != "single" && value != "cluster_readonly" && value != "cluster_writable") {
         return Status(SERVER_INVALID_ARGUMENT,
-                      "Error: server_config.deploy_mode is not one of "
+                      "server_config.deploy_mode is not one of "
                       "single, cluster_readonly, and cluster_writable.");
     }
     return Status::OK();
@@ -399,15 +399,15 @@ Config::CheckServerConfigDeployMode(const std::string& value) {
 Status
 Config::CheckServerConfigTimeZone(const std::string& value) {
     if (value.length() <= 3) {
-        return Status(SERVER_INVALID_ARGUMENT, "Invalid server config time_zone: " + value);
+        return Status(SERVER_INVALID_ARGUMENT, "Invalid server_config.time_zone: " + value);
     } else {
         if (value.substr(0, 3) != "UTC") {
-            return Status(SERVER_INVALID_ARGUMENT, "Invalid server config time_zone: " + value);
+            return Status(SERVER_INVALID_ARGUMENT, "Invalid server_config.time_zone: " + value);
         } else {
             try {
                 stoi(value.substr(3));
             } catch (...) {
-                return Status(SERVER_INVALID_ARGUMENT, "Invalid server config time_zone: " + value);
+                return Status(SERVER_INVALID_ARGUMENT, "Invalid server_config.time_zone: " + value);
             }
         }
     }
@@ -417,7 +417,7 @@ Config::CheckServerConfigTimeZone(const std::string& value) {
 Status
 Config::CheckDBConfigPrimaryPath(const std::string& value) {
     if (value.empty()) {
-        return Status(SERVER_INVALID_ARGUMENT, "db_path is empty. Possible reason: db_config.db_path is empty.");
+        return Status(SERVER_INVALID_ARGUMENT, "db_config.db_path is empty.");
     }
     return Status::OK();
 }
@@ -431,7 +431,7 @@ Status
 Config::CheckDBConfigBackendUrl(const std::string& value) {
     if (!ValidationUtil::ValidateDbURI(value).ok()) {
         std::string msg =
-            "Invalid db_backend_url: " + value + ". Possible reason: db_config.db_backend_url is invalid. " +
+            "Invalid backend url: " + value + ". Possible reason: db_config.db_backend_url is invalid. " +
             "The correct format should be like sqlite://:@:/ or mysql://root:123456@127.0.0.1:3306/milvus.";
         return Status(SERVER_INVALID_ARGUMENT, "invalid db_backend_url: " + value);
     }
@@ -442,7 +442,7 @@ Status
 Config::CheckDBConfigArchiveDiskThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid archive disk threshold: " + value +
-                          "Possible reason: db_config.archive_disk_threshold is invalid.";
+                          ". Possible reason: db_config.archive_disk_threshold is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -452,7 +452,7 @@ Status
 Config::CheckDBConfigArchiveDaysThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid archive days threshold: " + value +
-                          "Possible reason: db_config.archive_disk_threshold is invalid.";
+                          ". Possible reason: db_config.archive_disk_threshold is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -462,13 +462,13 @@ Status
 Config::CheckDBConfigInsertBufferSize(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid insert buffer size: " + value +
-                          "Possible reason: db_config.insert_buffer_size is not a positive integer.";
+                          ". Possible reason: db_config.insert_buffer_size is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int64_t buffer_size = std::stoi(value) * GB;
         if (buffer_size <= 0) {
             std::string msg = "Invalid insert buffer size: " + value +
-                              "Possible reason: db_config.insert_buffer_size is not a positive integer.";
+                              ". Possible reason: db_config.insert_buffer_size is not a positive integer.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
 
@@ -476,7 +476,7 @@ Config::CheckDBConfigInsertBufferSize(const std::string& value) {
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
         if (buffer_size >= total_mem) {
             std::string msg =
-                "Invalid insert buffer size: " + value + "Possible reason: insert buffer size exceeds system memory.";
+                "Invalid insert buffer size: " + value + ". Possible reason: insert buffer size exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -487,7 +487,7 @@ Status
 Config::CheckMetricConfigEnableMonitor(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsBool(value).ok()) {
         std::string msg =
-            "Invalid metric config: " + value + "Possible reason: metric_config.enable_monitor is not a boolean.";
+            "Invalid metric config: " + value + ". Possible reason: metric_config.enable_monitor is not a boolean.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -496,7 +496,8 @@ Config::CheckMetricConfigEnableMonitor(const std::string& value) {
 Status
 Config::CheckMetricConfigCollector(const std::string& value) {
     if (value != "prometheus") {
-        std::string msg = "Invalid metric config: " + value + "Possible reason: metric_config.collector is invalid.";
+        std::string msg =
+            "Invalid metric collector: " + value + ". Possible reason: metric_config.collector is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -505,8 +506,8 @@ Config::CheckMetricConfigCollector(const std::string& value) {
 Status
 Config::CheckMetricConfigPrometheusPort(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
-        std::string msg = "Invalid metric config: " + value +
-                          "Possible reason: metric_config.prometheus_config.port is not in range [1025, 65534].";
+        std::string msg = "Invalid metric port: " + value +
+                          ". Possible reason: metric_config.prometheus_config.port is not in range [1025, 65534].";
         return Status(SERVER_INVALID_ARGUMENT, "Invalid metric config prometheus_port: " + value);
     }
     return Status::OK();
@@ -516,13 +517,13 @@ Status
 Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid cpu cache capacity: " + value +
-                          "Possible reason: cache_config.cpu_cache_capacity is not a positive integer.";
+                          ". Possible reason: cache_config.cpu_cache_capacity is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         int64_t cpu_cache_capacity = std::stoi(value) * GB;
         if (cpu_cache_capacity <= 0) {
             std::string msg = "Invalid cpu cache capacity: " + value +
-                              "Possible reason: cache_config.cpu_cache_capacity is not a positive integer.";
+                              ". Possible reason: cache_config.cpu_cache_capacity is not a positive integer.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
 
@@ -530,7 +531,7 @@ Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
         if (static_cast<uint64_t>(cpu_cache_capacity) >= total_mem) {
             std::string msg = "Invalid cpu cache capacity: " + value +
-                              "Possible reason: cache_config.cpu_cache_capacity exceeds system memory.";
+                              ". Possible reason: cache_config.cpu_cache_capacity exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         } else if (static_cast<double>(cpu_cache_capacity) > static_cast<double>(total_mem * 0.9)) {
             std::cerr << "WARNING: cpu cache capacity value is too big" << std::endl;
@@ -545,7 +546,7 @@ Config::CheckCacheConfigCpuCacheCapacity(const std::string& value) {
         int64_t insert_buffer_size = buffer_value * GB;
         if (insert_buffer_size + cpu_cache_capacity >= total_mem) {
             std::string msg = "Invalid cpu cache capacity: " + value +
-                              "Possible reason: sum of cache_config.cpu_cache_capacity and "
+                              ". Possible reason: sum of cache_config.cpu_cache_capacity and "
                               "db_config.insert_buffer_size exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
@@ -557,13 +558,13 @@ Status
 Config::CheckCacheConfigCpuCacheThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsFloat(value).ok()) {
         std::string msg = "Invalid cpu cache threshold: " + value +
-                          "Possible reason: cache_config.cpu_cache_threshold is not in range (0.0, 1.0].";
+                          ". Possible reason: cache_config.cpu_cache_threshold is not in range (0.0, 1.0].";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         float cpu_cache_threshold = std::stof(value);
         if (cpu_cache_threshold <= 0.0 || cpu_cache_threshold >= 1.0) {
             std::string msg = "Invalid cpu cache threshold: " + value +
-                              "Possible reason: cache_config.cpu_cache_threshold is not in range (0.0, 1.0].";
+                              ". Possible reason: cache_config.cpu_cache_threshold is not in range (0.0, 1.0].";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -574,7 +575,7 @@ Status
 Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid gpu cache capacity: " + value +
-                          "Possible reason: cache_config.gpu_cache_capacity is not a positive integer.";
+                          ". Possible reason: cache_config.gpu_cache_capacity is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         uint64_t gpu_cache_capacity = std::stoi(value) * GB;
@@ -590,7 +591,7 @@ Config::CheckCacheConfigGpuCacheCapacity(const std::string& value) {
             return Status(SERVER_UNEXPECTED_ERROR, msg);
         } else if (gpu_cache_capacity >= gpu_memory) {
             std::string msg = "Invalid gpu cache capacity: " + value +
-                              "Possible reason: cache_config.gpu_cache_capacity exceeds GPU memory.";
+                              ". Possible reason: cache_config.gpu_cache_capacity exceeds GPU memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         } else if (gpu_cache_capacity > (double)gpu_memory * 0.9) {
             std::cerr << "Warning: gpu cache capacity value is too big" << std::endl;
@@ -603,13 +604,13 @@ Status
 Config::CheckCacheConfigGpuCacheThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsFloat(value).ok()) {
         std::string msg = "Invalid gpu cache threshold: " + value +
-                          "Possible reason: cache_config.gpu_cache_threshold is not in range (0.0, 1.0].";
+                          ". Possible reason: cache_config.gpu_cache_threshold is not in range (0.0, 1.0].";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     } else {
         float gpu_cache_threshold = std::stof(value);
         if (gpu_cache_threshold <= 0.0 || gpu_cache_threshold >= 1.0) {
             std::string msg = "Invalid gpu cache threshold: " + value +
-                              "Possible reason: cache_config.gpu_cache_threshold is not in range (0.0, 1.0].";
+                              ". Possible reason: cache_config.gpu_cache_threshold is not in range (0.0, 1.0].";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -620,7 +621,7 @@ Status
 Config::CheckCacheConfigCacheInsertData(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsBool(value).ok()) {
         std::string msg = "Invalid cache insert option: " + value +
-                          "Possible reason: cache_config.cache_insert_data is not a boolean.";
+                          ". Possible reason: cache_config.cache_insert_data is not a boolean.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -630,7 +631,7 @@ Status
 Config::CheckEngineConfigUseBlasThreshold(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid blas threshold: " + value +
-                          "Possible reason: engine_config.use_blas_threshold is not a positive integer.";
+                          ". Possible reason: engine_config.use_blas_threshold is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -640,7 +641,7 @@ Status
 Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
     if (!ValidationUtil::ValidateStringIsNumber(value).ok()) {
         std::string msg = "Invalid omp thread number: " + value +
-                          "Possible reason: engine_config.omp_thread_num is not a positive integer.";
+                          ". Possible reason: engine_config.omp_thread_num is not a positive integer.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
@@ -649,7 +650,7 @@ Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
     CommonUtil::GetSystemAvailableThreads(sys_thread_cnt);
     if (omp_thread > static_cast<int32_t>(sys_thread_cnt)) {
         std::string msg = "Invalid omp thread number: " + value +
-                          "Possible reason: engine_config.omp_thread_num exceeds system cpu cores.";
+                          ". Possible reason: engine_config.omp_thread_num exceeds system cpu cores.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -658,7 +659,7 @@ Config::CheckEngineConfigOmpThreadNum(const std::string& value) {
 Status
 Config::CheckResourceConfigMode(const std::string& value) {
     if (value != "simple") {
-        std::string msg = "Invalid resource mode: " + value + "Possible reason: resource_config.mode is invalid.";
+        std::string msg = "Invalid resource mode: " + value + ". Possible reason: resource_config.mode is invalid.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -670,14 +671,14 @@ CheckGpuDevice(const std::string& value) {
     std::cmatch m;
     if (!std::regex_match(value.c_str(), m, pat)) {
         std::string msg = "Invalid gpu device: " + value +
-                          "Possible reason: resource_config.search_resources does not match your hardware.";
+                          ". Possible reason: resource_config.search_resources does not match your hardware.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
 
     int32_t gpu_index = std::stoi(value.substr(3));
     if (!ValidationUtil::ValidateGpuIndex(gpu_index).ok()) {
         std::string msg = "Invalid gpu device: " + value +
-                          "Possible reason: resource_config.search_resources does not match your hardware.";
+                          ". Possible reason: resource_config.search_resources does not match your hardware.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();
@@ -695,7 +696,7 @@ Config::CheckResourceConfigSearchResources(const std::vector<std::string>& value
     for (auto& gpu_device : value) {
         if (!CheckGpuDevice(gpu_device).ok()) {
             std::string msg = "Invalid search resource: " + gpu_device +
-                              "Possible reason: resource_config.search_resources does not match your hardware.";
+                              ". Possible reason: resource_config.search_resources does not match your hardware.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }
@@ -706,7 +707,7 @@ Status
 Config::CheckResourceConfigIndexBuildDevice(const std::string& value) {
     if (!CheckGpuDevice(value).ok()) {
         std::string msg = "Invalid index build device: " + value +
-                          "Possible reason: resource_config.index_build_device does not match your hardware.";
+                          ". Possible reason: resource_config.index_build_device does not match your hardware.";
         return Status(SERVER_INVALID_ARGUMENT, msg);
     }
     return Status::OK();

From bb43a771306dd8ef4237d72189a260fe5a28296c Mon Sep 17 00:00:00 2001
From: starlord <chxiehust@gmail.com>
Date: Tue, 29 Oct 2019 17:19:02 +0800
Subject: [PATCH 13/13] update message

Former-commit-id: 0a5ad5dfd42d76032c5008d9d9e4e2213b161232
---
 core/src/server/Config.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/src/server/Config.cpp b/core/src/server/Config.cpp
index 937556824e..111cc26f9c 100644
--- a/core/src/server/Config.cpp
+++ b/core/src/server/Config.cpp
@@ -475,8 +475,8 @@ Config::CheckDBConfigInsertBufferSize(const std::string& value) {
         uint64_t total_mem = 0, free_mem = 0;
         CommonUtil::GetSystemMemInfo(total_mem, free_mem);
         if (buffer_size >= total_mem) {
-            std::string msg =
-                "Invalid insert buffer size: " + value + ". Possible reason: insert buffer size exceeds system memory.";
+            std::string msg = "Invalid insert buffer size: " + value +
+                              ". Possible reason: db_config.insert_buffer_size exceeds system memory.";
             return Status(SERVER_INVALID_ARGUMENT, msg);
         }
     }