milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix golint error in proxy (#10618) 

Signed-off-by: zhenshan.cao <zhenshan.cao@zilliz.com>
pull/10626/head
zhenshan.cao 2021-10-25 23:32:20 +08:00 committed by GitHub
parent cf574b34a0
commit 9458e04538
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/proxy/validate_util.go
View File

@ -150,7 +150,7 @@ func validateDimension(dim int64, isBinary bool) error {
return nil
}
func ValidateVectorFieldMetricType(field *schemapb.FieldSchema) error {
func validateVectorFieldMetricType(field *schemapb.FieldSchema) error {
if (field.DataType != schemapb.DataType_FloatVector) && (field.DataType != schemapb.DataType_BinaryVector) {
return nil
}

8
internal/proxy/validate_util_test.go
View File

@ -116,21 +116,21 @@ func TestValidateVectorFieldMetricType(t *testing.T) {
TypeParams: nil,
IndexParams: nil,
}
assert.Nil(t, ValidateVectorFieldMetricType(field1))
assert.Nil(t, validateVectorFieldMetricType(field1))
field1.DataType = schemapb.DataType_FloatVector
assert.NotNil(t, ValidateVectorFieldMetricType(field1))
assert.NotNil(t, validateVectorFieldMetricType(field1))
field1.IndexParams = []*commonpb.KeyValuePair{
{
Key: "abcdefg",
Value: "",
},
}
assert.NotNil(t, ValidateVectorFieldMetricType(field1))
assert.NotNil(t, validateVectorFieldMetricType(field1))
field1.IndexParams = append(field1.IndexParams, &commonpb.KeyValuePair{
Key: "metric_type",
Value: "",
})
assert.Nil(t, ValidateVectorFieldMetricType(field1))
assert.Nil(t, validateVectorFieldMetricType(field1))
}
func TestValidateDuplicatedFieldName(t *testing.T) {