Fix memory & goroutine leak (#20152)

Signed-off-by: yah01 <yang.cen@zilliz.com> Signed-off-by: yah01 <yang.cen@zilliz.com>
2022-10-28 14:55:32 +08:00 · 2022-10-28 14:55:32 +08:00 · 8bfa55e560
parent 89541a6f68
commit 8bfa55e560
2 changed files with 2 additions and 0 deletions
--- a/internal/querycoordv2/checkers/controller.go
+++ b/internal/querycoordv2/checkers/controller.go
@ -115,6 +115,7 @@ func (controller *CheckerController) check(ctx context.Context) {
 	for _, task := range tasks {
 		err := controller.scheduler.Add(task)
 		if err != nil {
+			task.Cancel()
 			continue
 		}
 		added++
--- a/internal/querycoordv2/handlers.go
+++ b/internal/querycoordv2/handlers.go
@ -125,6 +125,7 @@ func (s *Server) balanceSegments(ctx context.Context, req *querypb.LoadBalanceRe
 		)
 		err := s.taskScheduler.Add(task)
 		if err != nil {
+			task.Cancel()
 			return err
 		}
 		tasks = append(tasks, task)