From 8b39643e44b6eb2b03ed213586b095a02a9057c1 Mon Sep 17 00:00:00 2001 From: neza2017 Date: Tue, 5 Jan 2021 12:20:46 +0800 Subject: [PATCH] Fix write node crashed if collection meta not existed Signed-off-by: neza2017 --- internal/writenode/flow_graph_insert_buffer_node.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/internal/writenode/flow_graph_insert_buffer_node.go b/internal/writenode/flow_graph_insert_buffer_node.go index bf6180d269..0c001ee55d 100644 --- a/internal/writenode/flow_graph_insert_buffer_node.go +++ b/internal/writenode/flow_graph_insert_buffer_node.go @@ -542,15 +542,21 @@ func (ibNode *insertBufferNode) getMeta(segID UniqueID) (*etcdpb.SegmentMeta, *e segMeta := &etcdpb.SegmentMeta{} key := path.Join(SegmentPrefix, strconv.FormatInt(segID, 10)) - value, _ := ibNode.kvClient.Load(key) - err := proto.UnmarshalText(value, segMeta) + value, err := ibNode.kvClient.Load(key) + if err != nil { + return nil, nil, err + } + err = proto.UnmarshalText(value, segMeta) if err != nil { return nil, nil, err } collMeta := &etcdpb.CollectionMeta{} key = path.Join(CollectionPrefix, strconv.FormatInt(segMeta.GetCollectionID(), 10)) - value, _ = ibNode.kvClient.Load(key) + value, err = ibNode.kvClient.Load(key) + if err != nil { + return nil, nil, err + } err = proto.UnmarshalText(value, collMeta) if err != nil { return nil, nil, err