milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix metric RootCoordInsertChannelTimeTick (#23236) 

Signed-off-by: longjiquan <jiquan.long@zilliz.com>
pull/22572/head
Jiquan Long 2023-04-06 15:30:29 +08:00 committed by GitHub
parent 2c1c3aecfc
commit 8530dfadb4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
internal/rootcoord/timeticksync.go
View File

@ -22,8 +22,6 @@ import (
"sync" "sync"
"time" "time"
"go.uber.org/zap"
"github.com/milvus-io/milvus-proto/go-api/commonpb" "github.com/milvus-io/milvus-proto/go-api/commonpb"
"github.com/milvus-io/milvus-proto/go-api/msgpb" "github.com/milvus-io/milvus-proto/go-api/msgpb"
"github.com/milvus-io/milvus/internal/log" "github.com/milvus-io/milvus/internal/log"
@ -35,6 +33,7 @@ import (
"github.com/milvus-io/milvus/internal/util/timerecord" "github.com/milvus-io/milvus/internal/util/timerecord"
"github.com/milvus-io/milvus/internal/util/tsoutil" "github.com/milvus-io/milvus/internal/util/tsoutil"
"github.com/milvus-io/milvus/internal/util/typeutil" "github.com/milvus-io/milvus/internal/util/typeutil"
"go.uber.org/zap"
) )
var ( var (
@ -300,6 +299,13 @@ func (t *timetickSync) startWatch(wg *sync.WaitGroup) {
// SendTimeTickToChannel send each channel's min timetick to msg stream // SendTimeTickToChannel send each channel's min timetick to msg stream
func (t *timetickSync) sendTimeTickToChannel(chanNames []string, ts typeutil.Timestamp) error { func (t *timetickSync) sendTimeTickToChannel(chanNames []string, ts typeutil.Timestamp) error {
func() {
sub := tsoutil.SubByNow(ts)
for _, chanName := range chanNames {
metrics.RootCoordInsertChannelTimeTick.WithLabelValues(chanName).Set(float64(sub))
}
}()
msgPack := msgstream.MsgPack{} msgPack := msgstream.MsgPack{}
baseMsg := msgstream.BaseMsg{ baseMsg := msgstream.BaseMsg{
BeginTimestamp: ts, BeginTimestamp: ts,
@ -323,10 +329,6 @@ func (t *timetickSync) sendTimeTickToChannel(chanNames []string, ts typeutil.Tim
return err return err
} }
sub := tsoutil.SubByNow(ts)
for _, chanName := range chanNames {
metrics.RootCoordInsertChannelTimeTick.WithLabelValues(chanName).Set(float64(sub))
}
return nil return nil
} }