milvus-io
/
milvus
mirror of https://github.com/milvus-io/milvus.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix panic during close delte flow graph (#28202) 

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
pull/28200/head
wei liu 2023-11-06 22:06:20 +08:00 committed by GitHub
parent 2ea8a27d50
commit 7f7a19d6c1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
internal/querynode/data_sync_service.go
View File

@ -278,10 +278,10 @@ func (dsService *dataSyncService) removeEmptyFlowGraphByChannel(collectionID int
// start to release flow graph
log.Info("all segments released, start to remove deltaChannel flowgraph")
delete(dsService.deltaChannel2FlowGraph, dc)
dsService.metaReplica.removeCollectionVDeltaChannel(collectionID, dc)
// close flowgraph first, so no write will be dispatched to tSafeReplica
fg.close()
metrics.QueryNodeNumFlowGraphs.WithLabelValues(fmt.Sprint(Params.QueryNodeCfg.GetNodeID())).Dec()
dsService.metaReplica.removeCollectionVDeltaChannel(collectionID, dc)
dsService.tSafeReplica.removeTSafe(dc)
// try best to remove, it's ok if all info is gone before this call
rateCol.removeTSafeChannel(dc)
@ -291,8 +291,8 @@ func (dsService *dataSyncService) removeEmptyFlowGraphByChannel(collectionID int
func newDataSyncService(ctx context.Context,
metaReplica ReplicaInterface,
tSafeReplica TSafeReplicaInterface,
factory msgstream.Factory) *dataSyncService {
factory msgstream.Factory,
) *dataSyncService {
return &dataSyncService{
ctx: ctx,
dmlChannel2FlowGraph: make(map[Channel]*queryNodeFlowGraph),