solve conflicts

Signed-off-by: Wang Xiangyu <xy.wang@zilliz.com>
pull/3584/head
Wang Xiangyu 2020-09-04 18:56:44 +08:00
commit 7e863578d9
5 changed files with 26 additions and 5 deletions

15
.github/ISSUE_TEMPLATE/enhancement.md vendored Normal file
View File

@ -0,0 +1,15 @@
---
name: "Enhancement request"
about: Suggest an enhancement idea for Milvus
title: ''
labels: ''
assignees: ''
---
**Please state your issue using the following template and, most importantly, in English.**
**What would you like to be added ?**
**Why is this needed ?**

View File

@ -97,6 +97,7 @@ pipeline {
TARGET_REPO = "${params.DOKCER_REGISTRY_URL}/milvus/engine"
SOURCE_TAG = "${CHANGE_TARGET ? CHANGE_TARGET : SEMVER}-${BINARY_VERSION}-${OS_NAME}-${LOWER_BUILD_TYPE}"
TARGET_TAG = "${SEMVER}-${BINARY_VERSION}-${OS_NAME}-${LOWER_BUILD_TYPE}"
DOCKER_BUILDKIT = 1
}
agent {
kubernetes {

View File

@ -217,6 +217,8 @@ Resource::executor_function() {
ResMgrInst::GetInstance()->GetResource("disk")->WakeupLoader();
}
task_item->task = FinishedTask::Create(task_item->task);
if (subscriber_) {
auto event = std::make_shared<FinishTaskEvent>(shared_from_this(), task_item);
subscriber_(std::static_pointer_cast<Event>(event));

View File

@ -14,11 +14,14 @@
namespace milvus::scheduler {
std::shared_ptr<FinishedTask>
FinishedTask::Create() {
return std::make_shared<FinishedTask>();
FinishedTask::Create(const TaskPtr& task) {
return std::make_shared<FinishedTask>(task);
}
FinishedTask::FinishedTask() : Task(TaskType::SearchTask, nullptr) {
FinishedTask::FinishedTask(const TaskPtr& task) : Task(TaskType::SearchTask, nullptr) {
Task::task_path_ = task->task_path_;
Task::type_ = task->type_;
Task::label_ = task->label_;
}
Status

View File

@ -20,10 +20,10 @@ namespace milvus::scheduler {
class FinishedTask : public Task {
public:
static std::shared_ptr<FinishedTask>
Create();
Create(const TaskPtr& task);
public:
FinishedTask();
explicit FinishedTask(const TaskPtr& task);
Status
OnLoad(LoadType type, uint8_t device_id) override;