update dimension range of diskann. (#26405)

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
pull/26448/head
cqy123456 2023-08-17 20:26:20 +08:00 committed by GitHub
parent 4a388cf450
commit 7e3323a518
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 2 additions and 13 deletions

View File

@ -20,11 +20,6 @@ const (
// DefaultMaxDim is the largest dimension supported in Milvus
DefaultMaxDim = 32768
// If Dim = 32 and raw vector data = 2G, query node need ~17G disk space When loading the vectors' disk index
// If Dim = 2, and raw vector data = 2G, query node need ~60G disk space When loading the vectors' disk index
// So DiskAnnMinDim should be greater than or equal to 8 to avoid running out of disk space
DiskAnnMinDim = 8
HNSWMinEfConstruction = 8
HNSWMaxEfConstruction = 512
HNSWMinM = 4

View File

@ -9,13 +9,6 @@ func (c diskannChecker) StaticCheck(params map[string]string) error {
return c.staticCheck(params)
}
func (c diskannChecker) CheckTrain(params map[string]string) error {
if !CheckIntByRange(params, DIM, DiskAnnMinDim, DefaultMaxDim) {
return errOutOfRange(DIM, DiskAnnMinDim, DefaultMaxDim)
}
return c.StaticCheck(params)
}
func newDiskannChecker() IndexChecker {
return &diskannChecker{}
}

View File

@ -23,7 +23,7 @@ func Test_diskannChecker_CheckTrain(t *testing.T) {
}
invalidParamsSmallDim := copyParams(validParams)
invalidParamsSmallDim[DIM] = strconv.Itoa(4)
invalidParamsSmallDim[DIM] = strconv.Itoa(0)
p1 := map[string]string{
DIM: strconv.Itoa(128),

View File

@ -1880,6 +1880,7 @@ class TestIndexDiskann(TestcaseBase):
for t in threads:
t.join()
@pytest.mark.skip(reason = "diskann dim range is set to be [1, 32768)")
@pytest.mark.tags(CaseLabel.L1)
@pytest.mark.parametrize("dim", [1, 2, 4, 6])
def test_create_index_with_small_dim(self, dim):